[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-06-13 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/6059 It would be great if @Aitozi could also report any numbers he has, so that we see the benefits of the change. ---

[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-06-04 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6059 @dawidwys I'm sorry, I don't have a systematic testing tool. I'm working on the inner dynamic cep and `CEPOperator` can process serveral `NFA` when receive an element. Then i encounter the backpressur

[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-06-04 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6059 Thanks @Aitozi for your interest. It is a good question why the build failed, I will have a look. Could you shed some more light how will you test the change in performance? Maybe you could

[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-06-02 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6059 After go through the whole change, i think it is extremely a good feature 👍, and i will apply this patch to our inner library to test how much the performance improved. A little question: why t

[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-06-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/6059 Hi @dawidwys! Thanks for the work. The changes seem really good. As we discussed privately I did a review and the comments you can find them in the branch I sent you. The only things I

[GitHub] flink issue #6059: [Flink-9418] Migrate SharedBuffer to use MapState

2018-05-23 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6059 R: @kl0u ---