[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-31 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5347 Thanks @hequn8128 and @fhueske. I will merge this... ---

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-26 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5347 Thanks for the fix @hequn8128! PR is good to merge. ---

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-26 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 hi, @fhueske Thanks for your suggestions. The pr has been updated according to your comments. ---

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-25 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 hi @fhueske @twalthr , the pr has been updated. It would be great if you can take a look at it. Changes mainly include: 1. Adapt estimateRowCount to be more accurate. The original impl

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-24 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 Hi, @fhueske @twalthr , To solve the problem, we need to make the `estimateRowCount` in `CommonCalc` more accurate. I will update the pr tomorrow. Anyway, cost model can't solve the proble

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-24 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5347 @twalthr thanks for your review. I will take a look and update the pr. ---

[GitHub] flink issue #5347: [FLINK-8492][table] Fix calc cost bug

2018-01-24 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5347 Thank you @hequn8128. I will merge this... ---