Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5342
Thanks for the work @florianschmidt1994 ! Merging this.
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5342
Thanks @florianschmidt1994 . I will, but may be not today.
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
@kl0u I made some changes on how I handle events on either side of the
stream. By introducing some generic methods we can now reuse large parts of the
code for either input stream and remo
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5342
Changes look good to me! I will let it run on Travis and then merge.
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
@hequn8128 Thank you for the review. Regarding your concern about delaying
the watermark I added some sketches and description about my thought process to
the design document.
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
@bowenli86 the document should now be be public for everyone to comment on.
Yes, it caches data on either side, and for each incoming element it looks
up eligible records from the othe
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5342
Very interesting! two things:
1. can you make the google doc publicly viewable? I cannot access it right
now
2. how does it handle event time window joins of two streams, where data in
one
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
Yeah seems like I made a typo there. It's actually
https://issues.apache.org/jira/browse/FLINK-8479, I just fixed the title.
---
