Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5133
merging.
---
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5133
OK
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5133
I think this is good, except for the removal of
`StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME` where I am unsure if
some of the pending FLIP-6 work has plans for that. I would suggest
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5133
[ERROR]
src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceUtils.java:[41,8]
(imports) UnusedImports: Unused import: java.net.InetSocketAddress.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5133
@casidiablo please also describe why or how the removed code came to be
unused. I see that `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME`
was left unused by `433a345e`.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5133
LGTM.
---