[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2018-01-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5133 merging. ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-17 Thread casidiablo
Github user casidiablo commented on the issue: https://github.com/apache/flink/pull/5133 OK ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5133 I think this is good, except for the removal of `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME` where I am unsure if some of the pending FLIP-6 work has plans for that. I would suggest

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5133 [ERROR] src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceUtils.java:[41,8] (imports) UnusedImports: Unused import: java.net.InetSocketAddress. ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5133 @casidiablo please also describe why or how the removed code came to be unused. I see that `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME` was left unused by `433a345e`. ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-07 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5133 LGTM. ---