[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2018-01-08 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4896 Thanks for your review @GJL. I've addressed all your comments. I rebased this PR onto #4890. Once Travis gives green light, I'll merge it. ---

[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2017-10-26 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4896 Yes, this can wait until after the fork. Moreover, I will do what @StephanEwen suggested and count the number of executed tests before and after of this change to make sure that we don't introdu

[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2017-10-26 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4896 Do you intend to merge this for 1.4? (I would prefer merging it after the fork). ---

[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2017-10-26 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4896 It compiles now @zentol. ---

[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2017-10-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4896 Doesn't compile: ```[INFO] flink-hadoop-compatibility . FAILURE [ 5.449 s] [INFO] flink-avro . SKIPPED [INFO] flink-tests ..

[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2017-10-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4896 The diffs looks good, but what I cannot judge in a final manner is whether some tests now get not executed any more (accidentally). What would be good is to take the Travis output from th