[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4569 Thanks a lot @tillrohrmann ! This is a pretty useful API addition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4569 One last change I'd like to apply before merging is to let the user provide the target address and target port to the method `sendRequest` instead of to the `RestClientEndpoint` constructor. Tha

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann I've address the remaining comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann I've reworked the client response parsing: the `ClientHandler` now only parses the response as JSON, whereas the conversion to the respective `ResponseBody` is handled in a future declar

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann I've addressed most of your comments. I have implemented the `HandlerResponse` as you suggested (casting option) for now, and include all query parameter as a list. ## U

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann @kl0u Would be great if you could take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha