[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public

2017-06-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4148 Will fix the typo while merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public

2017-06-22 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4148 Yes, there are no tests, but the examples need to be reworked soon anyway. The Table API has much more features than shown in this very simple examples. --- If your project is set up for it, you can

[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public

2017-06-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4148 Did we overlook adding a test to run the table examples? I think we do this for streaming and batch. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #4148: [FLINK-6956] Make table example POJO classes public

2017-06-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4148 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the