Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4112
LGTM on a second look. Don't have any suggestion on NettyBufferPool. @uce?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4112
I've adjusted the suppressions file to properly work on windows
(slashes...), and resolves the few issues in flink-runtime.
I'm a bit unsure about the change in the NettyBufferPool, @uce does
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4112
Looks like the same problem we have in flink-core also exists in
flink-runtime, some braces are missing...
```
[INFO] There are 10 errors reported by Checkstyle 6.19 with
/tools/maven/che
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4112
+1 and my apologies for overlooking your comprehensive description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4112
yes, i intended to include FLINK-6902, as described in the second paragraph
of the PR description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4112
@zentol did you mean to include `[FLINK-6902] Activate strict checkstyle
for flink-streaming-scala` as the first commit?
---
If your project is set up for it, you can reply to this email and have
