[GitHub] flink issue #3793: flink-6033 Support UNNEST query in the stream SQL API

2017-05-06 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3793 Thanks for the update @suez1224! Looks good to me. Will do some minor refactoring and merge this PR. Best, Fabian --- If your project is set up for it, you can reply to this email and ha

[GitHub] flink issue #3793: flink-6033 Support UNNEST query in the stream SQL API

2017-05-05 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/3793 @twalthr , can you take a look when you have time? I have added the LogicalUnnestRule and unitest for batch as well. Thanks a lot. --- If your project is set up for it, you can reply to this emai

[GitHub] flink issue #3793: flink-6033 Support UNNEST query in the stream SQL API

2017-05-04 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/3793 Thanks a lot for reviewing the PR, @twalthr. It turns out the change in basic type arrays is not needed. Regarding introducing the LogicalUnnestRule, I think it's a good idea. I'll look in

[GitHub] flink issue #3793: flink-6033 Support UNNEST query in the stream SQL API

2017-05-03 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3793 Thanks for the PR @suez1224. I think we need to rework this PR a little bit, before we can merge it. I saw that you had problems using basic type arrays such as `Integer[]`. I think we should cover t