Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3127
Looks good, thank you!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/flink/pull/3127
Hi @StephanEwen could you continue review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3127
@StephanEwen I fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3127
Found one more small concern (inline comment)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3127
Looks good to me, +1
@twalthr @fhueske Any concerns about merging this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3127
Hi @StephanEwen
I added javadoc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3127
@StephanEwen @twalthr What do you think about this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3127
I think this goes into a good direction.
I am wondering, though, if we need types like "time interval" in
`flink-core`. I would prefer to keep then in the Table API scope.
There can b
