[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I think I should rename this issuea to "Simplify Row creation". What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-02-02 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 ```scala import Types._ ROW(Array("person", "additional"), ROW(Array("name", "age"), STRING, STRING), ROW(Array("more_info", "and_so_on"), STRING, STRING)) ```

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-31 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @twalthr I think it's good way. Should I move `TimeIntervalTypeInfo` to core as well or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-30 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3127 In the Table API we implemented `org.apache.flink.table.api.Types` to improve the user experience. We could also think about moving this to core. I would be helpful to have a class that enumerates al

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-30 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I suggest add a little bit more sugar ```java TypeInformation infoNew = RowTypeInfo.from( new String[]{"1c", "2c"}, RowTypeInfo.from( new String[]{"1.1", "1.2c"},

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-27 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3127 Hmmm... what would you suggest to do instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-27 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I think all it's just a syntax sugar ```scala val data = List( Row.of(Row.of("data_1", "dob"), Row.of("info_4", "dub")), Row.of(Row.of("data_1", "dob"), Row.of("in

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3127 You could think of adding a utility method on the RowTypeInfo: ```java @SafeVarAgrs RowTypeInfo.from(Class... types) ``` and use it like ```java StreamExecutionEnvironme

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-26 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3127 We can simply do it like this: ``` StreamExecutionEnvironment.fromCollection( rows, new RowTypeInfo(BasicTypeInfo.STRING_TYPE_INFO, BasicTypeInfo.INT_TYPE_INFO)) ``` ---

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-26 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen I agree with types conflicting and that it's not common type for collection. So how should generating a row type info look like? --- If your project is set up for it, you can reply

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-26 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3127 I would also be fine with `StreamExecutionEnvironment.fromCollection(rows, type)`. What do you think @tonycox? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3127 I am a bit skeptical about the special case handling or Row in the type exatractor there. Why specifically support row and not other types? To me, Row does not seem like a most common type to

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3127 I will shepherd this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-17 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @zentol I rewrite as you pointed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and