[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-18 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3110 There were, but only in my head. Maybe we should open an issue or discuss on the ML. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3110 Thanks @aljoscha, those are my concerns as well. The methods are very prominent in the core APIs and provide only marginal value. It's pretty straightforward to implement the functionality with a `Re

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-18 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3110 Thanks for notifying @fhueske! And sorry for not noticing this earlier and jumping on so late. I think this part of the API is already to bloated and (at the same time) not powerful enough.

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-07 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3110 Thanks @gallenvara, the changes look good to me but we would also need a few tests. @aljoscha, what do you think about this change? Should we add it to be consistent with the Java API or do

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-05 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3110 @fhueske @twalthr . Can you help with reviewing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h