Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3077
Changes look really good to me :-) Travis is passing modulo an unrelated
test failure. Will merge this PR. Thanks a lot for your contribution @Fokko.
---
If your project is set up for it, you c
Github user Fokko commented on the issue:
https://github.com/apache/flink/pull/3077
@tillrohrmann I've added documentation about the algorithm. Can you check?
Cheers, Fokko
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Fokko commented on the issue:
https://github.com/apache/flink/pull/3077
Thanks @tillrohrmann, excellent idea regarding the documentation. I'll also
process the code comments, good feedback. Somewhere today or tomorrow I will
fix this.
Cheers, Fokko
---
If your p
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3077
Thanks for your contribution @Fokko. I'll take a look at this PR in the
next days :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user Fokko commented on the issue:
https://github.com/apache/flink/pull/3077
I think we have some flakey tests, since it passes on my own travis:
https://travis-ci.org/Fokko/flink/builds/189855914
---
If your project is set up for it, you can reply to this email and have yo
