Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/3022
Thank you @aljoscha, @xhumanoid
Closing the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3022
Merged. Could you please close this PR and the Jira issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3022
I'm running a last check and then I'm merging. Thanks for reviewing
@xhumanoid! And thanks for fixing it @mushketyk. ð
---
If your project is set up for it, you can reply to this email and have
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3022
@aljoscha could you check and merge commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/3022
Hi @xhumanoid,
Sorry, I didn't notice that the same applies to `minBy` :)
I've updated the code according to your review.
Could you please review it again?
---
If your project is s
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3022
The same javadoc issue apply for minBy ;)
I pointed maxBy only as example
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/3022
Hi @xhumanoid
I've updated my PR according to your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3022
After commit we have inconsistency between javadoc comment and arguments.
for both
_public SingleOutputStreamOperator maxBy(int positionToMaxBy)_
_public SingleOutputStreamOperator maxBy(
