Github user jgrier commented on the issue:
https://github.com/apache/flink/pull/2982
Nice :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
Wow, finally in!
It was fun and thanks for you help along every step of the journey!
Chen
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
@chenqin I finally merged it. Could you please also close this PR?
And thanks again for working on this for so long! ð
---
If your project is set up for it, you can reply to this email
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha
Nice! Let's do "Chen Qin qinnc...@gmail.com"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
@chenqin Would you like your commits to be attributed to "Chen Qin
"
or "Chen Qin "? I see both in your set of commits?
I'm finally putting everything together and hopefully merging soon
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
Thanks for looking at that! I'll open a new discussion thread on the
Mailing lists to discuss Side Outputs and split/select and how we're going to
proceed with that.
Regarding your other qu
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha Looks good to me ð
I briefly looked at your git branch, a minor comment would be adding
comments to `sideOutputLateData` so user get better idea when they opt-in to
late arrivin
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
@chenqin
I rebased and consolidated your PR a bit and played around with the APIs.
Some of the changes:
- Separation into internal changes/window operator changes and
user-fun
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha,
diff has been updated and merged to support `apply(Function,
lateElementsOutput);`
`Collector` refactor seems not viable option as stated above.
Seems travis-ci timeo
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha Thanks for your time. We can chat more after 1.2 release!
I think it makes sense to extends Collector, even though we may not remove
collect(T obj) due to API compability issue in 1
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
@chenqin I had a quick look at the implementation and it looks quite good.
I'll look at it in more detail once the 1.2 release is out and then I'll also
have more thorough comments.
These a
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
cc @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
12 matches
Mail list logo
