Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2761
No worries :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske Sorry for the problems you have raised, I can see the painful now,
I will avoid the same mistake.
Thanks for your time I really appreciate it.
---
If your project is set up for it, you
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2761
Thanks for the update @ch33hau.
I made a quick pass over the PR and it looks quite good. Will have a more
detailed look in the next days and probably merge it.
Thanks for porting the exa
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @fhueske this is ready for review.
I have moved Java's IT cases to
`org.apache.flink.streaming.test.StreamingExamplesITCase` and Scala's IT cases
to `org.apache.flink.streaming.scala.exam
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske very sorry about this decade-long delay... I was working on some
relocation stuff for the past few months.
I have rebased and push a commit for fixing the PR comments:
- Remove
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2761
@ch33hau, sure!
Just drop a comment when you updated the PR (a simple push does not trigger
a notification but a comment does).
Thanks, Fabian
---
If your project is set up for it, you
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske it is ok, and thanks for the review =)
I couldn't fix them now and I might start working on your comments in 1 day.
---
If your project is set up for it, you can reply to this email and
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @ch33hau, I'm sorry!
I haven't had a look at it yet.
I'll do that in the next days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @fhueske , any update on this? =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2761
Thanks for the patience @ch33hau and the reviews @thvasilo!
I've put this PR on my list and will have a look at it soon.
Thanks, Fabian
---
If your project is set up for it, you can rep
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @thvasilo, thanks for the help, it's ok, knew that everyone is quite
busy =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2761
Hello @ch33hau, sorry for the late reply, I've been at a conference the
past week. With the latest changes this LGTM, I've edited the fix version in
JIRA to 1.2.0 to give this more visibility for th
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @thvasilo thank you for taking your time on this PR again.
I have fixed the typos and couple of one-line-if statements, sorry for
those mistakes =( .
---
If your project is set up for it, yo
13 matches
Mail list logo
