Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2737
I've created a fix:
https://github.com/rmetzger/flink/commit/28a3aed8633246717c52599c25ced928436a6f97
and pushed it to my travis account (Github has a service outage, that's why
travis builds ar
Github user Makman2 commented on the issue:
https://github.com/apache/flink/pull/2737
yeah I think also an outline image is better :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
Why not keep the color image for the favicons? The smaller size looks like
a black blob to my eyes. The current color icon is distinctive and will look
even better at 32x32. If we wanted to use B&W
Github user siliconcat commented on the issue:
https://github.com/apache/flink/pull/2737
Ok, what about this? Black and white for the favicon in browsers. In colour
for the mobile screens. Generated using the favicon generator above...
Couldn't test the iphone, as I don't have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
The Travis CI tests have never been stable. There are five parallel builds
each split into two jobs and 9 of 10 passed for the latest commit on this PR.
The tests are significantly more stable when
Github user Makman2 commented on the issue:
https://github.com/apache/flink/pull/2737
> Could we enhance the favicon itself?
Maybe we can use the grayscale / black-white version of the flink logo,
could fit more into the default dashboard design^^
> Not sure how this
Github user siliconcat commented on the issue:
https://github.com/apache/flink/pull/2737
I just re-used the one in the main Flink site. No artist myself :)
Not sure how this could break the build either?
---
If your project is set up for it, you can reply to this email and ha
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
Could we enhance the favicon itself? I tried
`http://realfavicongenerator.net/` and there are many other 'favicon
generators'.
I used this image:
https://github.com/apache/flink-web/blob/
Github user siliconcat commented on the issue:
https://github.com/apache/flink/pull/2737
Now, the index file with the modification is there. Sorry for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user siliconcat commented on the issue:
https://github.com/apache/flink/pull/2737
It does, let me see why the file does not apear in the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user Makman2 commented on the issue:
https://github.com/apache/flink/pull/2737
Not a web-dev, though doesn't need this some modifications in the according
HTMLs to properly perenst the favicon?
---
If your project is set up for it, you can reply to this email and have your
rep
11 matches
Mail list logo
