Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2445
The approach looks good, but I think it would be good to adjust a few
things:
- We are migrating most of the Scala code in `flink-runtime` to Java (for
example in FLIP-6), so would be good
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2445
@StephanEwen I moved the code into a separate class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2445
that should be doable, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2445
Can we move this code out of the TaskManager as a whole, into a metrics
Utility?
We could make it reusable for the JobManager as well, by passing the metric
group where that should be added.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2445
Version 2 is up. Essentially, we now attempt to use the methods before
registering the metrics. I've also adjusted the new CPU metrics.
---
If your project is set up for it, you can reply to this ema
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2445
But i see the issue that could arise, will rework the solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2445
This is the pretty-much same code that the new CPU metric uses which has
not caused issues so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2445
Does this work? The reason for the initial reflection-based initialization
was that the sun-specific class may not be available in some environments. I am
unsure when the "ClassNotFound" error wi
