Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Hey @zentol. Thank you for your comments.
I've updated the PR. Could you take a look at it again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
@zentol I've updated Meter's interface. Could you give this PR another
review?
Sorry for the force push, I had to rebase on top of `master` to resolve
merge conflict.
---
If your project is s
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
0, seems more reasonable to me (sort of no-data).
I'll update the PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
I would return 0, or maybe -1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Thank you for explanation @zentol.
If we go with 1 minute rate, what do we do with the 5min and 15min rate in
the Dropwizard wrapper? Do we return zeros for non-supported rates or would you
sug
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
I've thought about the interface for a bit, and my conclusion is that a
Meter should only return a single rate with a relatively small time unit, like
a minute or maybe even less.
Here's why:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
@zentol What do you think about the proposed Meter interface? Should I
update my PR accordingly? Do you have other ideas?
---
If your project is set up for it, you can reply to this email and hav
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Hi @zentol I've updated the PR according to your suggestions.
About the Meter interface I think we can make it more flexible in two ways:
* Update Meter to support variable number of rat
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
I'm not suggesting that they may be useless; my point is that we should not
copy/use things without questioning whether they fit the bill. To that end I
simply asked questions that came to mind :)
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
@zentol Thank you for reviewing my PR! I'll fix these issues as soon as I
can.
On the metrics interface. Could you please elaborate why do you think
exponentially weighted rate and 15 minu
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
Good work! Only found a minor issue in regards to the TestingMeter class.
There is one thing I would like to start a discussion on however. Right now
the Meter interface is essentially a copy
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2374
Hi @zentol
Thank you for your prompt review.
Sorry, I was not aware that there is Metrics documentation. I'll update the
PR today.
---
If your project is set up for it, you can reply to t
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2374
I will look at this in more detail later today; but i couldn't find any
mistakes skimming over it. However, a small update to the Metrics documentation
would be neat (which i forgot to list on my to-d
14 matches
Mail list logo
