[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 @twalthr Thank you for accepting my changes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2169 Thanks for updating the PR. I reviewed the code again. There were still some issues regarding the documentation and also `expectedType` handling in `DataSetMinus`, I fixed them myself and will merge

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 @twalthr Updated PR according to your commits and rebased on top of the master branch to avoid merge conflicts. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 @twalthr Thank you for your review! I've update the PR according to your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2169 @mushketyk Thanks for the PR. I also reviewed the current status. I think it's good to compare your code with #2159 before you rework it. --- If your project is set up for it, you can reply to t

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 @fhueske Hey. Sorry for bothering you. Do I need to change something else in this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 @fhueske Thank you for the detailed review! I've updated my code according to your comments. I noticed that @wuchong is performing some type conversions in his INTERSECT implementation: h

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2169 Hi @mushketyk, thanks for the PR! I added a few comments inline. Best, Fabian @wuchong, thanks for reviewing! --- If your project is set up for it, you can reply to this email and have y

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 Updated documentation as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2169 Hi @mushketyk, I think we should remove duplicate records in CoGroup instead of using `distinct`. Others looks good to me. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 Renamed UnionITCase to SetOperationsITCase as suggested here: https://github.com/apache/flink/pull/2159 --- If your project is set up for it, you can reply to this email and have your reply appear