[GitHub] flink issue #2145: [FLINK-4087] [metrics] Improved JMX port handling

2016-06-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2145 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] flink issue #2145: [FLINK-4087] [metrics] Improved JMX port handling

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2145 Excellent @zentol :-) +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2145: [FLINK-4087] [metrics] Improved JMX port handling

2016-06-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2145 @tillrohrmann I've addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink issue #2145: [FLINK-4087] [metrics] Improved JMX port handling

2016-06-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2145 Good work @zentol. I mostly had general questions for my understanding. Before merging, I think it would be good to add a JMXReporter test which checks that we can start multiple JMXReporter on