[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-15 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2007 Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-15 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2007 Good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2007 I'm not sure; in any case it should not be removed as part of this PR. You can open a separate JIRA or ask on the mailing list. --- If your project is set up for it, you can reply to this ema

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-03 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2007 Now it should be ok, according to your suggestions. I misunderstood what @StephanEwen was trying to say, thanks @zentol for the clarification! Just another thing: the method GenericCsvInputF

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-01 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2007 then make parseField protected so users MUST call resetErrorStateAndParse. there, problem solved. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset

2016-06-01 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2007 I think that leaving the responsibility of calling resetErrorStateAndParse() to "consumers" of FieldParser is really a bad idea. Isn't safer to force its call using the strategy adopted in this