Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3089
@StephanEwen
Hi, I did check more than double time
This two part of code fully equals:
```java
Tuple2 record;
final Tuple2 recordReuse = new Tuple2<>();
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3106
@zentol I asked because you always check on null when you try writing to
Counter
or is it prevent uninitialized state?
---
If your project is set up for it, you can reply to this email and
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3106
@zentol
what do you think about remove
if (numBytesOut != null) {
and replace
numBytesOut = metrics.getNumBytesOutCounter();
with
+ if
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/2929
I think @mindprince mean: at now logger not defined in class file
this classes without
private static final Logger LOG
---
If your project is set up for it, you can reply to this
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3089
@aljoscha @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user xhumanoid opened a pull request:
https://github.com/apache/flink/pull/3089
remove duplicated tests
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3022
@aljoscha could you check and merge commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3022
The same javadoc issue apply for minBy ;)
I pointed maxBy only as example
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3022
After commit we have inconsistency between javadoc comment and arguments.
for both
_public SingleOutputStreamOperator maxBy(int positionToMaxBy)_
_public SingleOutputStreamOperator maxBy
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/2442
slave was killed without any notifications:
ERROR: Maven JVM terminated unexpectedly with exit code 137
Putting comment on the pull request
Finished: FAILURE
---
If your project
GitHub user xhumanoid opened a pull request:
https://github.com/apache/flink/pull/2442
[FLINK-4148] incorrect calculation minDist distance in QuadTree
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/1626
Hi, I know than issue closed, but he maybe have small bug
https://github.com/apache/flink/pull/1626/files#diff-4a133896fec62bcabc1120b0df8cb8daR205
in hashCode recursion on
12 matches
Mail list logo