Re: [PR] [FLINK-37239][docs] Add examples for unhex, btrim, translate, elt and percentile [flink]

2025-01-30 Thread via GitHub
gustavodemorais commented on code in PR #26091: URL: https://github.com/apache/flink/pull/26091#discussion_r1935623598 ## docs/data/sql_functions.yml: ## @@ -241,9 +241,9 @@ arithmetic: - sql: UNHEX(expr) table: expr.unhex() description: | - Converts hexadecima

Re: [PR] [FLINK-37239][docs] Add examples for unhex, btrim, translate, elt and percentile [flink]

2025-01-30 Thread via GitHub
flinkbot commented on PR #26091: URL: https://github.com/apache/flink/pull/26091#issuecomment-2624521308 ## CI report: * 3c08458ae0d1f748c97444e16e4fc34769823d64 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37239][docs] Add examples for unhex, btrim, translate, elt and percentile [flink]

2025-01-30 Thread via GitHub
gustavodemorais commented on code in PR #26091: URL: https://github.com/apache/flink/pull/26091#discussion_r1935601554 ## docs/data/sql_functions.yml: ## @@ -241,9 +241,9 @@ arithmetic: - sql: UNHEX(expr) table: expr.unhex() description: | - Converts hexadecima

Re: [PR] [FLINK-37239][docs] Add examples for unhex, btrim, translate, elt and percentile [flink]

2025-01-30 Thread via GitHub
gustavodemorais commented on code in PR #26091: URL: https://github.com/apache/flink/pull/26091#discussion_r1935601554 ## docs/data/sql_functions.yml: ## @@ -241,9 +241,9 @@ arithmetic: - sql: UNHEX(expr) table: expr.unhex() description: | - Converts hexadecima

Re: [PR] [FLINK-37239][docs] Add examples for unhex, btrim, translate, elt and percentile [flink]

2025-01-30 Thread via GitHub
snuyanzin commented on code in PR #26091: URL: https://github.com/apache/flink/pull/26091#discussion_r1935576588 ## docs/data/sql_functions.yml: ## @@ -241,9 +241,9 @@ arithmetic: - sql: UNHEX(expr) table: expr.unhex() description: | - Converts hexadecimal stri

[PR] [FLINK-37239][docs] Add examples for unhex, btrim, translate, elt and percentile [flink]

2025-01-30 Thread via GitHub
gustavodemorais opened a new pull request, #26091: URL: https://github.com/apache/flink/pull/26091 ## What is the purpose of the change We currently have no examples for some functions in the documentation. 5 examples of these are unhex, btrim, percentile, translate and ETL. These

Re: [PR] [FLINK-25521][docs] Fix the composition description of 'INTERVAL DAY TO SECOND' in the data type [flink]

2025-01-30 Thread via GitHub
davidradl commented on PR #18267: URL: https://github.com/apache/flink/pull/18267#issuecomment-2624407560 @ashulin are you able to make the requested changes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] FLINK-37154: Adding SimpleByteSchema for PyFlink [flink]

2025-01-30 Thread via GitHub
davidradl commented on PR #26080: URL: https://github.com/apache/flink/pull/26080#issuecomment-2624247899 Reviewed by Chi on 30/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Bump org.apache.hive:hive-exec from 2.3.10 to 4.0.1 in /flink-connectors/flink-sql-connector-hive-2.3.10 [flink]

2025-01-30 Thread via GitHub
davidradl commented on PR #26090: URL: https://github.com/apache/flink/pull/26090#issuecomment-2624254358 Reviewed by Chi on 30/01/2025 Dependabot change requires notice - raise a separate Jira and PR so the impact can be properly assessed The Hive connector is now in an external rep

Re: [PR] [FLINK-31275] extend lineage listener with QueryOperationEvent [flink]

2025-01-30 Thread via GitHub
davidradl commented on PR #26089: URL: https://github.com/apache/flink/pull/26089#issuecomment-2624250766 Reviewed by Chi on 30/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [hotfix][runtime] Remove the redundant JobVertex#hasNoConnectedInputs and use JobVertex#isInputVertex instead. [flink]

2025-01-30 Thread via GitHub
davidradl commented on PR #26083: URL: https://github.com/apache/flink/pull/26083#issuecomment-2624249127 Reviewed by Chi on 30/01/2025 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-36352][doc] Remove Scala DataStream API related doc [flink]

2025-01-30 Thread via GitHub
davidradl commented on PR #26082: URL: https://github.com/apache/flink/pull/26082#issuecomment-2624248354 Reviewed by Chi on 30/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-37237] Improve Kudu table creation based on Flink SQL `CREATE TABLE` [flink-connector-kudu]

2025-01-30 Thread via GitHub
ferenc-csaky merged PR #7: URL: https://github.com/apache/flink-connector-kudu/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[PR] [FLINK-37236] Flink 2.0 preview support [flink-kubernetes-operator]

2025-01-29 Thread via GitHub
gyfora opened a new pull request, #938: URL: https://github.com/apache/flink-kubernetes-operator/pull/938 ## What is the purpose of the change This PR adds support for the 2.0 preview release of Flink. As a necessary prerequisite it also includes a bumping of the operator Flink depend

Re: [PR] [FLINK-36945] MySQL CDC supports parsing RENAME TABLE Statement with multiple tables [flink-cdc]

2025-01-29 Thread via GitHub
yoheimuta commented on PR #3876: URL: https://github.com/apache/flink-cdc/pull/3876#issuecomment-2623409206 @leonardBang Two tests failed: - **[Unit Tests (MySQL) / compile_and_test (8, generic)](https://github.com/apache/flink-cdc/actions/runs/12902800573/job/3636684?pr=3876#logs

Re: [PR] [FLINK-36945] MySQL CDC supports parsing RENAME TABLE Statement with multiple tables [flink-cdc]

2025-01-29 Thread via GitHub
yoheimuta commented on PR #3876: URL: https://github.com/apache/flink-cdc/pull/3876#issuecomment-2623408027 Two tests failed: - **[Unit Tests (MySQL) / compile_and_test (8, generic)](https://github.com/apache/flink-cdc/actions/runs/12902800573/job/3636684?pr=3876#logs)** -

Re: [PR] Bump org.apache.hive:hive-exec from 2.3.10 to 4.0.1 in /flink-connectors/flink-sql-connector-hive-2.3.10 [flink]

2025-01-29 Thread via GitHub
flinkbot commented on PR #26090: URL: https://github.com/apache/flink/pull/26090#issuecomment-2622674511 ## CI report: * 73d5c097987f5c48642c5fc53f1a977f9506028b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Bump org.apache.hive:hive-exec from 2.3.10 to 4.0.1 in /flink-connectors/flink-sql-connector-hive-2.3.10 [flink]

2025-01-29 Thread via GitHub
dependabot[bot] opened a new pull request, #26090: URL: https://github.com/apache/flink/pull/26090 Bumps org.apache.hive:hive-exec from 2.3.10 to 4.0.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on the AdaptiveScheduler's side introduced by FLIP-272 [flink]

2025-01-29 Thread via GitHub
XComp commented on PR #26088: URL: https://github.com/apache/flink/pull/26088#issuecomment-2622168306 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-31275] extend lineage listener with QueryOperationEvent [flink]

2025-01-29 Thread via GitHub
davidradl commented on PR #26089: URL: https://github.com/apache/flink/pull/26089#issuecomment-2621952020 some comments: - it would be great to get this very useful capability into Flink. Thanks for the contribution - I see that the document pointed to, has some side effects - are the

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on the AdaptiveScheduler's side introduced by FLIP-272 [flink]

2025-01-29 Thread via GitHub
XComp commented on PR #26088: URL: https://github.com/apache/flink/pull/26088#issuecomment-2621944704 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2025-01-29 Thread via GitHub
reta commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2621941619 > However, I can't find the package in Maven, can someone share how shall I add the dependency to my app? It seems like 4.0 hasn't been released yet, please check h

Re: [PR] [FLINK-31275] extend lineage listener with QueryOperationEvent [flink]

2025-01-29 Thread via GitHub
davidradl commented on code in PR #26089: URL: https://github.com/apache/flink/pull/26089#discussion_r1934054446 ## docs/content/docs/deployment/advanced/job_status_listener.md: ## @@ -27,6 +27,7 @@ Flink provides a pluggable interface for users to register their custom logic f

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on the AdaptiveScheduler's side introduced by FLIP-272 [flink]

2025-01-29 Thread via GitHub
davidradl commented on PR #26088: URL: https://github.com/apache/flink/pull/26088#issuecomment-2621872046 @ztison looks like you bot command did not take- we still see yesterdays CI FAILURE -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-31275] extend lineage listener with QueryOperationEvent [flink]

2025-01-29 Thread via GitHub
flinkbot commented on PR #26089: URL: https://github.com/apache/flink/pull/26089#issuecomment-2621633963 ## CI report: * d9709d1110c74319aa45d10f3b7e444b190f2378 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-31275] extend lineage listener with QueryOperationEvent [flink]

2025-01-29 Thread via GitHub
pawel-big-lebowski opened a new pull request, #26089: URL: https://github.com/apache/flink/pull/26089 ## What is the purpose of the change This change should enable extracting column level lineage for Flink SQL jobs. This can be achieved by `JobStatusChangedListener` if Flink expo

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on the AdaptiveScheduler's side introduced by FLIP-272 [flink]

2025-01-29 Thread via GitHub
ztison commented on PR #26088: URL: https://github.com/apache/flink/pull/26088#issuecomment-2621559589 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Add Flink 1.20.1 release [flink-web]

2025-01-29 Thread via GitHub
afedulov opened a new pull request, #772: URL: https://github.com/apache/flink-web/pull/772 Release date will be pinned after the voting for the RC completes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add Flink 1.20.1 release [flink-web]

2025-01-29 Thread via GitHub
afedulov commented on PR #772: URL: https://github.com/apache/flink-web/pull/772#issuecomment-2621506885 TODO: add Netty 4 disclaimer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [hotfix] Fix the issue related to mounting the Logback configuration [flink]

2025-01-29 Thread via GitHub
Jam804 commented on PR #26039: URL: https://github.com/apache/flink/pull/26039#issuecomment-2621412938 PTAL, Please @XComp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add Flink 1.19.2 release [flink-web]

2025-01-29 Thread via GitHub
afedulov commented on PR #771: URL: https://github.com/apache/flink-web/pull/771#issuecomment-2621398571 TODO: add Netty 4 disclaimer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on the AdaptiveScheduler's side introduced by FLIP-272 [flink]

2025-01-29 Thread via GitHub
ztison commented on PR #26088: URL: https://github.com/apache/flink/pull/26088#issuecomment-2621178970 @XComp Thanks for review, I addressed the comments and updated the description. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on the AdaptiveScheduler's side introduced by FLIP-272 [flink]

2025-01-29 Thread via GitHub
XComp commented on code in PR #26088: URL: https://github.com/apache/flink/pull/26088#discussion_r1933581162 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Restarting.java: ## @@ -44,7 +46,7 @@ class Restarting extends StateWithExecutionGraph {

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933544744 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java: ## @@ -920,6 +941,15 @@ private Operatio

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933555465 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/DescribeModelOperation.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on t… [flink]

2025-01-29 Thread via GitHub
ztison commented on code in PR #26088: URL: https://github.com/apache/flink/pull/26088#discussion_r1932520744 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitions.java: ## @@ -128,17 +129,17 @@ interface ToRestarting extends StateTransition

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933535365 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java: ## @@ -324,6 +338,8 @@ private static Op

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933534769 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java: ## @@ -304,6 +315,9 @@ private static Op

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2025-01-29 Thread via GitHub
YegorMedvedev commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-2621108461 Amazing work! Thank you! However, I can't find the package in Maven, can someone share how shall I add the dependency to my app? -- This is an automated mes

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933526308 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -244,6 +262,233 @@ public void t

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933527308 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -244,6 +262,233 @@ public void t

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933526803 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -244,6 +262,233 @@ public void t

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on t… [flink]

2025-01-29 Thread via GitHub
ztison commented on code in PR #26088: URL: https://github.com/apache/flink/pull/26088#discussion_r1933525280 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Restarting.java: ## @@ -44,7 +46,7 @@ class Restarting extends StateWithExecutionGraph {

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-29 Thread via GitHub
snuyanzin commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1933523153 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -244,6 +262,233 @@ public void t

Re: [PR] [FLINK-37214][runtime] Refactors test to use proper Executor service for the main thread [flink]

2025-01-29 Thread via GitHub
XComp merged PR #26086: URL: https://github.com/apache/flink/pull/26086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on t… [flink]

2025-01-29 Thread via GitHub
XComp commented on code in PR #26088: URL: https://github.com/apache/flink/pull/26088#discussion_r1933392347 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitions.java: ## @@ -128,17 +129,17 @@ interface ToRestarting extends StateTransitions

Re: [PR] [FLINK-37200]Add e2e test for ElasticSearch Sink. [flink-cdc]

2025-01-28 Thread via GitHub
wangqinghuan commented on code in PR #3898: URL: https://github.com/apache/flink-cdc/pull/3898#discussion_r1933326941 ## flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MySqlToElasticsearchE2eITCase.java: ## @@ -0,0 +1,379 @@ +/

Re: [PR] [FLINK-37200]Add e2e test for ElasticSearch Sink. [flink-cdc]

2025-01-28 Thread via GitHub
yuxiqian commented on code in PR #3898: URL: https://github.com/apache/flink-cdc/pull/3898#discussion_r1933273475 ## flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/pom.xml: ## @@ -175,6 +189,12 @@ limitations under the License. ${testcontainers.version}

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-28 Thread via GitHub
davidradl commented on PR #26022: URL: https://github.com/apache/flink/pull/26022#issuecomment-2620225170 @twalthr thanks for your reply. I found this a bit misleading - is that all the examples could be coded with a nested json_object using a key. It would be good to document when this wou

Re: [PR] [hotfix] Enable @PublicEvolving japicmp checks [flink]

2025-01-28 Thread via GitHub
afedulov merged PR #26087: URL: https://github.com/apache/flink/pull/26087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on t… [flink]

2025-01-28 Thread via GitHub
ztison opened a new pull request, #26088: URL: https://github.com/apache/flink/pull/26088 …he AdaptiveScheduler's side introduced by FLIP-272 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather t

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on t… [flink]

2025-01-28 Thread via GitHub
flinkbot commented on PR #26088: URL: https://github.com/apache/flink/pull/26088#issuecomment-2619624517 ## CI report: * 1fd69a253535fe4aa005768f7742ddc0d834ddec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37232][runtime] Fix for broken synchronization assumption on t… [flink]

2025-01-28 Thread via GitHub
ztison commented on code in PR #26088: URL: https://github.com/apache/flink/pull/26088#discussion_r1932520744 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitions.java: ## @@ -128,17 +129,17 @@ interface ToRestarting extends StateTransition

Re: [PR] [FLINK-37212] When hbase region move, throw "Unable to load exception received from server: XXX" [flink-connector-hbase]

2025-01-28 Thread via GitHub
ferenc-csaky commented on code in PR #55: URL: https://github.com/apache/flink-connector-hbase/pull/55#discussion_r1932472328 ## flink-sql-connector-hbase-2.2/pom.xml: ## Review Comment: Can we extend the comment starting @ L142 with something like: > Some exception

Re: [PR] [FLINK-37212] When hbase region move, throw "Unable to load exception received from server: XXX" [flink-connector-hbase]

2025-01-28 Thread via GitHub
ferenc-csaky commented on code in PR #55: URL: https://github.com/apache/flink-connector-hbase/pull/55#discussion_r1932468530 ## flink-sql-connector-hbase-2.2/pom.xml: ## @@ -144,6 +144,8 @@ under the License.

[PR] update cdc overview [flink-cdc]

2025-01-28 Thread via GitHub
wangqinghuan opened a new pull request, #3899: URL: https://github.com/apache/flink-cdc/pull/3899 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Add Flink 1.19.2 release [flink-web]

2025-01-28 Thread via GitHub
afedulov opened a new pull request, #771: URL: https://github.com/apache/flink-web/pull/771 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] [hotfix] Enable @PublicEvolving japicmp checks [flink]

2025-01-28 Thread via GitHub
afedulov commented on PR #26087: URL: https://github.com/apache/flink/pull/26087#issuecomment-2619236653 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix] Enable @PublicEvolving japicmp checks [flink]

2025-01-28 Thread via GitHub
afedulov commented on PR #26087: URL: https://github.com/apache/flink/pull/26087#issuecomment-2618812801 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-28 Thread via GitHub
gustavodemorais commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1932025118 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2819,6 +2819,15 @@ ANY, and(logical(Log

Re: [PR] [FLINK-37205][python] Correct the state cache behavior during bump beam version [flink]

2025-01-28 Thread via GitHub
dianfu commented on PR #26058: URL: https://github.com/apache/flink/pull/26058#issuecomment-2618774065 @davidradl Thanks for the comments. It's very difficult to add unit test for this. Besides, it's an inner behavior of Beam and I don't think we should test for it. It should happen very ra

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-28 Thread via GitHub
gustavodemorais commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1931805263 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2819,6 +2819,15 @@ ANY, and(logical(Log

Re: [PR] [FLINK-37229] Add/record DELETING/DELETED lifecycle states [flink-kubernetes-operator]

2025-01-28 Thread via GitHub
gyfora merged PR #937: URL: https://github.com/apache/flink-kubernetes-operator/pull/937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [hotfix] Fix the issue related to mounting the Logback configuration [flink]

2025-01-28 Thread via GitHub
Jam804 commented on PR #26039: URL: https://github.com/apache/flink/pull/26039#issuecomment-2618589964 PTAL, Please @Zakelly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix] Fix the issue related to mounting the Logback configuration [flink]

2025-01-28 Thread via GitHub
Jam804 commented on PR #26039: URL: https://github.com/apache/flink/pull/26039#issuecomment-2618481207 PTAL,Please @XComp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-28 Thread via GitHub
gustavodemorais commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1931805263 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2819,6 +2819,15 @@ ANY, and(logical(Log

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-28 Thread via GitHub
twalthr commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1931694563 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2819,6 +2819,15 @@ ANY, and(logical(LogicalType

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-28 Thread via GitHub
twalthr commented on PR #26022: URL: https://github.com/apache/flink/pull/26022#issuecomment-2618168026 > why do we need a new function when we can already do this with json_object? Or am I missing something? @davidradl In many cases, JSON is generated by external systems and already

Re: [PR] [FLINK-37200]Add e2e test for ElasticSearch Sink. [flink-cdc]

2025-01-27 Thread via GitHub
wangqinghuan commented on PR #3898: URL: https://github.com/apache/flink-cdc/pull/3898#issuecomment-2618098157 There is another open pr(https://github.com/apache/flink-cdc/pull/3535) but it's not updated. So I created a new PR to i mplement e2e test for Elasticsearch Sink. Could you review

[PR] [FLINK-37200]Add e2e test for ElasticSearch Sink. [flink-cdc]

2025-01-27 Thread via GitHub
wangqinghuan opened a new pull request, #3898: URL: https://github.com/apache/flink-cdc/pull/3898 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [FLINK-37192] [pyflink] Replace deprecated avro-python3 with avro [flink]

2025-01-27 Thread via GitHub
dianfu commented on PR #26008: URL: https://github.com/apache/flink/pull/26008#issuecomment-2618040496 Will wait to see if @davidradl has other comments before merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [FLINK-37192] [pyflink] Replace deprecated avro-python3 with avro [flink]

2025-01-27 Thread via GitHub
dianfu commented on PR #26008: URL: https://github.com/apache/flink/pull/26008#issuecomment-2618037911 @mina-asham Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-19059]: Support non-time retract mode for OverAggregate operator [flink]

2025-01-27 Thread via GitHub
bvarghese1 commented on code in PR #25753: URL: https://github.com/apache/flink/pull/25753#discussion_r1931388443 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/NonTimeUnboundedPrecedingFunction.java: ## @@ -0,0 +1,482 @@ +/* + * L

Re: [PR] [FLINK-37159][runtime] Fix the test timeout by yielding Modifier thread [flink]

2025-01-27 Thread via GitHub
showuon commented on code in PR #26003: URL: https://github.com/apache/flink/pull/26003#discussion_r1931354609 ## flink-runtime/src/test/java/org/apache/flink/runtime/memory/MemoryManagerConcurrentModReleaseTest.java: ## @@ -97,6 +101,12 @@ public void run() { t

Re: [PR] Fix docker compose configuration [flink-playgrounds]

2025-01-27 Thread via GitHub
st3w4r commented on PR #47: URL: https://github.com/apache/flink-playgrounds/pull/47#issuecomment-2616688861 Thanks for the fix! I’ve tried it, and it’s working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-37230] Consolidate Table options [flink-connector-kudu]

2025-01-27 Thread via GitHub
ferenc-csaky merged PR #6: URL: https://github.com/apache/flink-connector-kudu/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [FLINK-23589][flink-avro] Support microsecond precision for timestamp [flink]

2025-01-27 Thread via GitHub
github-actions[bot] commented on PR #19537: URL: https://github.com/apache/flink/pull/19537#issuecomment-2616537324 This PR is being marked as stale since it has not had any activity in the last 180 days. If you would like to keep this PR alive, please leave a comment asking for a revie

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-27 Thread via GitHub
gustavodemorais commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1928817518 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2819,6 +2819,15 @@ ANY, and(logical(Log

Re: [PR] [FLINK-37220][connector-api] Deprecates RateLimiterStrategy#perSecond and introduces PerSecondRateLimiterStrategy to fix thread leakage and intro [flink]

2025-01-27 Thread via GitHub
XComp commented on PR #26084: URL: https://github.com/apache/flink/pull/26084#issuecomment-2616475204 Closing this one because my initial approach with just adding the shutdown logic doesn't work because we're running the code on the TaskManager. -- This is an automated message from the A

Re: [PR] [FLINK-37220][connector-api] Deprecates RateLimiterStrategy#perSecond and introduces PerSecondRateLimiterStrategy to fix thread leakage and intro [flink]

2025-01-27 Thread via GitHub
XComp closed pull request #26084: [FLINK-37220][connector-api] Deprecates RateLimiterStrategy#perSecond and introduces PerSecondRateLimiterStrategy to fix thread leakage and intro URL: https://github.com/apache/flink/pull/26084 -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-27 Thread via GitHub
gustavodemorais commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1930922052 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonFunction.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the

Re: [PR] [FLINK-37175][table] Support JSON built-in function for JSON_OBJECT [flink]

2025-01-27 Thread via GitHub
gustavodemorais commented on code in PR #26022: URL: https://github.com/apache/flink/pull/26022#discussion_r1930899164 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala: ## @@ -476,6 +485,11 @@ class ExprCodeGenerato

[PR] [FLINK-37230] Consolidate Table options [flink-connector-kudu]

2025-01-27 Thread via GitHub
ferenc-csaky opened a new pull request, #6: URL: https://github.com/apache/flink-connector-kudu/pull/6 Relevant changes: - removed `kudu` prefix from table option keys - added `sink` prefix for relevant table options - adapted tests I will handle the documentation in a differe

Re: [PR] [hotfix] Mark Column#rename internal [flink]

2025-01-27 Thread via GitHub
afedulov merged PR #26085: URL: https://github.com/apache/flink/pull/26085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-37220][connector-api] Deprecates RateLimiterStrategy#perSecond and introduces PerSecondRateLimiterStrategy to fix thread leakage and intro [flink]

2025-01-27 Thread via GitHub
XComp commented on PR #26084: URL: https://github.com/apache/flink/pull/26084#issuecomment-2616346713 > I suggest changing the [datagen documentation](https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/datagen/#rate-limiting) so it refers to the preferred rate l

Re: [PR] [hotfix] Enable @PublicEvolving japicmp checks [flink]

2025-01-27 Thread via GitHub
flinkbot commented on PR #26087: URL: https://github.com/apache/flink/pull/26087#issuecomment-2616319817 ## CI report: * 3df83b77b6d1579ee3dbcf2b5fc59eadeb74fa32 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37220][connector-api] Deprecates RateLimiterStrategy#perSecond and introduces PerSecondRateLimiterStrategy to fix thread leakage and intro [flink]

2025-01-27 Thread via GitHub
XComp commented on code in PR #26084: URL: https://github.com/apache/flink/pull/26084#discussion_r1930826627 ## flink-core/src/main/java/org/apache/flink/api/connector/source/util/ratelimit/RateLimiterStrategy.java: ## @@ -42,9 +43,14 @@ public interface RateLimiterStrategy exte

Re: [PR] [FLINK-36900][python] Migrate from conda to uv for managing Python environments for PyFlink [flink]

2025-01-27 Thread via GitHub
autophagy commented on PR #26065: URL: https://github.com/apache/flink/pull/26065#issuecomment-2616161221 @dawidwys I will take a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [FLINK-37214][runtime] Refactors test to use proper Executor service for the main thread [flink]

2025-01-27 Thread via GitHub
flinkbot commented on PR #26086: URL: https://github.com/apache/flink/pull/26086#issuecomment-2616049425 ## CI report: * 3485b71667f78324fb820a5f19f9a00e3d0452f6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] Fix the issue related to mounting the Logback configuration [flink]

2025-01-27 Thread via GitHub
Jam804 commented on PR #26039: URL: https://github.com/apache/flink/pull/26039#issuecomment-2615973030 PTAL, Please. @alpinegizmo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-36782] correct comment syntax in ResourceManager.java [flink]

2025-01-27 Thread via GitHub
alpinegizmo merged PR #26077: URL: https://github.com/apache/flink/pull/26077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[PR] [FLINK-37214][runtime] Refactors test to use proper Executor service for the main thread [flink]

2025-01-27 Thread via GitHub
XComp opened a new pull request, #26086: URL: https://github.com/apache/flink/pull/26086 ## What is the purpose of the change Refactors test to use proper Executor (rather than `directExecutor`). This allows for callbacks to be scheduled on the main thread in production code. #

Re: [PR] [FLINK-36488] [TABLE SQL/API] Remove deprecated methods StreamTableEnvironment.toAppendStream from flink-table-api-java-bridge module [flink]

2025-01-27 Thread via GitHub
sn-12-3 commented on PR #25528: URL: https://github.com/apache/flink/pull/25528#issuecomment-2615906024 @xuyangzhong , @davidradl , Gentle reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [hotfix][runtime] Remove the redundant JobVertex#hasNoConnectedInputs and use JobVertex#isInputVertex instead. [flink]

2025-01-27 Thread via GitHub
RocMarshal commented on PR #26083: URL: https://github.com/apache/flink/pull/26083#issuecomment-2615838674 hi, @AHeise ,Could you help take a look if you had the free time ? Thank a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [hotfix] Mark Column#rename internal [flink]

2025-01-27 Thread via GitHub
flinkbot commented on PR #26085: URL: https://github.com/apache/flink/pull/26085#issuecomment-2615719996 ## CI report: * baa83ba077e59a13a4c7b51cdc6786d72bba05c4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] FLINK-37154: Adding SimpleByteSchema for PyFlink [flink]

2025-01-27 Thread via GitHub
davidradl commented on PR #26080: URL: https://github.com/apache/flink/pull/26080#issuecomment-2615673968 From the discussion in the Jira it seems like this change was for Python datastream. I think introducing a Python raw format to Python would be more consistent with the way Java impleme

[PR] [hotfix] Mark Column#rename internal [flink]

2025-01-27 Thread via GitHub
dawidwys opened a new pull request, #26085: URL: https://github.com/apache/flink/pull/26085 Since I can not reproduce the original problem. Do you mind checking if this makes the trick @afedulov ? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [FLINK-29571] Support Map ConfigOptions [flink]

2025-01-27 Thread via GitHub
mxm commented on PR #21008: URL: https://github.com/apache/flink/pull/21008#issuecomment-2615632983 Closing because there doesn't seem to be an appetite for this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-29571] Support Map ConfigOptions [flink]

2025-01-27 Thread via GitHub
mxm closed pull request #21008: [FLINK-29571] Support Map ConfigOptions URL: https://github.com/apache/flink/pull/21008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [FLINK-37220][connector-api] Deprecates RateLimiterStrategy#perSecond and introduces PerSecondRateLimiterStrategy to fix thread leakage and intro [flink]

2025-01-27 Thread via GitHub
davidradl commented on code in PR #26084: URL: https://github.com/apache/flink/pull/26084#discussion_r1930448042 ## flink-core/src/main/java/org/apache/flink/api/connector/source/util/ratelimit/RateLimiterStrategy.java: ## @@ -42,9 +43,14 @@ public interface RateLimiterStrategy

  1   2   3   4   5   6   7   8   9   10   >