Re: [PR] [FLINK-34094] Adds documentation for AsyncScalarFunction [flink]

2025-06-10 Thread via GitHub
lihaosky commented on code in PR #26610: URL: https://github.com/apache/flink/pull/26610#discussion_r2138839903 ## docs/content/docs/dev/table/functions/udfs.md: ## @@ -1017,6 +1018,139 @@ If you intend to implement or call functions in Python, please refer to the [Pyt {{< t

Re: [PR] [FLINK-37865] Adds documentation for AsyncTableFunction [flink]

2025-06-10 Thread via GitHub
lihaosky commented on code in PR #26611: URL: https://github.com/apache/flink/pull/26611#discussion_r2138834735 ## docs/content/docs/dev/table/functions/udfs.md: ## @@ -1172,6 +1173,153 @@ If you intend to implement or call functions in Python, please refer to the [Pyt {{< t

Re: [PR] [FLINK-37795] rewrite ml_evaluate to ml_predict and aggregate function [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26667: URL: https://github.com/apache/flink/pull/26667#issuecomment-2960666813 ## CI report: * b0cc11331bc6fa92542458416e10d7a66ef2a4f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37795] rewrite ml_evaluate to ml_predict and aggregate function [flink]

2025-06-10 Thread via GitHub
lihaosky opened a new pull request, #26667: URL: https://github.com/apache/flink/pull/26667 ## What is the purpose of the change Rewrite `ml_evaluate` table function scan to `ml_predict` table function scan and `LogicalAggreate` ## Brief change log Rewrite `ml_evalua

[PR] [hotfix] Remove isUnalignedCheckpointsInterruptibleTimersEnabled config [flink]

2025-06-10 Thread via GitHub
nateab opened a new pull request, #2: URL: https://github.com/apache/flink/pull/2 Seems to be a copy paste typo, this PR correctly specifies the appropriate config flag `isUnalignedCheckpointsSplittableTimersEnabled` ## What is the purpose of the change *(For ex

Re: [PR] [hotfix] Remove isUnalignedCheckpointsInterruptibleTimersEnabled config [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #2: URL: https://github.com/apache/flink/pull/2#issuecomment-2960567173 ## CI report: * fed87f6f1bf4b59025a802fba7bed96c65195f3d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37933][table] Move TransformationScan/SinkProvider out of planner [flink]

2025-06-10 Thread via GitHub
AHeise commented on PR #26656: URL: https://github.com/apache/flink/pull/26656#issuecomment-2960565318 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [hotfix] Fix typo in StreamingJobGraphGenerator config [flink]

2025-06-10 Thread via GitHub
nateab commented on PR #26609: URL: https://github.com/apache/flink/pull/26609#issuecomment-2960558345 closing in favor of #2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [hotfix] Fix typo in StreamingJobGraphGenerator config [flink]

2025-06-10 Thread via GitHub
nateab closed pull request #26609: [hotfix] Fix typo in StreamingJobGraphGenerator config URL: https://github.com/apache/flink/pull/26609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [hotfix] Use correct `FlinkVersion.v2_1` [flink]

2025-06-10 Thread via GitHub
snuyanzin merged PR #26661: URL: https://github.com/apache/flink/pull/26661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] Bump org.apache.kafka:kafka-clients from 3.4.0 to 3.7.1 [flink-connector-kafka]

2025-06-10 Thread via GitHub
dependabot[bot] commented on PR #135: URL: https://github.com/apache/flink-connector-kafka/pull/135#issuecomment-2960544541 Superseded by #179. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Bump org.apache.kafka:kafka-clients from 3.9.0 to 3.9.1 [flink-connector-kafka]

2025-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #179: URL: https://github.com/apache/flink-connector-kafka/pull/179 Bumps org.apache.kafka:kafka-clients from 3.9.0 to 3.9.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency

Re: [PR] Bump org.apache.kafka:kafka-clients from 3.4.0 to 3.7.1 [flink-connector-kafka]

2025-06-10 Thread via GitHub
dependabot[bot] closed pull request #135: Bump org.apache.kafka:kafka-clients from 3.4.0 to 3.7.1 URL: https://github.com/apache/flink-connector-kafka/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.apache.kafka:kafka-clients from 2.2.2 to 3.9.1 in /flink-end-to-end-tests/flink-sql-client-test [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26665: URL: https://github.com/apache/flink/pull/26665#issuecomment-2960543255 ## CI report: * 74d2cb626e8043d6e69cd71b592c3b586e0b8d6e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Bump org.apache.kafka:kafka-clients from 2.2.2 to 3.9.1 in /flink-end-to-end-tests/flink-sql-client-test [flink]

2025-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #26665: URL: https://github.com/apache/flink/pull/26665 Bumps org.apache.kafka:kafka-clients from 2.2.2 to 3.9.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.ap

Re: [PR] [FLINK-37916][table] Add StreamPhysicalMultiJoin [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26664: URL: https://github.com/apache/flink/pull/26664#issuecomment-2960481999 ## CI report: * 30b1fc46bb01a58233952a61e6792c7606d20a80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37916][table] Add StreamPhysicalMultiJoin [flink]

2025-06-10 Thread via GitHub
gustavodemorais opened a new pull request, #26664: URL: https://github.com/apache/flink/pull/26664 ## What is the purpose of the change Adds StreamPhysicalMultiJoin that creates a StreamExecMultiJoin ## Brief change log - Adds StreamPhysicalMultiJoin implementin

Re: [PR] [FLINK-37701][flink-runtime] Fix AdaptiveScheduler ignoring checkpoint states sizes for local recovery adjustment. [flink]

2025-06-10 Thread via GitHub
rkhachatryan commented on code in PR #26663: URL: https://github.com/apache/flink/pull/26663#discussion_r2138673797 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -196,14 +196,16 @@ public Collection cal

[PR] [FLINK-37548] Add Model DDL methods in TABLE API [flink]

2025-06-10 Thread via GitHub
yanand0909 opened a new pull request, #26385: URL: https://github.com/apache/flink/pull/26385 ## What is the purpose of the change Adding model DDL support to the Table API, enabling a seamless development experience where users can define, manage, and utilize ML models entire

Re: [PR] [FLINK-37548] Add Model DDL methods in TABLE API [flink]

2025-06-10 Thread via GitHub
yanand0909 closed pull request #26385: [FLINK-37548] Add Model DDL methods in TABLE API URL: https://github.com/apache/flink/pull/26385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-37933][table] Move TransformationScan/SinkProvider out of planner [flink]

2025-06-10 Thread via GitHub
AHeise commented on PR #26656: URL: https://github.com/apache/flink/pull/26656#issuecomment-2960259462 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-37903][table] Support to use runtime config in ML_PREDICT [flink]

2025-06-10 Thread via GitHub
lihaosky commented on code in PR #26654: URL: https://github.com/apache/flink/pull/26654#discussion_r2138377376 ## docs/layouts/shortcodes/generated/ml_predict_runtime_config_configuration.html: ## @@ -0,0 +1,36 @@ + + + +Key +Default +

Re: [PR] [FLINK-37701][flink-runtime] Fix AdaptiveScheduler ignoring checkpoint states sizes for local recovery adjustment. [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26663: URL: https://github.com/apache/flink/pull/26663#issuecomment-2960245608 ## CI report: * bfc9dfa45a563a4b89d4e3f129fe27dc06a84e54 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37701][flink-runtime] Fix AdaptiveScheduler ignoring checkpoint states sizes for local recovery adjustment. [flink]

2025-06-10 Thread via GitHub
Izeren opened a new pull request, #26663: URL: https://github.com/apache/flink/pull/26663 ## What is the purpose of the change Address local recovery issues when Adaptive scheduler is enabled. 1. Pass latest completed checkpoint in addition to execution graph to `StateSizeEstimate

Re: [PR] [FLINK-33045] Make it possible to disable auto-registering schema in Schema Registry [flink]

2025-06-10 Thread via GitHub
MartijnVisser commented on PR #26662: URL: https://github.com/apache/flink/pull/26662#issuecomment-2960178773 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-33045] Make it possible to disable auto-registering schema in Schema Registry [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26662: URL: https://github.com/apache/flink/pull/26662#issuecomment-2960006630 ## CI report: * 64101b15b9806691220cec07de4da5a047aaf115 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33045] Make it possible to disable auto-registering schema in Schema Registry [flink]

2025-06-10 Thread via GitHub
MartijnVisser opened a new pull request, #26662: URL: https://github.com/apache/flink/pull/26662 ## What is the purpose of the change This PR is based on https://github.com/apache/flink/pull/25410 and aims to complete the necessary tasks. It introduces `auto.register.schemas` as a tab

Re: [PR] [hotfix] Use correct `FlinkVersion.v2_1` [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26661: URL: https://github.com/apache/flink/pull/26661#issuecomment-2959965261 ## CI report: * 8527afcf52ac39ac39c9705648a80c56c4c89cec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] Use correct `FlinkVersion.v2_1` [flink]

2025-06-10 Thread via GitHub
gustavodemorais commented on PR #26661: URL: https://github.com/apache/flink/pull/26661#issuecomment-2959958177 Thanks for the fix, @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [hotfix] Use correct `FlinkVersion.v2_1` [flink]

2025-06-10 Thread via GitHub
snuyanzin opened a new pull request, #26661: URL: https://github.com/apache/flink/pull/26661 ## What is the purpose of the change The PR is to fix the build after ## Verifying this change existing tests ## Does this pull request potentially affect one of t

Re: [PR] [FLINK-37724] Adds AsyncTableFunction as a fully supported UDF type [flink]

2025-06-10 Thread via GitHub
AlanConfluent commented on code in PR #26567: URL: https://github.com/apache/flink/pull/26567#discussion_r2138342849 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/AsyncUtil.java: ## @@ -47,7 +48,14 @@ public class AsyncUtil { *

Re: [PR] [FLIP-516][FLINK-37910][table] Add StreamExecMultiJoin [flink]

2025-06-10 Thread via GitHub
twalthr merged PR #26647: URL: https://github.com/apache/flink/pull/26647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-36546] Handle batch sources in DataSinkTranslator [flink-cdc]

2025-06-10 Thread via GitHub
morozov commented on PR #3646: URL: https://github.com/apache/flink-cdc/pull/3646#issuecomment-2959878359 @lvyanquan could you take a look at my previous comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-37935][table] Allow to read WindowingStrategy by downstream projects [flink]

2025-06-10 Thread via GitHub
snuyanzin merged PR #26657: URL: https://github.com/apache/flink/pull/26657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-37669][HELM] Add Helm chart unit tests to flink kubernetes operator [flink-kubernetes-operator]

2025-06-10 Thread via GitHub
gyfora commented on PR #971: URL: https://github.com/apache/flink-kubernetes-operator/pull/971#issuecomment-2959224429 I have merged the other PR, lets rebase this one :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [FLINK-35051][checkpoint] Treat handling of unaligned checkpoint barrier as the high priority mail [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26660: URL: https://github.com/apache/flink/pull/26660#issuecomment-2959442219 ## CI report: * aeafcc10f0f2dfd484642ac69ac80150edee6840 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] split number is not calculated correctly in CassandraSource [flink-connector-cassandra]

2025-06-10 Thread via GitHub
echauchot merged PR #24: URL: https://github.com/apache/flink-connector-cassandra/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[PR] [FLINK-35051][checkpoint] Treat handling of unaligned checkpoint barrier as the high priority mail [flink]

2025-06-10 Thread via GitHub
1996fanrui opened a new pull request, #26660: URL: https://github.com/apache/flink/pull/26660 ## What is the purpose of the change [FLINK-35051][checkpoint] Treat handling of unaligned checkpoint barrier as the high priority mail ## Brief change log [FLINK-35051][checkpo

[PR] [improvement] adding runtime converter array [flink-cdc]

2025-06-10 Thread via GitHub
iundarigun opened a new pull request, #4042: URL: https://github.com/apache/flink-cdc/pull/4042 ## Description In the [documentation](https://nightlies.apache.org/flink/flink-cdc-docs-release-3.1/docs/connectors/flink-sources/postgres-cdc/#data-type-mapping) doesn't mention a way to map

Re: [PR] [FLINK-37911][Helm] Reorganize Helm chart templates [flink-kubernetes-operator]

2025-06-10 Thread via GitHub
gyfora merged PR #985: URL: https://github.com/apache/flink-kubernetes-operator/pull/985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [python][plan][api] Init Event, Action, Function and WorkflowPlan. [flink-agents]

2025-06-10 Thread via GitHub
codenohup commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2137805325 ## python/flink_agents/api/event.py: ## @@ -0,0 +1,59 @@ + +# Licensed to the Apache S

Re: [PR] [FLINK-37920][table] Reuse same util for AsyncCalc, AsyncLookupJoin a… [flink]

2025-06-10 Thread via GitHub
fsk119 merged PR #26653: URL: https://github.com/apache/flink/pull/26653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-37920][table] Reuse same util for AsyncCalc, AsyncLookupJoin a… [flink]

2025-06-10 Thread via GitHub
fsk119 commented on PR #26653: URL: https://github.com/apache/flink/pull/26653#issuecomment-2959001561 All tests pass in my private CI: https://dev.azure.com/1059623455/Flink/_build/results?buildId=695&view=results -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [python][plan][api] Init Event, Action, Function and WorkflowPlan. [flink-agents]

2025-06-10 Thread via GitHub
codenohup commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2137739928 ## python/flink_agents/plan/workflow_plan.py: ## @@ -0,0 +1,51 @@ + +# Licensed to the

Re: [PR] [python][plan][api] Init Event, Action, Function and WorkflowPlan. [flink-agents]

2025-06-10 Thread via GitHub
codenohup commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2137740268 ## python/flink_agents/plan/workflow_plan.py: ## @@ -0,0 +1,51 @@ + +# Licensed to the

Re: [PR] [FLIP-516][FLINK-37910][table] Add StreamExecMultiJoin [flink]

2025-06-10 Thread via GitHub
gustavodemorais commented on code in PR #26647: URL: https://github.com/apache/flink/pull/26647#discussion_r2137720465 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecMultiJoin.java: ## @@ -39,7 +39,7 @@ import or

Re: [PR] [FLIP-516][FLINK-37910][table] Add StreamExecMultiJoin [flink]

2025-06-10 Thread via GitHub
gustavodemorais commented on PR #26647: URL: https://github.com/apache/flink/pull/26647#issuecomment-2958951446 > Thanks for the update. I added some last feedback from my side. Should be good in the next iteration. Thanks for the review, @twalthr. Comments have been addressed 🙂 --

Re: [PR] [FLINK-35670][cdc-connector][postgres]Flink cdc pipeline support postgres source [flink-cdc]

2025-06-10 Thread via GitHub
Mrart commented on PR #3968: URL: https://github.com/apache/flink-cdc/pull/3968#issuecomment-2958932494 This version does not support the following: ` @Experimental public static final ConfigOption METADATA_LIST = ConfigOptions.key("metadata.list")

Re: [PR] [FLINK-37928][table] Forbid cdc-stream for ML_PREDICT [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26659: URL: https://github.com/apache/flink/pull/26659#issuecomment-2958890818 ## CI report: * 81bb5bd0645785ae0665782ce433edda1351ce13 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37928][table] Forbid cdc-stream for ML_PREDICT [flink]

2025-06-10 Thread via GitHub
fsk119 opened a new pull request, #26659: URL: https://github.com/apache/flink/pull/26659 ## What is the purpose of the change *Forbid cdc-stream for ML_PREDICT* ## Brief change log - *Change the modify kind trait inference logic and throw exception if inpu

Re: [PR] [FLINK-37595][table] Add Join Remove Rules [flink]

2025-06-10 Thread via GitHub
liuyongvs commented on PR #25932: URL: https://github.com/apache/flink/pull/25932#issuecomment-2958843978 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37899][table] Use only `producedBeforeRestore` in `CorrelateTestPrograms#CORRELATE_WITH_LITERAL_AGG` [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26658: URL: https://github.com/apache/flink/pull/26658#issuecomment-2958845554 ## CI report: * a2e2a01176fa526739ceae74d968a4107883e495 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37899][table] Use only `producedBeforeRestore` in `CorrelateTestPrograms#CORRELATE_WITH_LITERAL_AGG` [flink]

2025-06-10 Thread via GitHub
snuyanzin commented on code in PR #26658: URL: https://github.com/apache/flink/pull/26658#discussion_r2137654051 ## flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-correlate_1/correlate-with-literal-agg/plan/correlate-with-literal-agg.json: ## @@ -1,

Re: [PR] [FLINK-37899][table] Use only `producedBeforeRestore` in `CorrelateTestPrograms#CORRELATE_WITH_LITERAL_AGG` [flink]

2025-06-10 Thread via GitHub
snuyanzin commented on code in PR #26658: URL: https://github.com/apache/flink/pull/26658#discussion_r2137654051 ## flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-correlate_1/correlate-with-literal-agg/plan/correlate-with-literal-agg.json: ## @@ -1,

[PR] [FLINK-37899][table] Use only `producedBeforeRestore` in `CorrelateTestPrograms#CORRELATE_WITH_LITERAL_AGG` [flink]

2025-06-10 Thread via GitHub
snuyanzin opened a new pull request, #26658: URL: https://github.com/apache/flink/pull/26658 …stPrograms#CORRELATE_WITH_LITERAL_AGG` ## What is the purpose of the change The PR is to use `producedBeforeRestore` in `CorrelateTestPrograms#CORRELATE_WITH_LITERAL_AGG` si

Re: [PR] [FLINK-37294][state] Support state migration between disabling and enabling ttl in HeapKeyedStateBackend [flink]

2025-06-10 Thread via GitHub
davidradl commented on code in PR #26651: URL: https://github.com/apache/flink/pull/26651#discussion_r2137621298 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java: ## @@ -299,6 +292,56 @@ private StateTable tryRegisterStateTable(

Re: [PR] [FLINK-37294][state] Support state migration between disabling and enabling ttl in HeapKeyedStateBackend [flink]

2025-06-10 Thread via GitHub
davidradl commented on code in PR #26651: URL: https://github.com/apache/flink/pull/26651#discussion_r2137619890 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java: ## @@ -259,17 +261,8 @@ private StateTable tryRegisterStateTable(

Re: [PR] [FLINK-37294][state] Support state migration between disabling and enabling ttl in HeapKeyedStateBackend [flink]

2025-06-10 Thread via GitHub
davidradl commented on code in PR #26651: URL: https://github.com/apache/flink/pull/26651#discussion_r2137625070 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapListState.java: ## @@ -142,6 +145,34 @@ public byte[] getSerializedValue( return baos.

Re: [PR] [FLINK-37896][table-planner] Introduce a new trait derived from sink to source to check whether the downstream operators can accept duplicate data [flink]

2025-06-10 Thread via GitHub
lincoln-lil commented on code in PR #26648: URL: https://github.com/apache/flink/pull/26648#discussion_r2137376644 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala: ## @@ -69,6 +69,9 @@ class

Re: [PR] [python][plan][api] Init Event, Action, Function and WorkflowPlan. [flink-agents]

2025-06-10 Thread via GitHub
HuangXingBo commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2137370961 ## python/requirements/build_requirements.txt: ## @@ -13,3 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the L

Re: [PR] [FLINK-37294][state] Support state migration between disabling and enabling ttl in HeapKeyedStateBackend [flink]

2025-06-10 Thread via GitHub
davidradl commented on code in PR #26651: URL: https://github.com/apache/flink/pull/26651#discussion_r2137617241 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java: ## @@ -212,7 +214,7 @@ private StateTable tryRegisterStateTable(

Re: [PR] [FLINK-37294][state] Support state migration between disabling and enabling ttl in HeapKeyedStateBackend [flink]

2025-06-10 Thread via GitHub
davidradl commented on code in PR #26651: URL: https://github.com/apache/flink/pull/26651#discussion_r2137615225 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapState.java: ## @@ -112,6 +115,29 @@ public byte[] getSerializedValue( return K

Re: [PR] [FLINK-37513] CassandraSource CQL_PROHIBITED_CLAUSES_REGEXP fix [flink-connector-cassandra]

2025-06-10 Thread via GitHub
echauchot commented on code in PR #33: URL: https://github.com/apache/flink-connector-cassandra/pull/33#discussion_r2137609420 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/reader/CassandraQueryTest.java: ## @@ -39,7 +39,8 @@ public void

[PR] [FLINK-37934][cdc-source-connectors] Get the case-sensitive variable names and method names of table id are not standardized, and need to be adjusted [flink-cdc]

2025-06-10 Thread via GitHub
linjianchang opened a new pull request, #4041: URL: https://github.com/apache/flink-cdc/pull/4041 [FLINK-37934][cdc-source-connectors] Get the case-sensitive variable names and method names of table id are not standardized, and need to be adjusted -- This is an automated message from the

Re: [PR] [FLIP-516][FLINK-37910][table] Add StreamExecMultiJoin [flink]

2025-06-10 Thread via GitHub
twalthr commented on code in PR #26647: URL: https://github.com/apache/flink/pull/26647#discussion_r2137507998 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecMultiJoin.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed t

Re: [PR] [FLINK-37513] CassandraSource CQL_PROHIBITED_CLAUSES_REGEXP fix [flink-connector-cassandra]

2025-06-10 Thread via GitHub
echauchot commented on PR #33: URL: https://github.com/apache/flink-connector-cassandra/pull/33#issuecomment-2958610829 Thanks @maciejbak85 for this fix. Reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-36876] Add proxy for restClient [flink-kubernetes-operator]

2025-06-10 Thread via GitHub
chenyuzhi459 commented on PR #956: URL: https://github.com/apache/flink-kubernetes-operator/pull/956#issuecomment-2958555002 I have changed the default value of new param `flink.client.io.threads` to 10. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [FLINK-37935][table] Allow to read WindowingStrategy by downstream projects [flink]

2025-06-10 Thread via GitHub
snuyanzin commented on code in PR #26657: URL: https://github.com/apache/flink/pull/26657#discussion_r2137517172 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/common/CommonPhysicalWindowTableFunction.scala: ## @@ -67,4 +67,8 @@ abstr

Re: [PR] [FLINK-37935][table] Allow to read WindowingStrategy by downstream projects [flink]

2025-06-10 Thread via GitHub
davidradl commented on code in PR #26657: URL: https://github.com/apache/flink/pull/26657#discussion_r2137507579 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/common/CommonPhysicalWindowTableFunction.scala: ## @@ -67,4 +67,8 @@ abstr

Re: [PR] [FLINK-37923][sql] Introduce VARIANT type and PARSE_JSON to Flink SQL [flink]

2025-06-10 Thread via GitHub
twalthr commented on code in PR #26655: URL: https://github.com/apache/flink/pull/26655#discussion_r2137336904 ## flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariant.java: ## @@ -0,0 +1,490 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [FLINK-37935][table] Allow to read WindowingStrategy by downstream projects [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26657: URL: https://github.com/apache/flink/pull/26657#issuecomment-2958546232 ## CI report: * 0d5e5dff4070ad16757dea232000a9df3d10e6d3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37935][table] Allow to read WindowingStrategy by downstream projects [flink]

2025-06-10 Thread via GitHub
snuyanzin opened a new pull request, #26657: URL: https://github.com/apache/flink/pull/26657 ## What is the purpose of the change it allows to read `WindowingStrategy` by downstream projects from `CommonPhysicalWindowTableFunction` ## Verifying this change T

Re: [PR] [FLINK-37933] Move TransformationScan/SinkProvider out of planner [flink]

2025-06-10 Thread via GitHub
flinkbot commented on PR #26656: URL: https://github.com/apache/flink/pull/26656#issuecomment-2958424064 ## CI report: * 974a1d4133d9331cadc7cc47052b87b3371a38d5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37933] Move TransformationScan/SinkProvider out of planner [flink]

2025-06-10 Thread via GitHub
AHeise opened a new pull request, #26656: URL: https://github.com/apache/flink/pull/26656 ## What is the purpose of the change Although TransformationScan/SinkProvider is an expert API, it's buried inside planner and not easily usable. Move up to table-common to make i

Re: [PR] [FLINK-37920][table] Reuse same util for AsyncCalc, AsyncLookupJoin a… [flink]

2025-06-10 Thread via GitHub
fsk119 commented on PR #26653: URL: https://github.com/apache/flink/pull/26653#issuecomment-2958357039 The current implementation has some room for improvement, and further cleanup will be addressed in subsequent PRs. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137334440 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogPropertiesUtilTest.java: ## @@ -111,7 +111,8 @@ public void testCatalogTableSerde

Re: [PR] [FLINK-37901][table] Support to serde for StreamExecMLPredictTableFunction [flink]

2025-06-10 Thread via GitHub
fsk119 commented on PR #26641: URL: https://github.com/apache/flink/pull/26641#issuecomment-2958261132 All tests passes in my private CI pipeline: https://dev.azure.com/1059623455/Flink/_build/results?buildId=694&view=logs&j=0e31ee24-31a6-528c-a4bf-45cde9b2a14e Merging... -- This i

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137331214 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ResolvedCatalogTableSerdeTest.java: ## @@ -93,7 +93,8 @@ class Re

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
xuyangzhong commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2136986005 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1881,7 +1881,8 @@ public ResolvedCatalogView resolveCat

Re: [PR] [FLINK-37901][table] Support to serde for StreamExecMLPredictTableFunction [flink]

2025-06-10 Thread via GitHub
fsk119 merged PR #26641: URL: https://github.com/apache/flink/pull/26641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-37900][rocksdb] configurable jitter in rocksdb state uploader [flink]

2025-06-10 Thread via GitHub
mxm commented on code in PR #26640: URL: https://github.com/apache/flink/pull/26640#discussion_r2137165179 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java: ## @@ -180,6 +188,14 @@ private HandleAndLocalPat

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137082099 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Index.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-35670][cdc-connector][postgres]Flink cdc pipeline support postgres source [flink-cdc]

2025-06-10 Thread via GitHub
Mrart commented on code in PR #3968: URL: https://github.com/apache/flink-cdc/pull/3968#discussion_r2137213628 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDataSourceOptions

Re: [PR] [FLIP-516][FLINK-37910][table] Add StreamExecMultiJoin [flink]

2025-06-10 Thread via GitHub
gustavodemorais commented on code in PR #26647: URL: https://github.com/apache/flink/pull/26647#discussion_r2135285367 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ExecNodeMultiJoinJsonSerdeTest.java: ## @@ -0,0 +1,181 @@

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137103530 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java: ## @@ -126,7 +127,8 @@ public static ResolvedSchema removeTimeAttr

Re: [PR] [FLINK-37876][table] Introduce async execution controller for key ordered in table runtime [flink]

2025-06-10 Thread via GitHub
xishuaidelin commented on code in PR #26617: URL: https://github.com/apache/flink/pull/26617#discussion_r2135584738 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/lookup/keyordered/Epoch.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed

Re: [PR] [FLINK-37862][table] Support inline structured types in SQL [flink]

2025-06-10 Thread via GitHub
twalthr merged PR #26638: URL: https://github.com/apache/flink/pull/26638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[PR] [python][plan][api] Init Event, Action, Function and WorkflowPlan. [flink-agents]

2025-06-10 Thread via GitHub
wenjin272 opened a new pull request, #6: URL: https://github.com/apache/flink-agents/pull/6 This pr import the core concepts Event and Action to Flink-Agents, and import Function which is the dependency of Action. Based on these concepts, we import WorkflowPlan, and add a simplest test case

Re: [PR] [FLINK-37548] Add Model DDL methods in TABLE API [flink]

2025-06-10 Thread via GitHub
yanand0909 commented on PR #26385: URL: https://github.com/apache/flink/pull/26385#issuecomment-2958116097 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLIP-516][FLINK-37910][table] Add StreamExecMultiJoin [flink]

2025-06-10 Thread via GitHub
gustavodemorais commented on PR #26647: URL: https://github.com/apache/flink/pull/26647#issuecomment-2958050761 I've addressed your feedback, @snuyanzin. Please take a look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [FLINK-35670][cdc-connector][postgres]Flink cdc pipeline support postgres source [flink-cdc]

2025-06-10 Thread via GitHub
Mrart commented on code in PR #3968: URL: https://github.com/apache/flink-cdc/pull/3968#discussion_r2137213628 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDataSourceOptions

Re: [PR] [FLINK-37595][table] Add Join Remove Rules [flink]

2025-06-10 Thread via GitHub
liuyongvs commented on code in PR #25932: URL: https://github.com/apache/flink/pull/25932#discussion_r2137156123 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/join/WindowJoinTest.xml: ## @@ -199,35 +199,19 @@ LogicalSink(ta

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137089118 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/Schema.java: ## @@ -1043,4 +1126,53 @@ public int hashCode() { return Objects.h

Re: [PR] Improves the usability of lint/ut scripts [flink-agents]

2025-06-10 Thread via GitHub
HuangXingBo merged PR #5: URL: https://github.com/apache/flink-agents/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137108152 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ResolvedCatalogTableSerdeTest.java: ## @@ -93,7 +93,8 @@ class Re

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137101717 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/TableSchemaUtilsTest.java: ## @@ -101,7 +101,8 @@ void testRemoveTimeAttribute() {

Re: [PR] [FLINK-35670][cdc-connector][postgres]Flink cdc pipeline support postgres source [flink-cdc]

2025-06-10 Thread via GitHub
lvyanquan commented on code in PR #3968: URL: https://github.com/apache/flink-cdc/pull/3968#discussion_r2136976198 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDataSourceOpt

Re: [PR] FLINK-37891: Remove SQL Server CDC documentation for initial-only [flink-cdc]

2025-06-10 Thread via GitHub
GOODBOY008 merged PR #4037: URL: https://github.com/apache/flink-cdc/pull/4037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-37894][table] Introduce Index in CatalogTable [flink]

2025-06-10 Thread via GitHub
Au-Miner commented on code in PR #26632: URL: https://github.com/apache/flink/pull/26632#discussion_r2137076110 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1881,7 +1881,8 @@ public ResolvedCatalogView resolveCatalo

Re: [PR] [FLINK-35670][cdc-connector][postgres]Flink cdc pipeline support postgres source [flink-cdc]

2025-06-10 Thread via GitHub
Mrart commented on PR #3968: URL: https://github.com/apache/flink-cdc/pull/3968#issuecomment-2957903623 @lvyanquan Can we support map type in another pr?It is too many code in this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

  1   2   3   4   5   6   7   8   9   10   >