Re: [D] Time Plan for the first MVP version of Flink Agents [flink-agents]

2025-08-04 Thread via GitHub
GitHub user xintongsong edited a discussion: Time Plan for the first MVP version of Flink Agents We are targeting a MVP version of Flink Agents (0.1.0) in around end of September. That is 16 weeks from now, and here is a rough time plan. # Phase 1: Week 1-3 (Jun 12 - Jul 2) - [x] Preparation

Re: [D] Time Plan for the first MVP version of Flink Agents [flink-agents]

2025-08-04 Thread via GitHub
GitHub user xintongsong edited a discussion: Time Plan for the first MVP version of Flink Agents We are targeting a MVP version of Flink Agents (0.1.0) in around end of September. That is 16 weeks from now, and here is a rough time plan. # Phase 1: Week 1-3 (Jun 12 - Jul 2) - [x] Preparation

Re: [I] [Feature][api][python] Introduce Prompt, Tool and ChatModel in Python [flink-agents]

2025-08-04 Thread via GitHub
xintongsong closed issue #76: [Feature][api][python] Introduce Prompt, Tool and ChatModel in Python URL: https://github.com/apache/flink-agents/issues/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [api][python] Introduce Prompt, Tool and ChatModel in python [flink-agents]

2025-08-04 Thread via GitHub
xintongsong merged PR #81: URL: https://github.com/apache/flink-agents/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-32695] [Tests] Migrated StreamTaskTimerITCase to new Source V2. [flink]

2025-08-04 Thread via GitHub
flinkbot commented on PR #26867: URL: https://github.com/apache/flink/pull/26867#issuecomment-3153120993 ## CI report: * 3f9430096b21b0ac9dafd56e497303c97c9180dc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-32695] [Tests] Migrated StreamTaskTimerITCase to new Source V2. [flink]

2025-08-04 Thread via GitHub
Poorvankbhatia opened a new pull request, #26867: URL: https://github.com/apache/flink/pull/26867 ## What is the purpose of the change Move StreamTaskTimerITCase to new Source V2. ## Brief change log - Migrated InfiniteTestSource to DataGeneratorSource. ## Verifyin

Re: [PR] [FLINK-38035][Python][PythonEnvUtils] Redact sensitive env vars in PythonEnvUtils logging [flink]

2025-08-04 Thread via GitHub
dianfu closed pull request #26841: [FLINK-38035][Python][PythonEnvUtils] Redact sensitive env vars in PythonEnvUtils logging URL: https://github.com/apache/flink/pull/26841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-38035][Python][PythonEnvUtils] Redact sensitive env vars in PythonEnvUtils logging [flink]

2025-08-04 Thread via GitHub
dianfu commented on PR #26841: URL: https://github.com/apache/flink/pull/26841#issuecomment-3153056877 Merged via https://github.com/apache/flink/commit/5218f0950de207452545671c596572d74ed10199 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-38184] one time of GetCopyOfBuffer is enough When serializing split. [flink-cdc]

2025-08-04 Thread via GitHub
leonardBang commented on PR #4073: URL: https://github.com/apache/flink-cdc/pull/4073#issuecomment-3153055460 @loserwang1024 Could you rebase to latest master branch to fix the failed case? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

2025-08-04 Thread via GitHub
xintongsong merged PR #26859: URL: https://github.com/apache/flink/pull/26859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-37735][serializer] Replace class.newInstance with constructor.newInstance [flink]

2025-08-04 Thread via GitHub
nikita-ivanov-cc commented on PR #26863: URL: https://github.com/apache/flink/pull/26863#issuecomment-3152533967 approve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update README.md for end-to-end tests [flink]

2025-08-04 Thread via GitHub
flinkbot commented on PR #26866: URL: https://github.com/apache/flink/pull/26866#issuecomment-3152531315 ## CI report: * ff513e6560f727babbdd16612aab6acff91a196a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Update README.md for end-to-end tests [flink]

2025-08-04 Thread via GitHub
nikita-ivanov-cc opened a new pull request, #26866: URL: https://github.com/apache/flink/pull/26866 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferrin

Re: [PR] [FLINK-37844][table] Add new ProjectMultiJoinTransposeRule [flink]

2025-08-04 Thread via GitHub
gustavodemorais commented on code in PR #26856: URL: https://github.com/apache/flink/pull/26856#discussion_r2252617310 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/ProjectMultiJoinTransposeRule.java: ## @@ -0,0 +1,495 @@ +/*

Re: [PR] [FLINK-38154][metrics] Add HTTP protocol support to OpenTelemetry reporters [flink]

2025-08-04 Thread via GitHub
rmetzger commented on PR #26850: URL: https://github.com/apache/flink/pull/26850#issuecomment-3150762095 Looks like checkstyle is unhappy: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69180&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-0

Re: [PR] [FLINK-38185][pipeline-connector][iceberg] Correctly handle the type conversion of TIMESTAMP_TITH_TIME_ZONE. [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan merged PR #4074: URL: https://github.com/apache/flink-cdc/pull/4074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan merged PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-38141][pipeline-connector/iceberg] Fix iceberg connector incorrect type mapping [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan merged PR #4070: URL: https://github.com/apache/flink-cdc/pull/4070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-04 Thread via GitHub
twalthr commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2251239361 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala: ## @@ -301,7 +301,9 @@ object CodeGenUtils { // ordere

Re: [PR] [FLINK-38185][pipeline-connector][iceberg] Correctly handle the type conversion of TIMESTAMP_TITH_TIME_ZONE. [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan commented on PR #4074: URL: https://github.com/apache/flink-cdc/pull/4074#issuecomment-3150286435 Hi @yuxiqian, maybe you can help to review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [FLINK-38185][pipeline-connector][iceberg] Correctly handle the type conversion of TIMESTAMP_TITH_TIME_ZONE. [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan opened a new pull request, #4074: URL: https://github.com/apache/flink-cdc/pull/4074 Fix TIMESTAMP_TITH_TIME_ZONE type conversion and failed case of IcebergWriterTest.testWriteWithAllSupportedTypes. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-32695] [Tests] Migrated TimestampITCase to SourceV2 [flink]

2025-08-04 Thread via GitHub
flinkbot commented on PR #26865: URL: https://github.com/apache/flink/pull/26865#issuecomment-3150173515 ## CI report: * fd4bcfe0f2002448016f3867db2672b6622f469a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-32695] [Tests] Migrated TimestampITCase to SourceV2 [flink]

2025-08-04 Thread via GitHub
Poorvankbhatia opened a new pull request, #26865: URL: https://github.com/apache/flink/pull/26865 ## What is the purpose of the change This PR migrates all legacy SourceFunction usages in TimestampITCase to the modern FLIP-27 Source V2 API ## Brief change log -Replac

Re: [PR] [hotfix] Do not run community review label and stale PR workflow on forks [flink]

2025-08-04 Thread via GitHub
snuyanzin merged PR #26864: URL: https://github.com/apache/flink/pull/26864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-04 Thread via GitHub
snuyanzin commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2251146191 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala: ## @@ -312,6 +310,17 @@ object CodeGenUtils { case _

Re: [I] [Feature][runtime][python] Support async execution for actions in python [flink-agents]

2025-08-04 Thread via GitHub
xintongsong closed issue #86: [Feature][runtime][python] Support async execution for actions in python URL: https://github.com/apache/flink-agents/issues/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [Feature][runtime][java] Support async execution for actions in java [flink-agents]

2025-08-04 Thread via GitHub
xintongsong opened a new issue, #87: URL: https://github.com/apache/flink-agents/issues/87 ### Search before asking - [x] I searched in the [issues](https://github.com/apache/flink-agents/issues) and found nothing similar. ### Description [Feature][runtime][java] Suppor

[I] [Feature][runtime][python] Support async execution for actions in python [flink-agents]

2025-08-04 Thread via GitHub
xintongsong opened a new issue, #86: URL: https://github.com/apache/flink-agents/issues/86 ### Search before asking - [x] I searched in the [issues](https://github.com/apache/flink-agents/issues) and found nothing similar. ### Description [Feature][runtime][python] Supp

Re: [PR] [API][Runtime] Support agent and action asynchronous execution [flink-agents]

2025-08-04 Thread via GitHub
xintongsong merged PR #80: URL: https://github.com/apache/flink-agents/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [hotfix] Format code using tools/lint.sh [flink-agents]

2025-08-04 Thread via GitHub
codenohup closed pull request #79: [hotfix] Format code using tools/lint.sh URL: https://github.com/apache/flink-agents/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [api][python] Introduce Prompt, Tool and ChatModel in python [flink-agents]

2025-08-04 Thread via GitHub
xintongsong commented on code in PR #81: URL: https://github.com/apache/flink-agents/pull/81#discussion_r2250920806 ## python/flink_agents/plan/resource_provider.py: ## @@ -81,11 +88,12 @@ class PythonResourceProvider(ResourceProvider): clazz: str kwargs: Dict[str, Any

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250952757 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java: #

Re: [PR] [FLINK-38142] Upgrading the Paimon version to 1.2.0 [flink-cdc]

2025-08-04 Thread via GitHub
junmuz commented on PR #4066: URL: https://github.com/apache/flink-cdc/pull/4066#issuecomment-3149830805 @Mrart Sorry I couldn't find your comment on the PR. I am looking into the test case failures. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-04 Thread via GitHub
yuxiqian commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250897167 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java: ##

Re: [PR] [API][Runtime] Support agent and action asynchronous execution [flink-agents]

2025-08-04 Thread via GitHub
xintongsong commented on code in PR #80: URL: https://github.com/apache/flink-agents/pull/80#discussion_r2250795038 ## runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java: ## @@ -112,75 +150,167 @@ public void open() throws Exception {

Re: [PR] [FLINK-38139] Fix consecutive online schema change causes job failure. [flink-cdc]

2025-08-04 Thread via GitHub
czy006 commented on code in PR #4064: URL: https://github.com/apache/flink-cdc/pull/4064#discussion_r2250876177 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java:

Re: [PR] [FLINK-38139] Fix consecutive online schema change causes job failure. [flink-cdc]

2025-08-04 Thread via GitHub
czy006 commented on code in PR #4064: URL: https://github.com/apache/flink-cdc/pull/4064#discussion_r2250699624 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java:

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-04 Thread via GitHub
raminqaf commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2250745669 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/RowFunctionITCase.java: ## @@ -83,6 +92,35 @@ Stream getTestSetSpecs() {

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-04 Thread via GitHub
twalthr commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2250729934 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/RowFunctionITCase.java: ## @@ -83,6 +92,35 @@ Stream getTestSetSpecs() {

Re: [PR] [api][python] Introduce Prompt, Tool and ChatModel in python [flink-agents]

2025-08-04 Thread via GitHub
wenjin272 commented on code in PR #81: URL: https://github.com/apache/flink-agents/pull/81#discussion_r2250654269 ## python/flink_agents/plan/resource_provider.py: ## @@ -81,11 +81,27 @@ class PythonResourceProvider(ResourceProvider): clazz: str kwargs: Dict[str, Any]

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250598523 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlEventDeserializer.java

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250598523 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlEventDeserializer.java

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-04 Thread via GitHub
lvyanquan commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250586336 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/StatementUtils.java: ##

Re: [PR] [API][Runtime] Support agent and action asynchronous execution [flink-agents]

2025-08-03 Thread via GitHub
codenohup commented on code in PR #80: URL: https://github.com/apache/flink-agents/pull/80#discussion_r2250498638 ## plan/src/main/java/org/apache/flink/agents/plan/JavaFunction.java: ## @@ -71,7 +71,10 @@ public Class[] getParameterTypes() { return parameterTypes;

Re: [PR] [API][Runtime] Support agent and action asynchronous execution [flink-agents]

2025-08-03 Thread via GitHub
codenohup commented on code in PR #80: URL: https://github.com/apache/flink-agents/pull/80#discussion_r2250359039 ## python/flink_agents/runtime/local_runner.py: ## @@ -128,6 +128,23 @@ def get_action_metric_group(self) -> MetricGroup: err_msg = "Metric mechanism is not

[PR] [FLINK-38184] one time of GetCopyOfBuffer is enough When serializing split. [flink-cdc]

2025-08-03 Thread via GitHub
loserwang1024 opened a new pull request, #4073: URL: https://github.com/apache/flink-cdc/pull/4073 Fix http://issues.apache.org/jira/browse/FLINK-38183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-03 Thread via GitHub
yuxiqian commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250304629 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/StatementUtils.java: ## @

Re: [PR] [FLINK-38135][table] Fix call to non-existent method for RAW type hashing [flink]

2025-08-03 Thread via GitHub
dylanhz commented on code in PR #26823: URL: https://github.com/apache/flink/pull/26823#discussion_r2250290987 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/CalcITCase.scala: ## @@ -857,22 +857,22 @@ class CalcITCase extends B

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-03 Thread via GitHub
lvyanquan commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250273555 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/StatementUtils.java: ##

Re: [PR] [minor] Fix potential sql connection statement issue [flink-cdc]

2025-08-03 Thread via GitHub
lvyanquan commented on code in PR #4069: URL: https://github.com/apache/flink-cdc/pull/4069#discussion_r2250273555 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/StatementUtils.java: ##

Re: [PR] [FLINK-37065]: MySQL cdc can lose/skip data during recovering from the checkpoint [flink-cdc]

2025-08-03 Thread via GitHub
leonardBang commented on PR #3845: URL: https://github.com/apache/flink-cdc/pull/3845#issuecomment-3148900794 @mielientiev Thanks for your contribution, I'll review this PR ASAP. Before the review work, could you kindly rebase to latest master branch to fix current CI failed cases? -- Th

Re: [PR] [FLINK-38183] Fix the problem of data loss in the GTID disordered scenario [flink-cdc]

2025-08-03 Thread via GitHub
leonardBang commented on PR #4072: URL: https://github.com/apache/flink-cdc/pull/4072#issuecomment-3148895372 @ruanhang1993 would you take a look this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-37735][serializer] Replace class.newInstance with constructor.newInstance [flink]

2025-08-03 Thread via GitHub
X-czh commented on PR #26863: URL: https://github.com/apache/flink/pull/26863#issuecomment-314610 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [D] Time Plan for the first MVP version of Flink Agents [flink-agents]

2025-08-03 Thread via GitHub
GitHub user xintongsong edited a discussion: Time Plan for the first MVP version of Flink Agents We are targeting a MVP version of Flink Agents (0.1.0) in around end of September. That is 16 weeks from now, and here is a rough time plan. # Phase 1: Week 1-3 (Jun 12 - Jul 2) - [x] Preparation

[PR] [FLINK-38123] Upgrade flink version autscaling example [flink-kubernetes-operator]

2025-08-03 Thread via GitHub
kaygorodov opened a new pull request, #1004: URL: https://github.com/apache/flink-kubernetes-operator/pull/1004 ## What is the purpose of the change The autoscaling example image is based on Flink 1.18 rather than 1.20.1. ## Brief change log - Upgrades Flink and Java vers

Re: [PR] [FLINK-37869][Observer] Fix finished bounded stream jobs can't be cle… [flink-kubernetes-operator]

2025-08-03 Thread via GitHub
qinf commented on PR #1003: URL: https://github.com/apache/flink-kubernetes-operator/pull/1003#issuecomment-3148401291 > Hi @1996fanrui , could you help take a look this PR in your free time? The flink cluster resource will be deleted after `kubernetes.operator.jm-deployment.shutdown

Re: [PR] [api][python] Introduce Prompt, Tool and ChatModel in python [flink-agents]

2025-08-03 Thread via GitHub
xintongsong commented on code in PR #81: URL: https://github.com/apache/flink-agents/pull/81#discussion_r2249746716 ## python/flink_agents/api/prompts/utils.py: ## @@ -0,0 +1,38 @@ + +# Licensed to

Re: [PR] [FLINK-37869][Observer] Fix finished bounded stream jobs can't be cle… [flink-kubernetes-operator]

2025-08-03 Thread via GitHub
qinf commented on PR #1003: URL: https://github.com/apache/flink-kubernetes-operator/pull/1003#issuecomment-3148258131 Hi @1996fanrui , could you help take a look this PR in your free time? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [API][Runtime] Support agent and action asynchronous execution [flink-agents]

2025-08-03 Thread via GitHub
xintongsong commented on code in PR #80: URL: https://github.com/apache/flink-agents/pull/80#discussion_r2247225634 ## python/flink_agents/plan/function.py: ## @@ -237,6 +237,27 @@ def check_signature(self, *args: Tuple[Any, ...]) -> None: """Check function signature is

Re: [PR] [hotfix][docs] The tab name scala is changed to the uniformly used Scala in the table api document. [flink]

2025-08-02 Thread via GitHub
github-actions[bot] closed pull request #22534: [hotfix][docs] The tab name scala is changed to the uniformly used Scala in the table api document. URL: https://github.com/apache/flink/pull/22534 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [hotfix][docs] The tab name scala is changed to the uniformly used Scala in the table api document. [flink]

2025-08-02 Thread via GitHub
github-actions[bot] commented on PR #22534: URL: https://github.com/apache/flink/pull/22534#issuecomment-3147381522 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-37735][serializer] Replace class.newInstance with constructor.newInstance [flink]

2025-08-02 Thread via GitHub
X-czh commented on PR #26863: URL: https://github.com/apache/flink/pull/26863#issuecomment-3147299521 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [api][java] Support DataStream / Table as input / output of Flink Agents in Java [flink-agents]

2025-08-02 Thread via GitHub
letaoj opened a new pull request, #85: URL: https://github.com/apache/flink-agents/pull/85 Linked issue: #xxx ### Purpose of change ### Tests ### API ### Documentation -- This is an automated message from t

[PR] [FLINK-38183] Fix the problem of data loss in the GTID disordered scenario [flink-cdc]

2025-08-02 Thread via GitHub
lzshlzsh opened a new pull request, #4072: URL: https://github.com/apache/flink-cdc/pull/4072 As the design of [https://github.com/apache/flink-cdc/pull/2220](http://example.com/),CDC only cares about the maximum GTID position and starts from it. For example, if reading from gtid offset 1-

Re: [PR] [FLINK-37700][table-planner] Fix SQL parse exception when creating a view with PTF [flink]

2025-08-02 Thread via GitHub
juntaozhang commented on code in PR #26487: URL: https://github.com/apache/flink/pull/26487#discussion_r2249492755 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-37479][postgres] Add support for PARTITIONED TABLE [flink-cdc]

2025-08-02 Thread via GitHub
phamvinh1712 commented on PR #4004: URL: https://github.com/apache/flink-cdc/pull/4004#issuecomment-3146819556 hi @loserwang1024 @leonardBang @ruanhang1993 , thanks all for the feedbacks 🙌 and sorry for the late response. I've updated the configuration like suggested, could you help to

[PR] [minor][improvement] Add subdirectory scrapping to add all .jar in classpath [flink-cdc]

2025-08-02 Thread via GitHub
CatOrLeader opened a new pull request, #4071: URL: https://github.com/apache/flink-cdc/pull/4071 ## Rationale I was stuck with this issue for a while when deploying CDC pipelines on my cluster. It seems that it is not convenient to get .jar files only at the first level of depth, so

Re: [PR] [FLINK-36536] Bumped `commons-text` from 1.10.0 to 1.12.0 [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on code in PR #26459: URL: https://github.com/apache/flink/pull/26459#discussion_r2249297445 ## flink-dist/src/main/resources/META-INF/NOTICE: ## @@ -13,9 +13,9 @@ This project bundles the following dependencies under the Apache Software Licens - commons-co

Re: [PR] [FLINK-37637] Avoid dead lock for Configuration's addAll [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on code in PR #26426: URL: https://github.com/apache/flink/pull/26426#discussion_r2249278788 ## flink-core/src/main/java/org/apache/flink/configuration/Configuration.java: ## @@ -239,9 +239,21 @@ public void addAllToProperties(Properties props) { }

Re: [PR] [FLINK-37700][table-planner] Fix SQL parse exception when creating a view with PTF [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on code in PR #26487: URL: https://github.com/apache/flink/pull/26487#discussion_r2249277947 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [FLINK-38135][table] Fix call to non-existent method for RAW type hashing [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on code in PR #26823: URL: https://github.com/apache/flink/pull/26823#discussion_r2249274542 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/CalcITCase.scala: ## @@ -1692,9 +1692,10 @@ class CalcITCase extend

Re: [PR] [FLINK-38135][table] Fix call to non-existent method for RAW type hashing [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on code in PR #26823: URL: https://github.com/apache/flink/pull/26823#discussion_r2249274387 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/CalcITCase.scala: ## @@ -857,22 +857,22 @@ class CalcITCase extends

Re: [PR] [FLINK-38069] Fix return type nullability diffs of function ENCODE & DECODE in SQL and Table API [flink]

2025-08-02 Thread via GitHub
snuyanzin merged PR #26771: URL: https://github.com/apache/flink/pull/26771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-38138] Fix OOB error in ColumnarArrayData [flink]

2025-08-02 Thread via GitHub
snuyanzin merged PR #26826: URL: https://github.com/apache/flink/pull/26826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-38179] Upgrade os-maven-plugin for RISC-V riscv64 support [flink]

2025-08-02 Thread via GitHub
snuyanzin merged PR #26860: URL: https://github.com/apache/flink/pull/26860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-38179] Upgrade os-maven-plugin for RISC-V riscv64 support [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on PR #26860: URL: https://github.com/apache/flink/pull/26860#issuecomment-3146539372 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37065]: MySQL cdc can lose/skip data during recovering from the checkpoint [flink-cdc]

2025-08-02 Thread via GitHub
mielientiev commented on PR #3845: URL: https://github.com/apache/flink-cdc/pull/3845#issuecomment-3146501691 @leonardBang @xiaom @ruanhang1993 Could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [FLINK-37869][Observer] Fix finished bounded stream jobs can't be cle… [flink-kubernetes-operator]

2025-08-02 Thread via GitHub
qinf opened a new pull request, #1003: URL: https://github.com/apache/flink-kubernetes-operator/pull/1003 ## What is the purpose of the change Fix finished bounded stream jobs can't be cleanup by the Flink Kubernetes Operator [FLINK-37869](https://issues.apache.org/jira/br

Re: [PR] [hotfix] Do not run community review label and stale PR workflow on forks [flink]

2025-08-02 Thread via GitHub
flinkbot commented on PR #26864: URL: https://github.com/apache/flink/pull/26864#issuecomment-3146369271 ## CI report: * e8c08de0501f6366b9505bdf23e998c3ce90f8c9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] Do not run community review label and stale PR workflow on forks [flink]

2025-08-02 Thread via GitHub
snuyanzin commented on PR #26864: URL: https://github.com/apache/flink/pull/26864#issuecomment-3146368782 @davidradl , @tomncooper If I'm not mistaken you were some of the drivers of these workflows, could please take a look here? -- This is an automated message from the Apache Git Se

[PR] [hotfix] Do not run community review label on non Apache repo [flink]

2025-08-02 Thread via GitHub
snuyanzin opened a new pull request, #26864: URL: https://github.com/apache/flink/pull/26864 ## What is the purpose of the change The problem is that if someone syncs his/her fork with recent master then stale PR and community review process will start running on that fork as well...

Re: [PR] Add Flink 2.1.0 release [flink-web]

2025-08-01 Thread via GitHub
Pythoneryeah closed pull request #804: Add Flink 2.1.0 release URL: https://github.com/apache/flink-web/pull/804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Add Flink 2.1.0 release [flink-web]

2025-08-01 Thread via GitHub
Pythoneryeah opened a new pull request, #804: URL: https://github.com/apache/flink-web/pull/804 hi,this is a test for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-37735][serializer] Replace class.newInstance with constructor.newInstance [flink]

2025-08-01 Thread via GitHub
flinkbot commented on PR #26863: URL: https://github.com/apache/flink/pull/26863#issuecomment-3146161373 ## CI report: * 95d80920ca2d4a67816e95269004107abeb321f1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37735][serializer] Replace class.newInstance with constructor.newInstance [flink]

2025-08-01 Thread via GitHub
X-czh opened a new pull request, #26863: URL: https://github.com/apache/flink/pull/26863 ## What is the purpose of the change Lower PojoSerializer newInstance cost for higher deserialization performance. ## Brief change log Replace class.newInstance with construct

Re: [PR] [FLINK-37541][table-planner] Deprecate getTargetColumns in DynamicTableSink.Context [flink]

2025-08-01 Thread via GitHub
xiangyuf commented on PR #26381: URL: https://github.com/apache/flink/pull/26381#issuecomment-3146098609 @xuyangzhong @lincoln-lil @lsyldliu kindly remind for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-01 Thread via GitHub
snuyanzin commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2248717909 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/RowFunctionITCase.java: ## @@ -83,6 +92,36 @@ Stream getTestSetSpecs() {

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-01 Thread via GitHub
snuyanzin commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2248486005 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/RowFunctionITCase.java: ## @@ -83,6 +92,36 @@ Stream getTestSetSpecs() {

Re: [PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-01 Thread via GitHub
flinkbot commented on PR #26862: URL: https://github.com/apache/flink/pull/26862#issuecomment-3145020105 ## CI report: * 8edce5f24d135af5d9b0f8a4c1f0312342c34349 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-38181] Code generation fails for ROW() with CAST to SMALLINT/TINYINT when input is non-literal [flink]

2025-08-01 Thread via GitHub
raminqaf opened a new pull request, #26862: URL: https://github.com/apache/flink/pull/26862 ## What is the purpose of the change This pull request fixes a code generation compilation error that occurs when using the `ROW()` function with `CAST()` to `SMALLINT` or `TINYINT` types on n

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
pnowojski commented on PR #26861: URL: https://github.com/apache/flink/pull/26861#issuecomment-3144718448 e2e test was failing due to: ``` java.lang.NullPointerException: Cannot invoke "org.apache.flink.table.runtime.util.collections.binary.AbstractBytesHashMap.free()" because "this.a

Re: [PR] [FLINK-37844][table] Add new ProjectMultiJoinTransposeRule [flink]

2025-08-01 Thread via GitHub
twalthr commented on code in PR #26856: URL: https://github.com/apache/flink/pull/26856#discussion_r2248061867 ## flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-multi-join_1/four-way-complex-updating-join-with-restore/plan/four-way-complex-updating-join-wit

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
Savonitar commented on code in PR #26861: URL: https://github.com/apache/flink/pull/26861#discussion_r2248031328 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -612,6 +613,7 @@ private void doRun() { // need to be undone in the end

Re: [PR] [api][python] Introduce Prompt, Tool and ChatModel in python [flink-agents]

2025-08-01 Thread via GitHub
wenjin272 commented on code in PR #81: URL: https://github.com/apache/flink-agents/pull/81#discussion_r2247967712 ## python/flink_agents/plan/action.py: ## @@ -41,40 +49,109 @@ class Action(BaseModel): """ name: str -#TODO: Raise a warning when the action has a r

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
pnowojski commented on code in PR #26861: URL: https://github.com/apache/flink/pull/26861#discussion_r2247946520 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -612,6 +613,7 @@ private void doRun() { // need to be undone in the end

Re: [PR] [FLINK-38173][release] Generate reference data for state migration tests based on release-2.1.0 [flink]

2025-08-01 Thread via GitHub
lsyldliu merged PR #26855: URL: https://github.com/apache/flink/pull/26855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
Savonitar commented on code in PR #26861: URL: https://github.com/apache/flink/pull/26861#discussion_r2247536470 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -612,6 +613,7 @@ private void doRun() { // need to be undone in the end

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
flinkbot commented on PR #26861: URL: https://github.com/apache/flink/pull/26861#issuecomment-3143821513 ## CI report: * 6dfc98644926a9ff890deb516e279dbfdac876ab UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
pnowojski commented on code in PR #26861: URL: https://github.com/apache/flink/pull/26861#discussion_r2247395574 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -827,6 +829,8 @@ else if (transitionState(current, ExecutionState.FAILED, t)) {

Re: [PR] [FLINK-38180][task] Clean up task after switching to FAILED [flink]

2025-08-01 Thread via GitHub
pnowojski commented on code in PR #26861: URL: https://github.com/apache/flink/pull/26861#discussion_r2247395574 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -827,6 +829,8 @@ else if (transitionState(current, ExecutionState.FAILED, t)) {

  1   2   3   4   5   6   7   8   9   10   >