[GitHub] flink issue #5050: [FLINK-4822] Ensure that the Kafka 0.8 connector is compa...

2017-12-15 Thread taizilongxu
Github user taizilongxu commented on the issue: https://github.com/apache/flink/pull/5050 Hi, is there any thing to edit or change? ---

[GitHub] flink pull request #5050: [FLINK-4822] Ensure that the Kafka 0.8 connector i...

2017-11-28 Thread taizilongxu
Github user taizilongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/5050#discussion_r153426741 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/ZookeeperOffsetHandler.java

[GitHub] flink issue #5050: [FLINK-4822] Ensure that the Kafka 0.8 connector is compa...

2017-11-22 Thread taizilongxu
Github user taizilongxu commented on the issue: https://github.com/apache/flink/pull/5050 the prefix is the same as kafka high level api, contain the uuid string, so it could be unique ---

[GitHub] flink pull request #5050: [FLINK-4822] Ensure that the Kafka 0.8 connector i...

2017-11-22 Thread taizilongxu
GitHub user taizilongxu opened a pull request: https://github.com/apache/flink/pull/5050 [FLINK-4822] Ensure that the Kafka 0.8 connector is compatible with k… ## What is the purpose of the change When we deploy the taskmanager in docker of our cluster, it's ha

[GitHub] flink pull request #:

2017-09-14 Thread taizilongxu
Github user taizilongxu commented on the pull request: https://github.com/apache/flink/commit/2437da6e54cb48c4e29116b8789fbe4782b17ea7#commitcomment-24300072 In docs/dev/connectors/elasticsearch.md: In docs/dev/connectors/elasticsearch.md on line 358: I thinks the code is