Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1276#issuecomment-150665625
@StephanEwen I have made the changes and rebased on master. Kindly review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1276#issuecomment-149862453
I just observed that Flink has already dropped Java 6 support. try with
resources is the best possible approach then. I will amend my commit.
---
If your project is
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1276#discussion_r42527314
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-twitter/src/main/java/org/apache/flink/streaming/connectors/twitter
GitHub user ssaumitra opened a pull request:
https://github.com/apache/flink/pull/1276
[FLINK-2827] Closing FileInputStream in finally block to avoid unused open
stream.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1250#issuecomment-148486062
@vasia I have updated it. Please have a look. Also should I be worried
about Travis build failure? Looks like it's failing on master too,
---
If your project i
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1250#discussion_r42153609
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleEnumerator.java
---
@@ -0,0 +1,347 @@
+/*
+ * Licensed
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1250#discussion_r42153562
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleEnumerator.java
---
@@ -0,0 +1,347 @@
+/*
+ * Licensed
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1250#discussion_r42153539
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/example/utils/TriangleCountData.java
---
@@ -20,10 +20,12 @@
import
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1250#discussion_r42153585
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleEnumerator.java
---
@@ -0,0 +1,347 @@
+/*
+ * Licensed
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1250#discussion_r42108353
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleEnumerator.java
---
@@ -0,0 +1,347 @@
+/*
+ * Licensed
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1254#issuecomment-147245999
Made the change. I have amended the past commit because it was kind-of
incorrect.
---
If your project is set up for it, you can reply to this email and have your
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1254#issuecomment-147244169
Oh, my bad, I thought Flink Roadmap is the only main page maintained for
sub-projects too. Is this the correct one?
https://cwiki.apache.org/confluence/display/FLINK
GitHub user ssaumitra opened a pull request:
https://github.com/apache/flink/pull/1254
[FLINK-2841] Correcting roadmap link to point to confluence.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssaumitra/flink FLINK_2841
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1250#issuecomment-147186203
I have converted it to TriangleEnumerator now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1250#issuecomment-147180010
Fir enough. I will make this change in my pull request then. Can you please
edit the JIRA too? So that updated pull request and JIRA title stay relevant?
---
If your
Github user ssaumitra commented on the pull request:
https://github.com/apache/flink/pull/1250#issuecomment-147179239
In my opinion, if we provide TriangleEnumerator as a library function,
TriangleCounter would be trivial extension to it. So would it be required to
add it in library
Github user ssaumitra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1250#discussion_r41696647
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleCounter.java
---
@@ -0,0 +1,339 @@
+/*
+ * Licensed to
GitHub user ssaumitra opened a pull request:
https://github.com/apache/flink/pull/1250
[FLINK-2714] [Gelly] Copy triangle counting logic from
EnumTrianglesOpt.java to Gelly library.
Also reorganizing classes to use Gelly's Graph APIs.
You can merge this pull request into
18 matches
Mail list logo
