Github user smarthi commented on the issue:
https://github.com/apache/flink/pull/2422
Sure. I tried to exclude the most obvious false negatives but didn't go to
the full extent. Hopefully this is a good place to start.
---
If your project is set up for it, you can reply to
Github user smarthi commented on the issue:
https://github.com/apache/flink/pull/2422
I updated the findbugs-exclude.xml with some basic rules that can be
ignored.
I set the to 'default' for now - can't keep it 'High' since it was
freezing up my la
Github user smarthi commented on the issue:
https://github.com/apache/flink/pull/2422
Setup a default findbugs-exclude.xml, please feel free to customize as u
deem fit for Flink.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2422
FLINK-4499: Introduce findbugs maven plugin
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
Github user smarthi commented on the issue:
https://github.com/apache/flink/pull/2416
1. Changed the ES2 version to 2.3.5
2. Fixed broken ElasticsearchExample.java
3. Removed use of Guava API.
---
If your project is set up for it, you can reply to this email and have your
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2416
FLINK-4480: Incorrect link to elastic.co in documentation
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2367#discussion_r74711517
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -256,16 +267,75 @@ public void prune(long
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2367#discussion_r74711491
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -256,16 +267,75 @@ public void prune(long
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2367#discussion_r74711450
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -26,6 +26,7 @@
import
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72472262
--- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java
---
@@ -293,6 +293,16 @@ private static String format(@Nullable String
template
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71981015
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/examples/java/JavaSQLExample.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2232
FLINK-4179: Update TPCHQuery3Table example
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2224
{hotfix} fix errors and formatting in NiFi documentation
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2162
FLINK-4103: Modify CsvTableSource to implement StreamTableSource
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user smarthi closed the pull request at:
https://github.com/apache/flink/pull/2161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user smarthi commented on the issue:
https://github.com/apache/flink/pull/2161
Wrong Jira# closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2161
FLINK-4301: Modify CsvTableSource to implement StreamTableSource
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2099
Flink 3323: Add documentation for NiFi connector
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65068847
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/2047#issuecomment-222344951
I started to add some NiFi integration tests which are presently lacking,
but realized that it would be better to have that as part of a different jira.
---
If your
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2047
FLINK-3405: Extend NiFiSource with interface StoppableFunction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216487812
There IRC Wikimedia channel is timing out and hence the reason for Wiki
test failures, nothing to do with this PR.
LGTM IMO
---
If your project is set up for
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1952#issuecomment-216409045
ElasticSearch 2.x requires jackson >= 2.6.2, hence the Elastic 2.x
connector jackson version is set at 2.7.x. Locally, I changed the Jackson
version to be 2.7.x in
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1952#discussion_r61670156
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -55,11 +55,11 @@ under the License
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1904#discussion_r60231836
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/RemoteEnvironment.java ---
@@ -133,26 +137,31 @@ public RemoteEnvironment(String host, int port
GitHub user smarthi reopened a pull request:
https://github.com/apache/flink/pull/1829
FLINK-3657: Change access of DataSetUtils.countElements() to 'public'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/f
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-204762444
Closing this PR without merging as its "way too specific", thanks for all
the feedback.
---
If your project is set up for it, you can reply to this emai
Github user smarthi closed the pull request at:
https://github.com/apache/flink/pull/1829
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-200848523
@uce @fhueske to add more context to this PR, we r in the final stretch of
a planned 0.12.0 Mahout release that adds Flink as a distributed engine for
Samsara linear
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-200551422
Not sure as to why u think this is "way to specific", this is a very
convenient feature to have when dealing with Distributed Row Matrix (DRM)
blocks for d
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1829
FLINK-3657: Change access of DataSetUtils.countElements() to 'public'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56886134
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1816
[hotfix] [docs] Fix broken link in Windows docs for time.htm, changed to
event_time.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1792#issuecomment-198110028
@rmetzger @mxm This PR is good to merge now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1815
[hotfix] [docs] Flink hotfix windows docs
Fix broken link in windows docs to 'time'
You can merge this pull request into a Git repository by running:
$ git pull https://github.c
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56575375
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1815#issuecomment-198085283
Bad PR, will submit a clean one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user smarthi closed the pull request at:
https://github.com/apache/flink/pull/1815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1792#discussion_r56316199
--- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/pom.xml
---
@@ -0,0 +1,107 @@
+
+
+http://maven.apache.org/POM/4.0.0
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1792
[WIP] FLINK-3115: Update ElasticSearch connector to 2.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink ElasticSearch2
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1552
Flink-3196: InputStream should be closed in EnvironmentInformation#geâ¦
â¦tRevisionInformation()
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1539
[hotfix]: remove references to deprecated junit.framework.Assert from tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink
Github user smarthi closed the pull request at:
https://github.com/apache/flink/pull/1479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1479#issuecomment-169450577
Closing this PR, will replace with a newer PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1478#discussion_r48663889
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/util/CollectionDataSets.java
---
@@ -429,7 +418,6 @@ public String toString
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1479
FLINK-3115: Update ElasticSearch connector to 2.x
Initial version of ElasticSearch v2.x Connector
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1478
FLINK-3186: Deprecate DataSink.sortLocalOutput() methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink Flink-3186
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1311#issuecomment-167371893
I was gonna close this Jira and withdraw the PR. Closing now..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user smarthi closed the pull request at:
https://github.com/apache/flink/pull/1311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1311#issuecomment-161066615
@rmetzger This fell off my radar briefly as other things took priority. Let
me know what you think about adding this to DataSet API, this follows from a
similar change
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1391#issuecomment-158790920
@rmetzger good to merge now, travis builds are successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1391#issuecomment-158778768
@rmetzger This is from the Table API which this PR does not touch, I can
either withdraw the PR or we could trigger another travis build for this PR and
see if the
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1391
[streaming-scala] Code cleanup: unused imports, fix javadocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink master
Github user smarthi commented on the pull request:
https://github.com/apache/flink/commit/8dc70f2e770ac1c355869f5e0b5e23379b1ed76f#commitcomment-14534466
In
flink-optimizer/src/test/java/org/apache/flink/optimizer/IterationsCompilerTest.java:
In
flink-optimizer/src/test/java/org
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1389
[docs] Fix Documentation formatting for recently added
ExecutionEnvironment.readSequenceFile()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1379
FLINK-3041: Twitter Streaming Description section of Streaming Programming
guide refers to an incorrect example 'TwitterLocal'
You can merge this pull request into a Git repository
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1362#issuecomment-157309957
@tillrohrmann this is the nitpick PR we talked about
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1364
FLINK-3022: Broken link 'Working With State' in Fault Tolerance Section of
Stream Programming Guide
You can merge this pull request into a Git repository by running:
$ git
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1362
Change the parameter 'numSample' in DataSetUtils.sampleWithSize() to â¦
â¦'numSamples', and remove redundant Java 6 code
You can merge this pull request into a Git r
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1356#issuecomment-157158385
Updated the PR title and description
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1357
Flink-3017: Fix broken 'Slots' link on Streaming Guide.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink Flink-3017
Alt
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1356
FLINK-3013: Incorrect package declaration in
GellyScalaAPICompletenessTest.scala
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink
Github user smarthi commented on the pull request:
https://github.com/apache/flink/commit/dd66e61ecc5da5b15a610f04b98c8386d141f910#commitcomment-14182299
Consider using Google Calipers for micro benchmarking ?? -
https://github.com/google/caliper
---
If your project is set up
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1299#issuecomment-152691666
@chiwanpark Fixed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1311
FLINK-2949 [WIP]: Add method 'writeSequencefile' to DataSet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1186#issuecomment-152265442
Suggest that you see how PMML been's done on Oryx 2.0 (PMML in Spark
followed Oryx 2.0). PMML support was discussed various times on the Mahout
project and was
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1299#issuecomment-152231287
@fhueske Updated ProgrammingGuide.md to reflect the missing APIs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1299#issuecomment-151398008
@tillrohrmann There's an existing DataSet#write() api, don't think we need
a DataSet#writeAsSequenceFile().
---
If your project is set up for it, you can rep
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/1299#issuecomment-151130141
Also need to add a method for the new Hadoop API, the present PR only deals
with Hadoop v1
---
If your project is set up for it, you can reply to this email and have
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/1299
[FLINK-2918] Add method to read a file of type SequenceFileInputFormat
Fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink work
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/530#discussion_r27135717
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/RegularPactTask.java
---
@@ -1465,7 +1467,9 @@ public static void
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/530#discussion_r27135877
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -1425,11 +1425,9 @@ public static boolean isClassType(Type t
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/530#discussion_r27135686
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/RegularPactTask.java
---
@@ -525,7 +525,9 @@ protected void run() throws Exception
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/530#issuecomment-86091921
@mxm please go ahead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/530#discussion_r27133810
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/AllGroupCombineDriver.java
---
@@ -35,20 +35,20 @@
* Like
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/530#issuecomment-85697927
@fhueske i think we shuld be LGTM now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user smarthi commented on the pull request:
https://github.com/apache/flink/pull/530#issuecomment-85688590
@fhueske yeah noticed that too, will update the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/530
Flink-1780: Rename FlatCombineFunction to GroupCombineFunction
Fixes Flink-1780
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/flink
78 matches
Mail list logo
