[GitHub] flink pull request #4607: [FLINK-6306][connectors] Sink for eventually consi...

2018-05-02 Thread sjwiesman
Github user sjwiesman closed the pull request at: https://github.com/apache/flink/pull/4607 ---

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2018-05-02 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/4607 * clicked the wrong button ---

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2018-05-02 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/4607 I'm going to go ahead and close this pr and issue to avoid confusion. ---

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2017-08-28 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/4607 Would you be able to rerun travis, the test failed on a single configuration during the Kafka09ITTest due to a task manager failure. I do not believe any of my code changes touched any of the code

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2017-08-27 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/4607 CC: @aljoscha I screwed up the rebase so I cherry picked the updates into a new branch and re-opened the pr. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #4607: [FLINK-6306][connectors] Sink for eventually consi...

2017-08-27 Thread sjwiesman
GitHub user sjwiesman opened a pull request: https://github.com/apache/flink/pull/4607 [FLINK-6306][connectors] Sink for eventually consistent file systems ## What is the purpose of the change This pull request implements a sink for writing out to an eventually consistent

[GitHub] flink pull request #3752: [FLINK-6306] [filesystem-connectors] Sink for even...

2017-08-27 Thread sjwiesman
Github user sjwiesman closed the pull request at: https://github.com/apache/flink/pull/3752 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3752: [FLINK-6306] [filesystem-connectors] Sink for eventually ...

2017-04-25 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3752 @tzulitai you took interest in the jira ticket, would you be willing to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #3752: [FLINK-6306] [filesystem-connectors] Sink for even...

2017-04-21 Thread sjwiesman
GitHub user sjwiesman opened a pull request: https://github.com/apache/flink/pull/3752 [FLINK-6306] [filesystem-connectors] Sink for eventually consistent file systems https://issues.apache.org/jira/browse/FLINK-6306 This PR introduces a bucketer for eventually consistent

[GitHub] flink pull request #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-20 Thread sjwiesman
Github user sjwiesman closed the pull request at: https://github.com/apache/flink/pull/3729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-19 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3729 @aljoscha Could you review this or point me in the direction of the correct person? I need this to land for the EventualConsistencySink --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-17 Thread sjwiesman
GitHub user sjwiesman opened a pull request: https://github.com/apache/flink/pull/3729 [FLINK-6315] Notify on checkpoint timeout https://issues.apache.org/jira/browse/FLINK-6315 A common use case when writing a custom operator that outputs data to some third party location

[GitHub] flink issue #3479: [FLINK-5929] Allow Access to Per-Window State in ProcessW...

2017-03-25 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3479 Done! Thank you for for helping me get this feature merged in. This has to be one of the most painless commits I've ever made to an open source project of this size. --- If your project i

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-25 Thread sjwiesman
Github user sjwiesman closed the pull request at: https://github.com/apache/flink/pull/3479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3479: [FLINK-5929] Allow Access to Per-Window State in ProcessW...

2017-03-21 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3479 Pushed the fix, I had to update SideOutputsITCase so the ProcessAllWindowFunctions had a noop clear method. All tests passed locally, take a look --- If your project is set up for it, you can

[GitHub] flink issue #3479: [FLINK-5929] Allow Access to Per-Window State in ProcessW...

2017-03-21 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3479 It looks like when I rebased on master I broke one of the scala side outputs test. I'm going to push a fix right now but it won't change any of the code surrounding this pr. --- If yo

[GitHub] flink issue #3479: [FLINK-5929] Allow Access to Per-Window State in ProcessW...

2017-03-20 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3479 sorry for the delay, things got crazy at work. let me know if there are any issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-13 Thread sjwiesman
Github user sjwiesman commented on a diff in the pull request: https://github.com/apache/flink/pull/3479#discussion_r105763162 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalAggregateProcessAllWindowFunction.java

[GitHub] flink issue #3479: [FLINK-5929] Allow Access to Per-Window State in ProcessW...

2017-03-08 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3479 @aljoscha I made the changes you asked for. Just a heads up, there are a number of files that were superficially changed when migrating from apply -> process but are otherwise untouched. ---

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-06 Thread sjwiesman
Github user sjwiesman commented on a diff in the pull request: https://github.com/apache/flink/pull/3479#discussion_r104492162 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java --- @@ -39,5

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-06 Thread sjwiesman
Github user sjwiesman commented on a diff in the pull request: https://github.com/apache/flink/pull/3479#discussion_r104458722 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java --- @@ -39,5

[GitHub] flink pull request #3479: [FLINK-5929] Allow Access to Per-Window State in P...

2017-03-06 Thread sjwiesman
GitHub user sjwiesman opened a pull request: https://github.com/apache/flink/pull/3479 [FLINK-5929] Allow Access to Per-Window State in ProcessWindowFunction Right now, the state that a WindowFunction or ProcessWindowFunction can access is scoped to the key of the window but not