[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-09 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r194239264 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +155,24

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193377245 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +153,18

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193361587 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193360923 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193359300 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193359253 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193358805 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -66,12 +79,19

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193357238 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193356675 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -124,7 +159,82

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193356713 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-06-06 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193356620 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191191853 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +40,36

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191187177 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191185023 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191184906 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191184148 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java --- @@ -151,7 +151,9

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191180121 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191179994 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +40,36

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-05-28 Thread pduveau
Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191179983 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -43,14 +49,27

[GitHub] flink issue #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage of AMQP ...

2018-04-05 Thread pduveau
Github user pduveau commented on the issue: https://github.com/apache/flink/pull/5410 Hi, Is there anyone to check this PR ? We have interest in getting an official version including this. ---

[GitHub] flink issue #5411: [FLINK-8556] [Kinesis Connector] Add proxy feature to the...

2018-04-05 Thread pduveau
Github user pduveau commented on the issue: https://github.com/apache/flink/pull/5411 Hi @tzulitai, Were you able to get time to check this PR ? We have interest in an official version including this. ---

[GitHub] flink pull request #5411: [FLINK-8556] [Kinesis Connector] Add proxy feature...

2018-02-04 Thread pduveau
GitHub user pduveau opened a pull request: https://github.com/apache/flink/pull/5411 [FLINK-8556] [Kinesis Connector] Add proxy feature to the connector ## The purpose of the change The connector can not be configured to use a proxy to access Kinesis endpoint. This

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

2018-02-04 Thread pduveau
GitHub user pduveau opened a pull request: https://github.com/apache/flink/pull/5410 [FLINK-8468] [RabbitMQ Connector] Take advantage of AMQP features ## The purpose of the change To extend the Sink Connector to take full advantage of AMQP features. The AMQP Message sent