[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-09 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-09 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 Is everything ok? Should I look into something else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-07 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 I think everything should be ready now. I was not able to pinpoint why HDFS worked, I assume `distributeFiles()` copied the complete directory and that is why it worked, but I'm not 100%

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-06 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 Yes, I had the same thought looking at the code, I could not figure out why it worked with HDFS... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-06 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 I can confirm that there is a bug in `PythonPlanBinder.java`. When you pass packages to the `runPlan()` function, they are not copied to the temp directory in which `plan.py` file is generated

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-05 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 Yes, I know that how python scripts are executed for the test is different. Let me elaborate: Since running the tests are quite costly in my laptop, I normally test my changes executing

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-05 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 I have fixed the last errors in the test functions. But, while trying to refactor the utility code, that now is repeated in both test files, I think I found another bug. The thing is

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-03 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 Sorry, I said it wrong, it's the opposite. The case that fails in Verify() and Verify2(), is when we have more values in expected than in the resulting DataSet. --- If your project is s

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-03 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 I have corrected Verify2(), but there is another case that is not checked, when the resulting datasets have more elements than expected, right now the error will go unnoticed. I also

[GitHub] flink issue #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-02 Thread omaralvarez
Github user omaralvarez commented on the issue: https://github.com/apache/flink/pull/2063 Ok, I will modify it and commit the corrected version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #2063: [FLINK-4002] [py] Improve testing infraestructure

2016-06-02 Thread omaralvarez
GitHub user omaralvarez opened a pull request: https://github.com/apache/flink/pull/2063 [FLINK-4002] [py] Improve testing infraestructure The Verify() test function now does not error out when array elements are missing: ```python env.generate_sequence(1, 5

[GitHub] flink pull request: [FLINK-3993] [py] Add generateSequence() support to Pyth...

2016-06-01 Thread omaralvarez
Github user omaralvarez commented on the pull request: https://github.com/apache/flink/pull/2055 Perfect. I'll open a new issue and try to fix that and document the test scripts. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] flink pull request: [FLINK-3993] [py] Add generateSequence() support to Pyth...

2016-06-01 Thread omaralvarez
Github user omaralvarez commented on the pull request: https://github.com/apache/flink/pull/2055 I think, everything should be ready now. Although while performing testing, I have found something that I think is not ideal. If we use this code: ```python

[GitHub] flink pull request: [FLINK-3993] [py] Add generateSequence() support to Pyth...

2016-05-31 Thread omaralvarez
Github user omaralvarez commented on the pull request: https://github.com/apache/flink/pull/2055 About the "frm", in Python when using from, there is a syntax error since from is a system reserved word. In the Java side of things there is no problem with renaming and using

[GitHub] flink pull request: [FLINK-3993] [py] Add generateSequence() support to Pyth...

2016-05-31 Thread omaralvarez
GitHub user omaralvarez opened a pull request: https://github.com/apache/flink/pull/2055 [FLINK-3993] [py] Add generateSequence() support to Python API Addition of generate_sequence to python API: `data = env.generate_sequence(1,20)` If a parallel number source was