Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-206352670
Adjusted the welcome message now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-205271252
I was following @StephanEwen 's suggestion above here:
> The Scala community seems to like brevity (senv vs. streamEnv).
---
If your project is set up for
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-205234801
@mxm rebased to master and added documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1412#discussion_r58094009
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala ---
@@ -124,7 +127,9 @@ class FlinkILoop
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-204038110
So since a lot has changed in the master I basically rewrote the whole
thing. Seems to work now.
What default imports should be included for the streaming API
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-184177781
@mxm @aljoscha i was on vacation for the last month, I'll continue working
on this now..
---
If your project is set up for it, you can reply to this email and have
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-166394233
Hey @mxm,
So I've tried to initialize the scala shell with one and two different
miniclusters and initialize the streaming and batch environment simultane
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-162843154
Ok, preferences here seem to be clear, I'll change it to make use of two
environments simultaneously in the shell then.
---
If your project is set up for it, yo
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-162534231
Hey @mxm, my survey among two people was inconclusive. I can see both
versions working, I'm more tending towards the version that is implemented now,
I might be
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1412#issuecomment-160659980
@rmetzger, thanks for the comments.
Changed the code accordingly, also I've extended the documentation for the
scala shell.
---
If your project is set up f
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1412#discussion_r46155833
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala
---
@@ -95,24 +140,49 @@ class FlinkILoop(
new
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1412#discussion_r46155052
--- Diff:
flink-staging/flink-scala-shell/src/main/java/org/apache/flink/api/java/ScalaShellRemoteStreamEnvironment.java
---
@@ -0,0 +1,155
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1412#discussion_r46154962
--- Diff: flink-staging/flink-scala-shell/pom.xml ---
@@ -84,6 +108,11 @@ under the License.
test
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/1412
[FLINK-2522] Adds streaming support for Flink-Scala-Shell
Adds streaming collect support for scala
You can merge this pull request into a Git repository by running:
$ git pull https
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146573493
@chiwanpark issues should be fixed NOW ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r41525031
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,8 +223,50 @@ class ScalaShellITSuite
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146568015
@chiwanpark issues should be fixed now..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146520283
@chiwanpark, white line issues are now fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-146507345
Hey @chiwanpark !
I've rebased this to the current master. Would be nice if this can be
merged soon if there are no further comments on this PR!
---
If
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1197#issuecomment-145510215
For me it says:
~~~bash
Failed to created JLineReader: java.lang.NoClassDefFoundError:
jline/console/completer/Completer
Falling back to SimpleReader
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1197#issuecomment-145509252
Code looks fine. However, I noticed if I compile the code (for scala
version 2.11), and start up the scala shell manually (./start-scala-shell.sh),
the autocomplete
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144688685
@tillrohrmann, I changed the code according to your comments. There should
be no null values anymore now ;)
---
If your project is set up for it, you can reply to this
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40898989
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144456895
@chiwanpark changed fail to give some reasons.
This is nicer indeed :+1:
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-17780
@chiwanpark, fixed the style issues.
`ScalaShellLocalStartupITCase` starts the shell in local mode (i.e. it will
create its own local cluster ) being invoked by the
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144345845
@chiwanpark can you check again ? It seems that if I squash both commits
the history isn't shown anymore.
If they are separated
~~~bash
gi
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144339801
@sachingoel0101 just did and I've merged the two commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-144337406
@chiwanpark I moved the files with git mv, however they still don't show
the history.
This seems to be more of a gui thing of github according to:
GitHub user nikste reopened a pull request:
https://github.com/apache/flink/pull/1106
[FLINK-2613] Print usage information for Scala Shell
changed startup of scala shell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikste
Github user nikste closed the pull request at:
https://github.com/apache/flink/pull/1106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141910091
@fhueske, good point to check if the program was actually executed!
@rmetzger fixed the directory structure as well.
---
If your project is set up for it, you can reply
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141066672
Should be fixed according to your comments @fhueske
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/1106
[FLINK-2613] Print usage information for Scala Shell
changed startup of scala shell
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikste/flink
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-136689479
Could someone please check this, it has been here for a while and I've got
some other stuff building on top of this!
---
If your project is set up for it, you can
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-125179652
The IT case now looks for a jar inside the ml-folder which does not contain
"test" or "original".
Thus the IT case should work for different flink
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-115180597
This did not work unfortunately, the class was available in the test, but
unfortunately not in the shell which is invoked in the test.
However, if you add the
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-112477088
Changed according to comments,
@tillrohrmann I did not check it on a cluster, since I don't have one
available at the moment. I checked with a local jobmanager (
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32508286
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -44,6 +46,16 @@ object FlinkShell
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32508271
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkILoop.scala
---
@@ -191,5 +203,14 @@ HINT: You can use print() on a
Github user nikste commented on a diff in the pull request:
https://github.com/apache/flink/pull/805#discussion_r32508276
--- Diff:
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
---
@@ -30,7 +31,8 @@ object FlinkShell
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-112041788
This should work now. It sends the jar alongside the compiled user-code to
the cluster.
---
If your project is set up for it, you can reply to this email and have your
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-110064581
You are right. I only tried it with the local execution environment. It
does not work if you start a separate job manager on your machine.
---
If your project is set up
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/805
[FLINK-2161] modified Scala shell start script to take additional argument
(-cp or --classpathâ¦
â¦) for external libraries
You can merge this pull request into a Git repository by running
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108823811
Changed to include the issue ID, 3..2..1 GO !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/768#issuecomment-108780565
Ok, removed the comments and the "Job execution switched to status
FINISHED." for all tests now (although, till now it only happened in the "add
numbers&qu
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/768
[FLINK-2126] Fixed Flink scala shell ITSuite sporadic failures
Add-numbers from 1..10 now does not check for "Job execution switched to
status FINISHED.", which sometimes was n
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105507840
I've rebased and cleaned up the commits. So this should be ready now.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-105279617
Should work. Yes `print()` was merged independently. I'll look at it and
clean up the commits tomorrow. I too would like to see it being merged ;)
---
If your proje
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/699
Eager print
Uses collect in print function now.
No need for calling execute() after print().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-103848414
Hey Fabian. The problem with putting it in the `flink-client` is that the
shell only works with Scala-2.10 and is not included for the Scala-2.11 build.
As far as I&#x
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-103638341
Fixed according to comments and linux terminal issue, should now pass all
tests.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/672#issuecomment-102086481
thanks for the comments Robert, I'll fix the stuff tomorrow!
Indeed, the Scala shell itself is not so much code, most of the changes are
caused by the chan
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/672
[FLINK-1907] Scala shell
implementation of Scala Shell, for Scala versions 2.10 and 2.11.
Also includes change to "eager" print()
You can merge this pull request into a Git repository
53 matches
Mail list logo
