Github user mliesenberg closed the pull request at:
https://github.com/apache/flink/pull/1625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1625#discussion_r57142933
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapred/HadoopOutputFormatTest.java
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1625#discussion_r57140858
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapred/HadoopOutputFormatTest.java
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1625#issuecomment-199878190
it's only the build job with with the `hadoop.profile=1` option. for the
others the tests are passing.
---
If your project is set up for it, you can reply to
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1625#issuecomment-199789577
I could not reproduce the issue locally, I rebased the PR onto the current
master and pushed that again.
Thankful for any pointers, the issue was the
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-199788556
thanks for the review, addressed the comment, squashed and rebased on master
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199710458
thanks. removed the regression, squashed and rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-194873275
build failed because all jobs failed the
`ClassLoaderITCase.testJobsWithCustomClassLoader` test.
I guess this is unrelated.
---
If your project is set up for
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1625#issuecomment-194871909
build failure because of
- [FLINK-1445](https://issues.apache.org/jira/browse/FLINK-1455) in [build
job](https://travis-ci.org/apache/flink/jobs/114046004
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-191670860
Thanks for the feedback, I will update the PR tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1729
FLINK-3529 Add template for pull requests
- added markdown as discussed on the mailing list
- added template to list of excluded files of rat plugin
You can merge this pull request into a
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-183291368
3 builds failed:
- one due to [FLINK-2719](https://issues.apache.org/jira/browse/FLINK-2719)
([log](https://s3.amazonaws.com/archive.travis-ci.org/jobs/108744342
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1628
[FLINK-2444] add tests for HadoopInputFormats
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mliesenberg/flink
FLINK-2444-input-format
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1625
[FLINK-2445] Add tests for HadoopOutputFormats
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mliesenberg/flink FLINK-2445-tests
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1486#issuecomment-182980098
sure, though I cant close it.
Found some things that can still be improved, will add that and open a PR
tonight.
---
If your project is set up for it, you can
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1486#issuecomment-182923108
As there has not been any activity since the beginning of the year, I
thought I'd address the comment in this PR. I wasnt able to push to the current
branch,
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158784004
ok. done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158766866
yep, based on the discussion above with fabian the default value is set
only on the long key.
I'll go ahead and set it on the short key as well, if no
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158761960
the build failure is due to a test in streaming, so most likely not related.
the test failure has been observed before and is captured in issue
FLINK-2348
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158345168
Oha. that is embarrassing, I thought I had it covered. I'll look into it.
Sorry for the mess.
---
If your project is set up for it, you can reply to this emai
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158329310
Cool. Pushed my latest changes which fix the bug and add more test cases.
Btw., is there any way to see a test coverage report?
---
If your project is
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-158164663
Oha. yes. Found the problem causing the exception, will fix it and make the
tests more specific as to which exceptions they need to catch.
While I am at it
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-157722421
cool. will update the PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-157719075
optional in the sense of, if the list is passed, then the missing arguments
are added to the help text in an extra paragraph at the end.
realized probably via
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-157713303
Sure, no problem.
One comment concerning the comment:
The `RequiredParametersException` could list the missing arguments.
At the moment the
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-157648517
thanks for the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r45173702
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-157648501
I'll address the comments and rework the getHelp method to produce more
useful output (and cover that with more tests).
---
If your project is set up for it
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r45173689
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/OptionType.java ---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r45173590
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/Option.java ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r45173470
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1367#issuecomment-157394443
several travis builds failed:
oraclejdk8 & hadoop 2.7: https://issues.apache.org/jira/browse/FLINK-2771
oraclejdk8 & hadoop 2.5: https://issues.ap
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1367
Fix JavaDoc of ElasticsearchSink
The JavaDoc references two constructors. The reference to the second
constructor was missing an argument. This commit adds the missing argument.
You can merge
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-152144589
Ok, should I rebase on the current master and squash the commits into one
before it will be merged?
---
If your project is set up for it, you can reply to this
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-151804263
Yes, that's right.
I'll address the comments tonight. If the `add(Option)` issue is blocking
the merge, we can just drop the function it, i
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r43241539
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r43241508
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-151439931
I do see your point about the uselessness of only `check`, so I'll go ahead
and implement `applyTo`.
I'll update the PR tonight.
---
If your
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r43100940
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r42943777
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r42943773
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-150490748
I think that might just boil down to the question whether or not there is a
common enough use case for one without the other.
If so, we could change it to one
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-142684451
The test failure seems unrelated to my changes. It's connected to the
YARNSessionFIFOITCase test.
FLINK-2700 has been opened a couple of days ago wit
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39933413
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39497481
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39496043
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-140348478
Ok, I will add that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-140347682
@fhueske Yes, I will add the checks.
Regarding the type checks: Does that refer to the interaction with the
ParameterTool class? I thought about that as
Github user mliesenberg commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39495024
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-138243384
OK, cool. I have created a separate ticket.
https://issues.apache.org/jira/browse/FLINK-2628
---
If your project is set up for it, you can reply to this email and
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-138189037
One of the builds failed because of a test failure in:
CoStreamCheckpointingITCase>StreamFaultToleranceTestBase.runCheckpointedProgram:105->postSubm
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1097
[FLINK-2017] Add predefined required parameters to ParameterTool
- adds Option class to represent required parameter
- adds RequiredParameter class to interact with ParameterTool to check
52 matches
Mail list logo
