[GitHub] flink pull request #3112: [FLINK-4988] [elasticsearch] Add Elasticsearch 5.x...

2017-01-28 Thread mikedias
Github user mikedias commented on a diff in the pull request: https://github.com/apache/flink/pull/3112#discussion_r98340529 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java

[GitHub] flink pull request #3112: [FLINK-4988] [elasticsearch] Add Elasticsearch 5.x...

2017-01-28 Thread mikedias
Github user mikedias commented on a diff in the pull request: https://github.com/apache/flink/pull/3112#discussion_r98340549 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java

[GitHub] flink pull request #3112: [FLINK-4988] [elasticsearch] Add Elasticsearch 5.x...

2017-01-28 Thread mikedias
Github user mikedias commented on a diff in the pull request: https://github.com/apache/flink/pull/3112#discussion_r98340492 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java

[GitHub] flink pull request #2767: [FLINK-4988] Elasticsearch 5.x support

2017-01-10 Thread mikedias
Github user mikedias commented on a diff in the pull request: https://github.com/apache/flink/pull/2767#discussion_r95480042 --- Diff: flink-connectors/flink-connector-elasticsearch5/src/main/java/org/apache/flink/streaming/connectors/elasticsearch5/ElasticsearchSink.java

[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support

2017-01-09 Thread mikedias
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 @tzulitai sure, no problem! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support

2016-12-19 Thread mikedias
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 I have no problem in hosting the connector in my github account. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support

2016-11-23 Thread mikedias
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 Not sure if I can exclude netty4 dependency, but I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink issue #2767: [FLINK-4988] Elasticsearch 5.x support

2016-11-23 Thread mikedias
Github user mikedias commented on the issue: https://github.com/apache/flink/pull/2767 No, ES is not backward compatible... But we can reuse some classes or interfaces between versions. I have plans to do this in another PR, just for isolate possible issues. --- If your project is

[GitHub] flink pull request #2767: [FLINK-4988] Elasticsearch 5.x support

2016-11-07 Thread mikedias
GitHub user mikedias opened a pull request: https://github.com/apache/flink/pull/2767 [FLINK-4988] Elasticsearch 5.x support Provides Elasticsearch 5.x support based on previous 2.x codebase. You can merge this pull request into a Git repository by running: $ git pull https