[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-09 Thread ktzoumas
Github user ktzoumas closed the pull request at: https://github.com/apache/flink/pull/1208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-08 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1208#issuecomment-146624231 Added docs for chaining and resource groups --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-08 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1208#issuecomment-146576052 @mbalassi: is the operator chaining currently documented somewhere? Same about partitioning between operators of different parallelism --- If your project is set up

[GitHub] flink pull request: [FLINK-2808] Rework state abstraction and clea...

2015-10-08 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1239#issuecomment-146490272 @senorcarbone I think the cyclic graphs feature will be hard to get into 0.10 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-08 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1208#issuecomment-146484570 Thanks a lot Fabian for the fantastic review! I addressed most of your comments. The state section needs to be rewritten after https://github.com/apache/flink/pull

[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-07 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1208#issuecomment-146203981 Once https://github.com/apache/flink/pull/1238 is merged, this is ready to be merged as well (the docs track the changes in that PR) --- If your project is set up for

[GitHub] flink pull request: Combination of Additions to the new Windowing ...

2015-10-07 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1238#issuecomment-146195362 +1 for merging this when tests are passing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-06 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1208#issuecomment-145936851 I addressed the comments above, added the content for Scala, reworked the iterations section, added content to the windows section, and made the DataStream API guide

[GitHub] flink pull request: Stream API Refactoring

2015-10-05 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/1215#issuecomment-145482079 +1 to merge. This will make the testing of the new API much easier --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: Stream API Refactoring

2015-10-05 Thread ktzoumas
Github user ktzoumas commented on a diff in the pull request: https://github.com/apache/flink/pull/1215#discussion_r41125467 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -87,7 +207,7

[GitHub] flink pull request: Stream API Refactoring

2015-10-05 Thread ktzoumas
Github user ktzoumas commented on a diff in the pull request: https://github.com/apache/flink/pull/1215#discussion_r41125422 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -24,49 +24,169

[GitHub] flink pull request: Stream API Refactoring

2015-10-05 Thread ktzoumas
Github user ktzoumas commented on a diff in the pull request: https://github.com/apache/flink/pull/1215#discussion_r41125302 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java --- @@ -81,56

[GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...

2015-10-01 Thread ktzoumas
GitHub user ktzoumas opened a pull request: https://github.com/apache/flink/pull/1208 [FLINK-2779][FLINK-2794][streaming][docs] New DataStream API programming guide Not good to merge. I am putting this up for discussion, but it depends on several pull requests that need

[GitHub] flink pull request: [docs] Change doc layout

2015-04-22 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-95174641 Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93837926 This is one of the best project documentations that I have seen. Thanks a lot Ufuk for doing this! I would merge this as is. Few minor thoughts I had when

[GitHub] flink pull request: [FLINK-1219] Add support for Apache Tez as exe...

2015-02-27 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/189#issuecomment-76407035 I tested this on a 25-node cluster with WordCount and the modified TPC-H query on generated TPC-H data of scale 1000. I also added docs. --- If your project is set up

[GitHub] flink pull request: [FLINK-1462] Gelly documentation

2015-02-24 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/430#issuecomment-75775383 Reads very very well. Big +1 as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70767467 I think Gelly has way more personality than flink-graph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well