[GitHub] flink issue #2138: [FLINK-3757] clarify JavaDoc for addAccumulator method

2016-06-20 Thread knaufk
Github user knaufk commented on the issue: https://github.com/apache/flink/pull/2138 What about: Add this accumulator. Throws an exception if the accumulator already exists in the *same* Task. Note that the namespace of Accumulators is scoped to the Flink Job, and adding

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-12 Thread knaufk
Github user knaufk commented on the pull request: https://github.com/apache/flink/pull/1979#issuecomment-218819781 I was worried about this to and intially only added the method to the AbstractRuntimeUDFContext. On the other hand, are you aware of anyone who has implemented

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-12 Thread knaufk
Github user knaufk commented on the pull request: https://github.com/apache/flink/pull/1979#issuecomment-218815109 Hopefully, fixed the formatting stuff. If there are still missing lines or so, please just go ahead and fix it during merging... --- If your project is set up for it

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-10 Thread knaufk
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3758] Add possibility to register accum...

2016-05-10 Thread knaufk
GitHub user knaufk reopened a pull request: https://github.com/apache/flink/pull/1979 [FLINK-3758] Add possibility to register accumulators in custom triggers Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request: [Flink 3758] Add possibility to register accum...

2016-05-10 Thread knaufk
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1979 [Flink 3758] Add possibility to register accumulators in custom triggers 1 of 1 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request: Timer coalescing across keys and cleanup of un...

2016-04-28 Thread knaufk
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Timer coalescing across keys and cleanup of un...

2016-04-28 Thread knaufk
GitHub user knaufk reopened a pull request: https://github.com/apache/flink/pull/1944 Timer coalescing across keys and cleanup of unused trigger tasks Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: Timer coalescing across keys and cleanup of un...

2016-04-28 Thread knaufk
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1944 Timer coalescing across keys and cleanup of unused trigger tasks Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...

2016-04-08 Thread knaufk
Github user knaufk closed the pull request at: https://github.com/apache/flink/pull/1861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3688] WindowOperator.trigger() does not...

2016-04-07 Thread knaufk
GitHub user knaufk opened a pull request: https://github.com/apache/flink/pull/1861 [FLINK-3688] WindowOperator.trigger() does not emit Watermark anymore Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into