[GitHub] flink pull request: Trivial WriteMode comment fix

2015-12-23 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1475 Trivial WriteMode comment fix WriteMode has 2 values NO_OVERWRITE and OVERWRITE but it refers CREATE in the javadoc. Probably old code. You can merge this pull request into a Git repository by

[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator

2015-12-09 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1444#issuecomment-163438135 The travis error is in streaming-java, but my change was made in core and optimizer ``` [INFO] flink-runtime-web .. SUCCESS

[GitHub] flink pull request: [FLINK-3116] Remove RecordOperator

2015-12-08 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1444 [FLINK-3116] Remove RecordOperator You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaoki/flink Remove-RecordOperator-FLINK-3116 Alternatively

[GitHub] flink pull request: [contrib, connector-wikiedits] Add WikipediaEd...

2015-12-08 Thread jaoki
Github user jaoki commented on a diff in the pull request: https://github.com/apache/flink/pull/1439#discussion_r46926616 --- Diff: flink-contrib/flink-connector-wikiedits/pom.xml --- @@ -0,0 +1,50 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] flink pull request: [contrib, connector-wikiedits] Add WikipediaEd...

2015-12-08 Thread jaoki
Github user jaoki commented on a diff in the pull request: https://github.com/apache/flink/pull/1439#discussion_r46924797 --- Diff: flink-contrib/flink-connector-wikiedits/pom.xml --- @@ -0,0 +1,50 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

2015-12-07 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1436#issuecomment-162690732 @fhueske , I'm glad to make myself a bit useful to the project. :) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] flink pull request: [FLINK-3055] remove getSubTaskIndex()

2015-12-04 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1438 [FLINK-3055] remove getSubTaskIndex() You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaoki/flink get-rid-of-one-of-subTaskIndex-getter

[GitHub] flink pull request: JobManager Data Structure doc fix

2015-12-01 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1430 JobManager Data Structure doc fix It seems AbstractJobVertex class no longer exists but the doc's link still points to it. You can merge this pull request into a Git repository by ru

[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...

2015-11-24 Thread jaoki
Github user jaoki commented on a diff in the pull request: https://github.com/apache/flink/pull/1392#discussion_r45792220 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1343,10 +1343,34 @@ public long count() throws Exception

[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...

2015-11-24 Thread jaoki
Github user jaoki commented on a diff in the pull request: https://github.com/apache/flink/pull/1392#discussion_r45791866 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1343,10 +1343,34 @@ public long count() throws Exception

[GitHub] flink pull request: [FLINK-3059] Javadoc fix for DataSet.writeAsTe...

2015-11-22 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1392 [FLINK-3059] Javadoc fix for DataSet.writeAsText() Currently writeAsText() in javadoc states it simply generates a file, but this is not always true and it depends on the environment configuration

[GitHub] flink pull request: [FLINK-3009] Add dockerized jekyll environment

2015-11-19 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1363#issuecomment-158213589 Does anyone want to commit this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-3009] Add dockerized jekyll environment

2015-11-17 Thread jaoki
Github user jaoki commented on a diff in the pull request: https://github.com/apache/flink/pull/1363#discussion_r45124787 --- Diff: docs/docker/run.sh --- @@ -0,0 +1,74 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] flink pull request: [FLINK-3009] Add dockerized jekyll environment

2015-11-17 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1363 [FLINK-3009] Add dockerized jekyll environment This is not to fulfill what FLINK-3009 is originally asking, but I'm piggybacking to contribute a docker environment with jekyll so that

[GitHub] flink pull request: minor javadoc fix in JobManager

2015-11-16 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1358#issuecomment-157143864 @mxm for sure will send to the community once it is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: minor jvadoc fix in JobManager

2015-11-16 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1358 minor jvadoc fix in JobManager JobExecutionVertices should be ExecutionJobVertices? I found it while I have been drawing a Flink local execution diagram. It is still a half way but let me know

[GitHub] flink pull request: [FLINK-3012] Refactor boilerplate code in Data...

2015-11-15 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1355#issuecomment-156946307 Thank you for your input. @zentol ! Withdrawing PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3012] Refactor boilerplate code in Data...

2015-11-15 Thread jaoki
Github user jaoki closed the pull request at: https://github.com/apache/flink/pull/1355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3012] Refactor boilerplate code in Data...

2015-11-15 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1355#issuecomment-156867821 @StephanEwen , thank you for your feedback. Looping with an int variable is clearly wrong in Flink's use case, and I can change to long, but, I'd like to he

[GitHub] flink pull request: [FLINK-3012] Refactor boilerplate code in Data...

2015-11-15 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1355 [FLINK-3012] Refactor boilerplate code in DataSourceTask Refactor repetitive and boilerplate code of while and if statements in DataSourceTask The previous if and else nest and to control the

[GitHub] flink pull request: minor document fix.

2015-11-10 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1325#issuecomment-155670336 @mjsax The build failure seems irrelevant from my small contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: minor document fix.

2015-11-09 Thread jaoki
Github user jaoki commented on the pull request: https://github.com/apache/flink/pull/1325#issuecomment-155260404 @mjsax thank you for paying attention for such a trivial topic :) Will fix it shortly. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: minor document fix.

2015-11-03 Thread jaoki
GitHub user jaoki opened a pull request: https://github.com/apache/flink/pull/1325 minor document fix. Regarding example WordCount class name. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaoki/flink minor-example-class-name