[
https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092438#comment-16092438
]
hongyuhong commented on FLINK-6233:
---
Hi [~fhueske], [~xccui] is now working on
[
https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hongyuhong reassigned FLINK-6233:
-
Assignee: Xingcan Cui (was: hongyuhong)
> Support rowtime inner equi-join between two stre
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/4324
Hi @fhueske, sorry for the late feedback. The refactoring looks pretty
great to me, i think it's good to be merged. The only thing i worry about is
that there is no enough message for the us
Github user hongyuhong closed the pull request at:
https://github.com/apache/flink/pull/4266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hongyuhong closed the pull request at:
https://github.com/apache/flink/pull/3715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125807639
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala
---
@@ -20,28 +20,60
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske, thanks for the reviewing, i have update the pr here for
reviewing, and also create a new pr https://github.com/apache/flink/issues/4266
to merge the commit, once you finish reviewing
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/4266
Hi @wuchong, thanks for the reminding. There still have some modify in the
new commit, so i want to reserve the older commit for easy reviewing, after the
reviewing finish, i will close the pr
GitHub user hongyuhong opened a pull request:
https://github.com/apache/flink/pull/4266
[FLINK-6232][Table&Sql] support proctime inner windowed stream join
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske, sorry for late reply, i have update the pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125205215
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -0,0 +1,385 @@
+/*
+ * Licensed
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125203460
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinTest.scala
---
@@ -0,0 +1,149
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125203253
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,316
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125203271
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,316
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125202985
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -0,0 +1,385 @@
+/*
+ * Licensed
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r125202807
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -0,0 +1,385 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039959#comment-16039959
]
hongyuhong commented on FLINK-6858:
---
Hi [~fhueske], the implemention of unbounded e
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @rtudoran @fhueske, i have update the pr with the latest interface,
thanks for the reviewing.
Thanks very much.
Yuhong
---
If your project is set up for it, you can reply to this
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske , i have update a version :).
1. As for how to specify the join case is a stream and stream join,
currently i check through there exist time indicator but not exist such as
tumble
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117176330
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,69
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117170779
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -0,0 +1,488 @@
+/*
+ * Licensed
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske, Thanks for your reminding, i'm sorry that i forgot to ping
you. I thought a PR could have only one commit, so i squash them to one, i will
notice that.
Thanks very
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116416819
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske , Thanks very much for the review! I have update the pr use
JoinFunction instead of FilterFunction, and i will add more test later.
Thanks very much.
Yuhong
---
If your
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r115919578
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r115919570
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r115919604
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003957#comment-16003957
]
hongyuhong commented on FLINK-6232:
---
Hi [~fhueske], I have merge the flink-5884
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973982#comment-15973982
]
hongyuhong commented on FLINK-6232:
---
Hi [~fhueske] i have implement it use no
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112103318
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112105029
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112105763
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -1140,6 +1140,202 @@ class
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112105507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238
GitHub user hongyuhong opened a pull request:
https://github.com/apache/flink/pull/3715
[FLINK-6232][Table&SQL]Support proctime inner equi-join between two sâ¦
â¦treams in sql api
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962727#comment-15962727
]
hongyuhong commented on FLINK-6232:
---
Hi [~fhueske], I have made a prelimi
[
https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960505#comment-15960505
]
hongyuhong commented on FLINK-6233:
---
Hi [~fhueske], the reason i think we need to
[
https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960223#comment-15960223
]
hongyuhong commented on FLINK-6233:
---
Hi [~fhueske], i would deal with the out-of-o
hongyuhong created FLINK-6233:
-
Summary: Support rowtime inner equi-join between two streams in
the SQL API
Key: FLINK-6233
URL: https://issues.apache.org/jira/browse/FLINK-6233
Project: Flink
hongyuhong created FLINK-6232:
-
Summary: Support proctime inner equi-join between two streams in
the SQL API
Key: FLINK-6232
URL: https://issues.apache.org/jira/browse/FLINK-6232
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950486#comment-15950486
]
hongyuhong commented on FLINK-5725:
---
Hi [~fhueske], thanks for your feedback. I a
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3649#discussion_r109072158
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -204,21
[
https://issues.apache.org/jira/browse/FLINK-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948826#comment-15948826
]
hongyuhong commented on FLINK-6200:
---
Hi [~sunjincheng121] thanks very much
[
https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948628#comment-15948628
]
hongyuhong commented on FLINK-6204:
---
Hi [~fhueske], agree +1
> Improve Event-Ti
[
https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948570#comment-15948570
]
hongyuhong commented on FLINK-6204:
---
Hi [~sunjincheng121], i agree with you tha
GitHub user hongyuhong opened a pull request:
https://github.com/apache/flink/pull/3649
[FLINK-6200][SQL] support unbounded event time range window
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
[
https://issues.apache.org/jira/browse/FLINK-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948273#comment-15948273
]
hongyuhong commented on FLINK-6200:
---
Hi [~sunjincheng121] i have implemented it b
[
https://issues.apache.org/jira/browse/FLINK-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946417#comment-15946417
]
hongyuhong commented on FLINK-6082:
---
Hi [~fhueske], i think what radu means about u
[
https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944998#comment-15944998
]
hongyuhong commented on FLINK-6204:
---
I think the memory of 'sortedTimestamp
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r108026230
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -112,7 +113,12
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3386
Thanks, @fhueske, i have fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3386
Hi, @fhueske , i have updated the pr. Thanks very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r107597005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r107584162
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r107583714
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +320,193 @@ class
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3386
Hi @fhueske , @shijinkui & @sunjincheng121 , i have updated the pr
according to your advices. Thanks very much.
---
If your project is set up for it, you can reply to this email and have
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106774581
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3386
Hi @fhueske @sunjincheng121 @rtudoran @shijinkui , i have update the pr,
hope you can take a look. Thanks advance.
---
If your project is set up for it, you can reply to this email and have your
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106396314
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106395452
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106373065
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106324953
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3386
Hi @sunjincheng121, thanks very much for your suggestion, i have update the
pr.
Best,
Hongyuhong
---
If your project is set up for it, you can reply to this email and have your
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r105337481
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventtimeOverProcessFunction.scala
---
@@ -0,0
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3386
I have rebase and update the pr, appreciate if you can have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hongyuhong closed the pull request at:
https://github.com/apache/flink/pull/3175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103835080
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeRowAggregate.java
---
@@ -0,0 +1,160
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103835059
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/logical/rel/util/WindowAggregateUtil.java
---
@@ -0,0 +1,103
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103835113
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java
---
@@ -0,0
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r103835088
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r103125615
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala
---
@@ -0,0
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102652877
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -52,9
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102652936
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/GlobalEventTimeRowWindowAssigner.java
---
@@ -0,0 +1,113
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102652926
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -171,4 +175,98 @@ class
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102652914
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -171,4 +175,98 @@ class
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102650085
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala
---
@@ -0,0
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102649307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala
---
@@ -0,0
GitHub user hongyuhong opened a pull request:
https://github.com/apache/flink/pull/3386
[FLINK-5658][table] support unbounded eventtime over window
1. Add LogicalOverWindow extends calcite Window with attribute isEventtime
2. Add LogicalWindowRule to convert calcite
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3175
Hi, @wuchong, @sunjincheng121 ,
Thank you very much for correcting my mistake!I will study deeply and
modify the code. The pr temporarily only consider the processing-time and
preceding
GitHub user hongyuhong opened a pull request:
https://github.com/apache/flink/pull/3175
[FLINK-5584]support sliding-count row-window on streaming sql
Calcite has already support sliding-count row-window, the grammar look like:
select sum(amount) over (rows 10 preceding) from
79 matches
Mail list logo
