[jira] [Commented] (FLINK-24456) Support bounded offset in the Kafka table connector

2021-12-20 Thread Haohui Mai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462498#comment-17462498 ] Haohui Mai commented on FLINK-24456: IMO anything on-par with the current table

[jira] [Commented] (FLINK-24456) Support bounded offset in the Kafka table connector

2021-11-13 Thread Haohui Mai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443250#comment-17443250 ] Haohui Mai commented on FLINK-24456: It just needs to be on par with the datast

[jira] [Created] (FLINK-24485) COUNT(DISTINCT) should support binary field

2021-10-08 Thread Haohui Mai (Jira)
Haohui Mai created FLINK-24485: -- Summary: COUNT(DISTINCT) should support binary field Key: FLINK-24485 URL: https://issues.apache.org/jira/browse/FLINK-24485 Project: Flink Issue Type

[jira] [Commented] (FLINK-24456) Support bounded offset in the Kafka table connector

2021-10-08 Thread Haohui Mai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426117#comment-17426117 ] Haohui Mai commented on FLINK-24456: [~MartijnVisser] feel free to take it for

[jira] [Created] (FLINK-24456) Support bounded offset in the Kafka table connector

2021-10-05 Thread Haohui Mai (Jira)
Haohui Mai created FLINK-24456: -- Summary: Support bounded offset in the Kafka table connector Key: FLINK-24456 URL: https://issues.apache.org/jira/browse/FLINK-24456 Project: Flink Issue Type

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2017-12-19 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296435#comment-16296435 ] Haohui Mai commented on FLINK-8240: --- It seems that it is a great use case of lay

[jira] [Commented] (FLINK-7980) Bump joda-time to 2.9.9

2017-11-08 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245232#comment-16245232 ] Haohui Mai commented on FLINK-7980: --- IMO it is a better idea to get rid of joda-tim

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-23 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215758#comment-16215758 ] Haohui Mai commented on FLINK-7548: --- Sorry for the late response. The APIs should

[GitHub] flink pull request #4873: [FLINK-7051] [table] Bump Calcite version to 1.14.

2017-10-20 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/4873 [FLINK-7051] [table] Bump Calcite version to 1.14. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your

[jira] [Commented] (FLINK-7051) Bump up Calcite version to 1.14

2017-10-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205312#comment-16205312 ] Haohui Mai commented on FLINK-7051: --- I plan to work on it this week to make sur

[jira] [Closed] (FLINK-6569) flink-table KafkaJsonTableSource example doesn't work

2017-10-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai closed FLINK-6569. - Resolution: Invalid Fix Version/s: (was: 1.4.0) > flink-table KafkaJsonTableSource exam

[jira] [Created] (FLINK-7787) Remove guava dependency in the cassandra connector

2017-10-09 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7787: - Summary: Remove guava dependency in the cassandra connector Key: FLINK-7787 URL: https://issues.apache.org/jira/browse/FLINK-7787 Project: Flink Issue Type: Bug

[GitHub] flink issue #3748: [FLINK-6225] [Cassandra Connector] add CassandraTableSink

2017-10-09 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3748 Given we have dropped the support for Java 7, it might make sense to just rewrite the class to use the completablefuture in java 8. ---

[GitHub] flink pull request #4784: FLINK-7736: fix some lgtm.com alerts

2017-10-08 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4784#discussion_r143363777 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java --- @@ -448,7 +448,7 @@ public boolean addTask(Task task

[GitHub] flink pull request #4784: FLINK-7736: fix some lgtm.com alerts

2017-10-08 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4784#discussion_r143363797 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/history/ArchivedJson.java --- @@ -55,6 +57,13 @@ public boolean equals(Object obj

[GitHub] flink pull request #4784: FLINK-7736: fix some lgtm.com alerts

2017-10-08 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4784#discussion_r143363755 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/Utils.java --- @@ -53,7 +53,7 @@ public static String getCallLocationName() { public

[GitHub] flink pull request #4784: FLINK-7736: fix some lgtm.com alerts

2017-10-08 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4784#discussion_r143363766 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/GroupReduceNode.java --- @@ -97,7 +97,7 @@ else if

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

2017-10-07 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/4748 +1 It's very rare to see people using SerialGC in production environment. Running the tests using SerialGC seems bringing in little values. ---

[jira] [Created] (FLINK-7743) Remove the restriction of minimum memory of JM

2017-09-30 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7743: - Summary: Remove the restriction of minimum memory of JM Key: FLINK-7743 URL: https://issues.apache.org/jira/browse/FLINK-7743 Project: Flink Issue Type: Bug

[GitHub] flink pull request #4556: [FLINK-6465][table]support FIRST_VALUE on Table AP...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4556#discussion_r140824914 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1406,6 +1406,61 @@ object

[GitHub] flink pull request #4556: [FLINK-6465][table]support FIRST_VALUE on Table AP...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4556#discussion_r140824819 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/FirstValueAggFunctionWithRetract.scala --- @@ -0,0 +1,129

[GitHub] flink pull request #4556: [FLINK-6465][table]support FIRST_VALUE on Table AP...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4556#discussion_r140823719 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/FirstValueAggFunction.scala --- @@ -0,0 +1,107

[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...

2017-09-25 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/4679 LGTM ---

[GitHub] flink issue #4679: [hotfix] [doc] Fix typo for s3a config in AWS deployment ...

2017-09-25 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/4679 The configuration will lead you to use the old s3 filesystem instead of the s3a filesystem. See https://wiki.apache.org/hadoop/AmazonS3 for more details. ---

[GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4544#discussion_r140703450 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -269,6 +272,10 @@ class FlinkTypeFactory

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4128#discussion_r140702758 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala --- @@ -33,6 +33,14 @@ object

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4128#discussion_r140702856 --- Diff: docs/dev/table/sql.md --- @@ -1691,7 +1691,7 @@ INITCAP(string) -{% highlight text %} --- End diff

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4128#discussion_r140702779 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -414,6 +415,11 @@ object

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697199 --- Diff: flink-connectors/flink-orc/pom.xml --- @@ -0,0 +1,152 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699375 --- Diff: flink-connectors/flink-orc/pom.xml --- @@ -0,0 +1,152 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140698526 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697150 --- Diff: flink-connectors/flink-orc/pom.xml --- @@ -0,0 +1,152 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699402 --- Diff: flink-connectors/flink-orc/pom.xml --- @@ -0,0 +1,152 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699453 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140698436 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697285 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699592 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699826 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140700434 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcUtils.java --- @@ -0,0 +1,2229 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699131 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcUtils.java --- @@ -0,0 +1,2229 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140700095 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697648 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140698914 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcUtils.java --- @@ -0,0 +1,2229 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140700317 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcUtils.java --- @@ -0,0 +1,2229 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697889 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140698040 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140698379 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699738 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699577 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699511 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697494 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140697367 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699558 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-25 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r140699619 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/RowOrcInputFormat.java --- @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-24 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4683#discussion_r140696992 --- Diff: flink-core/pom.xml --- @@ -52,6 +52,12 @@ under the License. flink-shaded-asm

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-24 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4683#discussion_r140649772 --- Diff: flink-core/pom.xml --- @@ -52,6 +52,12 @@ under the License. flink-shaded-asm

[GitHub] flink issue #4710: [FLINK-7446] [table] Change DefinedRowtimeAttribute to wo...

2017-09-24 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/4710 LGTM overall +1. One question: since we now cast `ROWTIME` / `PROCTIME` directly to `LONG`, I wonder, do we want to revisit the decision that creates dedicated types for `ROWTIME

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-19 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139629938 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-19 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139625581 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-18 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139553991 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-18 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139532226 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-08 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r137913506 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-07 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r137671151 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8 +240,191

[jira] [Commented] (FLINK-7594) Add a SQL CLI client

2017-09-06 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156221#comment-16156221 ] Haohui Mai commented on FLINK-7594: --- We internally has a project (AthenaX) for

[jira] [Commented] (FLINK-6563) Expose time indicator attributes in the KafkaTableSource

2017-09-05 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154348#comment-16154348 ] Haohui Mai commented on FLINK-6563: --- Thanks for the PR. I'll take a look

[GitHub] flink pull request #4576: [FLINK-7398] Table API operators/UDFs must not sto...

2017-08-23 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/4576 [FLINK-7398] Table API operators/UDFs must not store Logger. This PR moves all the usages of {{slf4j.Logger}} to a common trait so that we can ensure the Logger object is not serialized over the

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-21 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136280#comment-16136280 ] Haohui Mai commented on FLINK-7398: --- +1 on logging trait. I'll submit a PR.

[jira] [Commented] (FLINK-6692) The flink-dist jar contains unshaded netty jar

2017-08-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125856#comment-16125856 ] Haohui Mai commented on FLINK-6692: --- Sounds good. Thanks for the effort! > Th

[jira] [Resolved] (FLINK-6692) The flink-dist jar contains unshaded netty jar

2017-08-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai resolved FLINK-6692. --- Resolution: Fixed > The flink-dist jar contains unshaded netty

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121265#comment-16121265 ] Haohui Mai commented on FLINK-7398: --- Putting in a companion object is an viable op

[GitHub] flink issue #3712: [FLINK-6281] Create TableSink for JDBC.

2017-08-09 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3712 Thanks @fhueske ! Updated the PR to address the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-09 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120536#comment-16120536 ] Haohui Mai commented on FLINK-7398: --- Good catch! I think we can fix it for once

[jira] [Assigned] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-09 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai reassigned FLINK-7398: - Assignee: Haohui Mai > Table API operators/UDFs must not store Log

[jira] [Commented] (FLINK-7357) HOP_START() HOP_END() does not work when using HAVING clause with GROUP BY HOP window

2017-08-09 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120511#comment-16120511 ] Haohui Mai commented on FLINK-7357: --- I haven't started yet. Please

[GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.

2017-08-08 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/3712#discussion_r132022891 --- Diff: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCAppendTableSink.java --- @@ -0,0 +1,85 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-7159) Semantics of OVERLAPS in Table API diverge from the SQL standard

2017-08-08 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai resolved FLINK-7159. --- Resolution: Fixed This has been resolved as a part of FLINK-6429. > Semantics of OVERLAPS in Ta

[jira] [Assigned] (FLINK-7051) Bump up Calcite version to 1.14

2017-08-08 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai reassigned FLINK-7051: - Assignee: Haohui Mai > Bump up Calcite version to 1

[jira] [Created] (FLINK-7392) Enable more predicate push-down in joins

2017-08-08 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7392: - Summary: Enable more predicate push-down in joins Key: FLINK-7392 URL: https://issues.apache.org/jira/browse/FLINK-7392 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-08-07 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117500#comment-16117500 ] Haohui Mai commented on FLINK-6429: --- bq. In order to change the default behavior of

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-08-07 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117328#comment-16117328 ] Haohui Mai commented on FLINK-6429: --- It's difficult to say this is a pure Ca

[jira] [Assigned] (FLINK-7357) HOP_START() HOP_END() does not work when using HAVING clause with GROUP BY HOP window

2017-08-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai reassigned FLINK-7357: - Assignee: Haohui Mai > HOP_START() HOP_END() does not work when using HAVING clause with GR

[jira] [Created] (FLINK-7344) Migrate usage of joda-time to the Java 8 DateTime API

2017-08-02 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7344: - Summary: Migrate usage of joda-time to the Java 8 DateTime API Key: FLINK-7344 URL: https://issues.apache.org/jira/browse/FLINK-7344 Project: Flink Issue Type

[GitHub] flink issue #4373: [FLINK-6429] [table] Bump up Calcite version to 1.13.

2017-08-01 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/4373 @dianfu thanks for the investigation! It turns out that it no longer requires copying {{PushProjector}} after rebasing to the latest tip. Updated the PR to address the issue. --- If your project is

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-08-01 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r130794757 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -355,26 +355,36 @@ case class TemporalOverlaps

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-08-01 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r130789743 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/CorrelateTest.scala --- @@ -43,7 +43,7 @@ class CorrelateTest

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-08-01 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r130789546 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java --- @@ -1039,7 +1039,7 @@ public boolean

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-07-19 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/4373 [FLINK-6429] [table] Bump up Calcite version to 1.13. This PR bumps upgrades Calcite from 1.12 to 1.13. It includes fixes for CALCITE-1884 and FLINK-7159. We can probably separate it to smaller PR

[jira] [Created] (FLINK-7237) Remove DateTimeUtils from Flink once Calcite is upgraded to 1.14

2017-07-19 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7237: - Summary: Remove DateTimeUtils from Flink once Calcite is upgraded to 1.14 Key: FLINK-7237 URL: https://issues.apache.org/jira/browse/FLINK-7237 Project: Flink

[jira] [Created] (FLINK-7236) Bump up the Calcite version to 1.14

2017-07-19 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7236: - Summary: Bump up the Calcite version to 1.14 Key: FLINK-7236 URL: https://issues.apache.org/jira/browse/FLINK-7236 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-7235) Backport CALCITE-1884 to the Flink repository before Calcite 1.14

2017-07-19 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7235: - Summary: Backport CALCITE-1884 to the Flink repository before Calcite 1.14 Key: FLINK-7235 URL: https://issues.apache.org/jira/browse/FLINK-7235 Project: Flink

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091283#comment-16091283 ] Haohui Mai commented on FLINK-6429: --- Sorry for the delay. There are several issues

[jira] [Assigned] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai reassigned FLINK-6429: - Assignee: Haohui Mai (was: Timo Walther) > Bump up Calcite version to 1

[GitHub] flink pull request #4078: [FLINK-6693] [table] Support DATE_FORMAT function ...

2017-07-11 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4078#discussion_r126870195 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -110,6 +110,11 @@ under the License. compile

[GitHub] flink pull request #4078: [FLINK-6693] [table] Support DATE_FORMAT function ...

2017-07-11 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/4078#discussion_r126870280 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -2008,6 +2008,33 @@ class CodeGenerator

[jira] [Created] (FLINK-7159) Semantics of OVERLAPS in Table API diverge from the SQL standard

2017-07-11 Thread Haohui Mai (JIRA)
Haohui Mai created FLINK-7159: - Summary: Semantics of OVERLAPS in Table API diverge from the SQL standard Key: FLINK-7159 URL: https://issues.apache.org/jira/browse/FLINK-7159 Project: Flink

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083277#comment-16083277 ] Haohui Mai commented on FLINK-6429: --- [~twalthr] that would be great. I found a

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081820#comment-16081820 ] Haohui Mai commented on FLINK-6429: --- I have a patch and will upload it shortly. &g

[GitHub] flink issue #4078: [FLINK-6693] [table] Support DATE_FORMAT function in the ...

2017-07-10 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/4078 @fhueske @twalthr please take another look. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3712: [FLINK-6281] Create TableSink for JDBC.

2017-06-20 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3712 It is important to have some flexibility on the query as different SQL engines have slightly different syntax on DML. For example, SQLite supports INSERT OVERWRITE where MySQL supports

[jira] [Closed] (FLINK-6568) flink-table doesn't work without flink-streaming-scala dependency

2017-06-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai closed FLINK-6568. - Resolution: Duplicate > flink-table doesn't work without flink-streaming-scala de

  1   2   3   >