[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2017-09-06 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/4649 [FLINK-6116] Watermarks don't work when unioning with same DataStream. ## What is the purpose of the change In self-union case, the stream edges between the source and target wi

[GitHub] flink issue #3898: [FLINK-6492] Fix unclosed DataOutputViewStream usage

2017-05-18 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3898 Hi, @huafengw . Welcome to Flink family. Thanks for your PR and the changes look good to me. :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #3788: [FLINK-6393] [gelly] Add Evenly Graph Generator to Flink ...

2017-04-27 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3788 @fanzhidongyzby , thanks for the pr. Just a minor comment, mostly looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3788: [FLINK-6393] [gelly] Add Evenly Graph Generator to...

2017-04-27 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/3788#discussion_r113842976 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/EvenlyGraph.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-05 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3110 @fhueske @twalthr . Can you help with reviewing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3121: [FLINK-5434] Remove unsupported project() transfor...

2017-01-18 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/3121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3121: [FLINK-5434] Remove unsupported project() transfor...

2017-01-13 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/3121 [FLINK-5434] Remove unsupported project() transformation from Scala DataStream docs. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check

[GitHub] flink pull request #3110: [FLINK-2184] Cannot get last element with maxBy/mi...

2017-01-12 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/3110 [FLINK-2184] Cannot get last element with maxBy/minBy. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[GitHub] flink pull request #1975: [FLINK-2184] Cannot get last element with maxBy/mi...

2017-01-12 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1975 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2282: [FLINK-3940] [table] Add support for ORDER BY OFFSET FETC...

2016-08-04 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2282 @twalthr PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-03 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73452976 --- Diff: docs/apis/table.md --- @@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc"); + +

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73287941 --- Diff: docs/apis/table.md --- @@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc"); + +

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73272805 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[GitHub] flink issue #2303: [FLINK-4248] [core] [table] CsvTableSource does not suppo...

2016-07-27 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2303 Hi @twalthr , the logical of parserFields method in Date/Time/TimeStamp (also in the lastest PR for BigDecimal/BigInteger) is same, is it better to refactor by creating super class for them to

[GitHub] flink issue #2290: [FLINK-4242] [table] Improve validation exception message...

2016-07-27 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2290 Will update later to include the issue of [flink-4241](https://issues.apache.org/jira/browse/FLINK-4241) . --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2291: [FLINK-4226] Typo: Define Keys using Field Expressions ex...

2016-07-24 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2291 Hi @nssalian , welcome to join the community. :) This PR may be duplicate to [#2261](https://github.com/apache/flink/pull/2261) for the same issue. --- If your project is set up for it

[GitHub] flink pull request #2290: [FLINK-4242] [table] Improve validation exception ...

2016-07-23 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2290 [FLINK-4242] [table] Improve validation exception messages Improve validation exception messages in table api. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink issue #2282: [FLINK-3940] [table] Add support for ORDER BY OFFSET FETC...

2016-07-23 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2282 @wuchong thanks for your advice and i have addressed your comments in the new commit. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #2282: Support order by with offset and fetch.

2016-07-21 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2282 Support order by with offset and fetch. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-10 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 Conflict resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-03 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 Hi @wuchong , thanks a lot for your advice. With default fieldnames may cause same content of `input1` and `input2` in `CodeGenerator`. Comparing the `inputTerm` is a easy and effective way to

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-02 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 @fhueske the failure of CI build is relevant with `testJoinWithDisjunctivePred` in `JoinITCase`. The case is `val joinT = ds1.join(ds2).filter('a === 'd && ('b === '

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-01 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 Hi, @fhueske , sorry for the late update for this PR. Codes have been modified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-29 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2179 This problem appears occasionally when i build source code, but not always. The modified line corrects the right directory of `.git`. In the case where maven using the plugin, this fix is

[GitHub] flink issue #2049: [FLINK-3971] [tableAPI] Aggregates handle null values inc...

2016-06-13 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2049 @fhueske Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #2049: [FLINK-3971] [tableAPI] Aggregates handle null values inc...

2016-06-13 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2049 @fhueske fixed! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2049: [FLINK-3971] [tableAPI] Aggregates handle null val...

2016-06-13 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2049#discussion_r66765029 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MaxAggregate.scala --- @@ -48,8 +57,16 @@ abstract

[GitHub] flink issue #2049: [FLINK-3971] [tableAPI] Aggregates handle null values inc...

2016-06-13 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2049 @fhueske sorry for the late update. Codes have been modified based on your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-06-06 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 @twalthr @fhueske can you help with reviewing this PR? Thanks! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2078: [FLINK-2985] Allow different field names for union...

2016-06-06 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2078 [FLINK-2985] Allow different field names for unionAll() in Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #2074: [FLINK-2985] [Table API] Allow different field nam...

2016-06-06 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/2074 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2074: [FLINK-2985] [Table API] Allow different field names for ...

2016-06-06 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2074 @twalthr @fhueske Can you help with review work? Thanks. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2074: [FLINK-2985] [Table API] Allow different field nam...

2016-06-06 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2074 [FLINK-2985] [Table API] Allow different field names for unionAll() in Table API. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check

[GitHub] flink pull request: [FLINK-3971] [tableAPI] Aggregates handle null...

2016-05-31 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/2049#issuecomment-222633219 @fhueske I have changed the return type to generic `T` in `AvgAggregation` class because when return `null.asInstanceof[Short/Int/..]` , the value can convert to `0

[GitHub] flink pull request: [FLINK-3971] [tableAPI] Aggregates handle null...

2016-05-30 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2049 [FLINK-3971] [tableAPI] Aggregates handle null values incorrectly. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-25 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-221616393 @vasia In the travis failure reports, the failures are relevant with flink-yarn-tests module. I have merged the latest code from master and rebase all my commit in

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-25 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-221606502 @vasia wait for minutes and i will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-24 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-221452144 @vasia fixed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-21 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r64144375 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -273,4 +289,23 @@ public void sendMessages

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r64056511 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -273,4 +289,23 @@ public void sendMessages

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220633090 @vasia vertex num: 1, edge num: 3; vertex num: 3, edge num: 10. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r64056167 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -243,18 +255,22 @@ public void sendMessages

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r64056076 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -273,4 +289,23 @@ public void sendMessages

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r64055156 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -243,18 +255,22 @@ public void sendMessages

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

2016-05-19 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

2016-05-19 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1940#issuecomment-220316125 @fhueske i can't reproduce the issue in another computer. And I'm not sure if it's because I forgot the default constructor (no parameter) that led

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-19 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220292049 Hi, @vasia @greghogan . Thanks a lot with your advice! I have modify the codes to support the iteration with `EdgeDirection.OUT` instead of `EdgeDirection.ALL` with

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63856679 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -46,40 +46,89 @@ * represented a page

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63856640 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -122,22 +179,45 @@ public void updateVertex

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-16 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-219605318 @greghogan thanks for your advice and relevant codes have been modified. :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-16 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63354507 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/data/HITSData.java --- @@ -0,0 +1,71

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-16 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63354317 --- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/library/HITSAlgorithmITCase.java --- @@ -0,0 +1,133

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-16 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r63353881 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/data/HITSData.java --- @@ -0,0 +1,71

[GitHub] flink pull request: [FLINK-2184] Cannot get last element with maxB...

2016-05-16 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1975#issuecomment-219362150 Hi @fhueske , can you help review this PR? Thanks! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-12 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-218790864 @vasia @greghogan Can you help with review the new commit? :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-218543446 @greghogan thanks and relevant codes have been modified. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-11 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r62868637 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-218467237 @vasia Thanks a lot and PR has been updated as you advised. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-09 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r62514632 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-09 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r62514639 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2184] Cannot get last element with maxB...

2016-05-09 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1975 [FLINK-2184] Cannot get last element with maxBy/minBy. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-217527593 Hi, @vasia @greghogan , - code modified and support to return both hub and authority score as `Tuple2` type now. The implementation will run extra one iteration

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-04 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-217070480 Thanks a lot, @greghogan @vasia . My limited understand on the tips your have mentioned : 1) The PR implemented HITS by dividing hub&authority updating

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-03 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61986359 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-03 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61868075 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-03 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61866752 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-03 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61865225 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-216433392 @greghogan @vasia thanks a lot for your review and codes have been modified. :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61832489 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61831147 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61831064 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61772427 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r61766847 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -0,0 +1,194 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-216251223 @vasia code modified and i add a extra iteration for getting the aggregated value of previous iteration to normalize all vertex. :) --- If your project is set up

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-216227985 I will have a try. If `iteration==1` or `iteration==maxIteration` maybe a little difficult to deal. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-216224456 @vasia i have noticed the `registerAggregator` can aggregate value in distributed environment and i have used it at the very beginning of this issue. But finally i

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-216190461 @vasia Can you help with review work? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1956 [FLINK-2044] [gelly] Implementation of Gelly HITS Algorithm Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

2016-04-26 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1940 [FLINK-2220] Join on Pojo without hashCode() silently fails Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-212409952 @fhueske Thanks a lot for the explanation and the relevant codes have been modified. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3783] [core] Support weighted random sa...

2016-04-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1909#issuecomment-212397350 @gaoyike A-ES algorithm is a weighted random sampling method with reservoir. It can create a sampler with defined size. And the probability of element distribution

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-212300584 @fhueske PR updated. I am a little confused when i wrote the tests. The original dataset handled by a `map` operator to ensure that the type of partition key is

[GitHub] flink pull request: [FLINK-3783] [core] Support weighted random sa...

2016-04-18 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1909 [FLINK-3783] [core] Support weighted random sampling with reservoir. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-14 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-210255818 @fhueske PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-14 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59819652 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java --- @@ -84,8 +84,8 @@ public PartitionOperator(DataSet

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-208716571 The error of CI build failure is not relevant with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-208712697 @fhueske Thanks a lot for your advice. PR updated. Please forgive my limited understand about the logic of `GlobalProperties`. I added tests to

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-206656056 @zentol codes modified and rebase the new commit with previous one. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-206355988 @zentol , PR updated. The scala environment determine the type with `implicitly[TypeInformation[T]]` which is always the class `Object`. In the case this issue

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-206250467 @zentol Thanks a lot for review work. I will modify the codes base on your advice! --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1857 [FLINK-3444] env.fromElements relies on the first input element for determining the DataSet/DataStream type Add fromElements method with based class type to avoid the exception. You can merge

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-03-30 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-203350617 @fhueske Yes, `TwoInputNode` rebuild the channels and `child` nodes don't have the information of `data distribution`. I have added the information into them a

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-03-29 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-203216796 @fhueske @ChengXiangLi Can you please help with review? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-03-29 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1838 [FLINK-2998] Support range partition comparison for multi input nodes. The PR implements range partition comparison in operation such as join and cogroup for multi inputs, now optimizer can

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-23 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-200321158 @fhueske codes has been modified :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-23 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r57143853 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,230 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-23 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-200255451 @fhueske , PR has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-22 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56980076 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,184 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-21 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56916757 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java --- @@ -45,35 +46,48 @@ private final

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56668261 --- Diff: flink-tests/src/test/java/org/apache/flink/test/distribution/TestDataDist.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

  1   2   >