Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
Wow, finally in!
It was fun and thanks for you help along every step of the journey!
Chen
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chenqin closed the pull request at:
https://github.com/apache/flink/pull/2982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105235710
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -419,6 +435,14 @@ public
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104997566
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -60,6 +60,7 @@
import
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104996349
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -85,6 +86,7 @@
private Set sources
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104995971
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -333,32 +356,41 @@ public void addEdge(Integer
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104846393
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/SingleOutputStreamOperator.java
---
@@ -416,4 +418,35 @@ private
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104847407
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -333,32 +356,41 @@ public void addEdge(Integer
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104847832
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -439,6 +450,7 @@ public static
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104847733
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -60,6 +60,7 @@
import
Github user chenqin commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r104847005
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -85,6 +86,7 @@
private Set sources
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha
Nice! Let's do "Chen Qin qinnc...@gmail.com"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha Looks good to me ð
I briefly looked at your git branch, a minor comment would be adding
comments to `sideOutputLateData` so user get better idea when they opt-in to
late
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha,
diff has been updated and merged to support `apply(Function,
lateElementsOutput);`
`Collector` refactor seems not viable option as stated above.
Seems travis-ci
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha Thanks for your time. We can chat more after 1.2 release!
I think it makes sense to extends Collector, even though we may not remove
collect(T obj) due to API compability issue in
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
cc @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user chenqin opened a pull request:
https://github.com/apache/flink/pull/2982
[FLINK-4460] Side Outputs in Flink
[FLIP-13](https://cwiki.apache.org/confluence/display/FLINK/FLIP-13+Side+Outputs+in+Flink)
Expose sideOutput with `OutputTag`,
For those userFunction
17 matches
Mail list logo
