Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-129223724
@vasia yes, I'm sorry about not finishing it, but I just did not have the
time lately.
Cheers!
---
If your project is set up for it, you can reply to
Github user balidani closed the pull request at:
https://github.com/apache/flink/pull/420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-108284218
Yeah, I should definitely finish this! I'll take a look tonight, sorry
about that :)
---
If your project is set up for it, you can reply to this email and have
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94306580
Hi @vasia!
I fixed the problems, sorry about that. I had to resolve some merge
conflicts and it appears that I did not notice some things. Next time I'll
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94015915
Okay, I updated the PR and Travis passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-93977860
Hi @andralungu!
I just talked to Vasia, and I'll do a rebase today.
Cheers!
---
If your project is set up for it, you can reply to this email and have
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-93728981
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-93723421
Hi!
This PR was closed, but the commit right after mine removes the part that
fixed the windows issue.
https://github.com/apache/flink/commit
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-87062926
So most of the jobs passed, except for PROFILE="-Dhadoop.version=2.6.0
-Dscala-2.11", where it says
No output has been received in the last
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-86219748
Thanks, I did that, hopefully the tests will pass now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-84068746
Hi @vasia! I fixed the algorithm, now it will convert all edges to a pair
of edges and call `distinct` on the edge set. This gives the correct results
now. Thanks
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-84033474
@vasia was completely right about the GGC algorithm, I misunderstood what
it was supposed to do. I implemented the correct version, but it turns out,
after reading the
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-83666214
I doubt that paths like `/C:/...` are valid on Windows. I guess Path should
be changed then? How can we tell whether a path comes from Windows or not?
The Travis
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-82625011
Hi!
I squashed them, I hope it's done correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/491#discussion_r26613854
--- Diff: flink-core/src/test/java/org/apache/flink/core/fs/PathTest.java
---
@@ -63,6 +63,15 @@ public void testPathFromString
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-82586976
Yeah, that makes sense, I added two more assertions.
Sorry, I forgot to check checkstyle before committing.
Should I squash these commits in the end?
---
If
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-82580762
I removed that part, I hope you meant it like this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-82577438
I just realized that this fails in Travis, because in `hasWindowsDrive`
(Path.java, line 282) there is `if (!OperatingSystem.isWindows()) {`. What can
we do in this
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/491#issuecomment-82567110
Hi!
I added some test cases to `PathTest`. Is it okay like this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-82443079
Hi!
I pushed some changes. @vasia told me that she and @StephanEwen even
decided that iterating on triplets is unfeasible, so we should operate on
`` pairs
GitHub user balidani opened a pull request:
https://github.com/apache/flink/pull/491
Fix issue where Windows paths were not recognized as absolute
Hello!
An issue caused all tests to fail on Windows, because the path `file:/C:`
was not recognized as absolute.
This pull
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/441#issuecomment-76998835
Hi @vasia!
Thanks for the ideas! I tried to add more test cases that reflect them.
However, I'm not sure about the last bullet-point. Do you think my
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-76391973
I made the changes @vasia suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user balidani opened a pull request:
https://github.com/apache/flink/pull/441
[FLINK-1522][FLINK-1576] Updated LabelPropagationExample and test
Hi!
I converted the Label Propagation example to the conventional format, where
the main program takes (optional
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25391476
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25256087
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255250
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255193
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255094
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75755326
Hi @vasia, all!
So I implemented the changes that @vasia suggested. I also added a commit
that adds the Hadoop profiles to the `flink-gelly` project in `pom.xml
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-75588338
Hi!
I agree. I will change the example then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75546102
Hi @vasia!
Thanks for the review! I started making the changed, but I got stuck. I get
an exception about `GatherUdf` not being Serializable. I tried copying
GitHub user balidani opened a pull request:
https://github.com/apache/flink/pull/420
Added Local Clustering Coefficient Example (Help needed)
Hi!
I closed https://github.com/apache/flink/pull/400 and created this instead,
because the commit history was messed up
Github user balidani closed the pull request at:
https://github.com/apache/flink/pull/400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r24763748
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to
GitHub user balidani opened a pull request:
https://github.com/apache/flink/pull/408
[FLINK-1514][Gelly] Add a Gather-Sum-Apply iteration method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/balidani/flink gelly-gsa
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/400#issuecomment-74505722
Hi!
Sorry for the messed up commit history, hopefully my next PR will be better.
I have the following exception when running
GitHub user balidani opened a pull request:
https://github.com/apache/flink/pull/400
[FLINK-1528] Added local clustering coefficient example (failing)
As @vasia requested, here is the current version of local clustering
coefficient for Gelly. It causes exceptions, so this PR is
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73732358
@vasia my ICLA has been filed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434866
@vasia yes, just submitted mine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72851434
Sorry, I will only be able to fill the form on Sunday, my internet
connection is horrible here. Is that ok?
Daniel
On Feb 2, 2015 3:53 PM, "Carsten B
41 matches
Mail list logo
