[GitHub] [flink] flinkbot commented on pull request #21743: [FLINK-15325][coordination] Ignores the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large

flinkbot commented on PR #21743: URL: https://github.com/apache/flink/pull/21743#issuecomment-1398746472 ## CI report: * 9118095bdfdf184466f83661e8b39661c7075181 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhuzhurk opened a new pull request, #21743: [FLINK-15325][coordination] Ignores the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large

zhuzhurk opened a new pull request, #21743: URL: https://github.com/apache/flink/pull/21743 ## What is the purpose of the change This change improves the `DefaultPreferredLocationsRetriever` so that it ignores the input locations of a ConsumePartitionGroup if the corresponding Consum

[GitHub] [flink] MartijnVisser commented on pull request #18823: [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27

MartijnVisser commented on PR #18823: URL: https://github.com/apache/flink/pull/18823#issuecomment-1398705483 @RyanSkraba It would indeed be nice if we can move this now to the externalized repo. @dchristle it would be great if you can help validate it so we can move it forward. -- This

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] zentol merged pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

zentol merged PR #21741: URL: https://github.com/apache/flink/pull/21741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082817072 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws Exception

[GitHub] [flink] XComp commented on pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp commented on PR #21737: URL: https://github.com/apache/flink/pull/21737#issuecomment-1398645766 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082757960 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionCh

[GitHub] [flink] dawidwys commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

dawidwys commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082743417 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionChec

[GitHub] [flink] gaborgsomogyi commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

gaborgsomogyi commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398600117 cc @mbalassi @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink] flinkbot commented on pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

flinkbot commented on PR #21742: URL: https://github.com/apache/flink/pull/21742#issuecomment-1398477646 ## CI report: * 9afce3d1052ab18c689e446302a91201c84fadef UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

XComp opened a new pull request, #21742: URL: https://github.com/apache/flink/pull/21742 ## What is the purpose of the change This PR is about hardening the `LeaderElectionService.stop()` contract. The current implementations of LeaderElectionService do not implement the stop()

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082600527 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionChe

[GitHub] [flink] flinkbot commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

flinkbot commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398454630 ## CI report: * 79d653c444716cf88e0b22b08333c2feb50ac872 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaborgsomogyi commented on pull request #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

gaborgsomogyi commented on PR #21732: URL: https://github.com/apache/flink/pull/21732#issuecomment-1398453852 Resolved the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] gaborgsomogyi commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

gaborgsomogyi commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398450836 Addressing the [following](https://github.com/apache/flink/pull/21723#issuecomment-1387339515) comment in this PR. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] healchow commented on a diff in pull request #21722: [FLINK-30747][docs]Translate "Window Deduplication" page of "Querys"

healchow commented on code in PR #21722: URL: https://github.com/apache/flink/pull/21722#discussion_r1082589298 ## docs/content.zh/docs/dev/table/sql/queries/window-deduplication.md: ## @@ -101,15 +102,16 @@ Flink SQL> SELECT * +--+---+--+-+

[GitHub] [flink] gaborgsomogyi commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

gaborgsomogyi commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398447229 This is how it looks like: https://user-images.githubusercontent.com/18561820/213716824-489f5eca-ae23-4d20-b496-fdd09dc9457d.png";> -- This is an automated message from the

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

gaborgsomogyi opened a new pull request, #21741: URL: https://github.com/apache/flink/pull/21741 ## What is the purpose of the change Until now the generic delegation token params are not shown on the main config page. In this PR I've added them. ## Brief change log Incl

[GitHub] [flink] fsk119 commented on pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

fsk119 commented on PR #21717: URL: https://github.com/apache/flink/pull/21717#issuecomment-1398397981 > P.S. Wrong cmd will get CLI blocked forever. Thanks for reporting the case. With the commit 0e04c7, the Executor will try to close the Operation in the background when users hit c

[GitHub] [flink] XComp commented on a diff in pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

XComp commented on code in PR #21740: URL: https://github.com/apache/flink/pull/21740#discussion_r1082532829 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunner.java: ## @@ -89,11 +93,29 @@ public CompletableFuture closeAsync() {

[GitHub] [flink] XComp commented on a diff in pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

XComp commented on code in PR #21740: URL: https://github.com/apache/flink/pull/21740#discussion_r1082532829 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunner.java: ## @@ -89,11 +93,29 @@ public CompletableFuture closeAsync() {

[GitHub] [flink] dawidwys commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

dawidwys commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082525394 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionChec

[GitHub] [flink] zentol commented on a diff in pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

zentol commented on code in PR #21740: URL: https://github.com/apache/flink/pull/21740#discussion_r1082519363 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunner.java: ## @@ -89,11 +93,29 @@ public CompletableFuture closeAsync() {

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082508795 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFac

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082508795 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFac

[GitHub] [flink] hehuiyuan commented on pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

hehuiyuan commented on PR #21731: URL: https://github.com/apache/flink/pull/21731#issuecomment-1398347485 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] flinkbot commented on pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

flinkbot commented on PR #21740: URL: https://github.com/apache/flink/pull/21740#issuecomment-1398335456 ## CI report: * 46ab3d550b0d2be1b260f7c200ca6d168c7625ae UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

XComp opened a new pull request, #21740: URL: https://github.com/apache/flink/pull/21740 ## What is the purpose of the change The entire purpose of this wrapper `DispatcherRunnerLeaderElectionLifecycleManager` is to have the start/stop of the `LeaderElectionService` out of the `Defau

[GitHub] [flink] zentol commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

zentol commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082457711 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFa

[GitHub] [flink] XComp commented on a diff in pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

XComp commented on code in PR #21738: URL: https://github.com/apache/flink/pull/21738#discussion_r1082412814 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionService.java: ## @@ -48,7 +49,7 @@ public synchronized CompletableFuture getC

[GitHub] [flink-web] mbalassi closed pull request #602: Blog post on the Delegation Token Framework

mbalassi closed pull request #602: Blog post on the Delegation Token Framework URL: https://github.com/apache/flink-web/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082408148 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFac

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082408148 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFac

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082408148 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFac

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082365656 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionChe

[GitHub] [flink] mbalassi merged pull request #21694: [FLINK-30704][filesystems][s3] Add S3 delegation token support

mbalassi merged PR #21694: URL: https://github.com/apache/flink/pull/21694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] flinkbot commented on pull request #21739: [FLINK-30673][docs][table] Add documentation for "EXPLAIN PLAN_ADVICE" statement

flinkbot commented on PR #21739: URL: https://github.com/apache/flink/pull/21739#issuecomment-1398198832 ## CI report: * e19d7dc89412bb6cd9bcf781a8938e9023e23048 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest opened a new pull request, #21739: [FLINK-30673][docs][table] Add documentation for "EXPLAIN PLAN_ADVICE" statement

LadyForest opened a new pull request, #21739: URL: https://github.com/apache/flink/pull/21739 ## What is the purpose of the change This pull request adds documentation for `EXPLAIN PLAN_ADVICE` statement. ## Brief change log Add doc. ## Verifying this chang

[GitHub] [flink] zentol commented on a diff in pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

zentol commented on code in PR #21738: URL: https://github.com/apache/flink/pull/21738#discussion_r1082324266 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionService.java: ## @@ -48,7 +49,7 @@ public synchronized CompletableFuture get

[GitHub] [flink] zentol commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

zentol commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082321263 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final LeaderElectionDriverFa

[GitHub] [flink-connector-kafka] zentol commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1082317243 ## flink-connector-kafka/pom.xml: ## @@ -18,259 +18,292 @@ specific language governing permissions and limitations under the License. --> http://maven.apache

[GitHub] [flink] flinkbot commented on pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

flinkbot commented on PR #21738: URL: https://github.com/apache/flink/pull/21738#issuecomment-1398166208 ## CI report: * b6fb5cacd48f5c91c7cf27ea45395696b2eb04f8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-cassandra] zentol commented on pull request #3: [FLINK-26822] Add Cassandra Source

zentol commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1398165894 > So I think I'll try to reuse this code, migrate it to Flink and update it to the latest Cassandra version and push it in this PR. Sounds good to me so far. -- This

[GitHub] [flink-connector-cassandra] zentol commented on pull request #3: [FLINK-26822] Add Cassandra Source

zentol commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1398165328 > I don't think it is an ASF rule but fair enough, FYI; By and large it should be viewed as a legal requirement. By copying code from cassandra you have to adhere to the

[GitHub] [flink] XComp opened a new pull request, #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

XComp opened a new pull request, #21738: URL: https://github.com/apache/flink/pull/21738 ## What is the purpose of the change The intention is to make the code more robust to test failures. We do no enable asserts in the test runs. The JVM has asserts disabled by default. That would

[GitHub] [flink] flinkbot commented on pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

flinkbot commented on PR #21737: URL: https://github.com/apache/flink/pull/21737#issuecomment-1398141726 ## CI report: * 826f33a2bd51e93a65956d5bb50d64c99eb55f3f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

XComp opened a new pull request, #21737: URL: https://github.com/apache/flink/pull/21737 ## What is the purpose of the change The @GuardedBy annotations were assigned to some public methods which are not called under the specified lock. @GuardedBy should be used by methods that are o

[GitHub] [flink] pnowojski commented on pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

pnowojski commented on PR #20151: URL: https://github.com/apache/flink/pull/20151#issuecomment-1398086486 👍 Thanks, it looks good. Once you squash fixup commits I will do the last pass and hopefully merge. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [flink] ZhongFuCheng3y commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.

ZhongFuCheng3y commented on PR #21553: URL: https://github.com/apache/flink/pull/21553#issuecomment-1398010881 > @reswqa @ZhongFuCheng3y Hive requires the `flink-table-planner_2.12-.jar`, so for example ` flink-table-planner_2.12-1.16.0.jar`. See https://nightlies.apache.org/flink/flink-do

[GitHub] [flink] flinkbot commented on pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

flinkbot commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1397936174 ## CI report: * f7edc0bb36dda4c6144c97a73c8167c0e2bf0a0e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaoyunhaii commented on pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

gaoyunhaii commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1397934193 @XComp could you have a look at the PR? Very thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [flink] gaoyunhaii opened a new pull request, #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

gaoyunhaii opened a new pull request, #21736: URL: https://github.com/apache/flink/pull/21736 ## What is the purpose of the change This PR refactors the state migration tests so that when cutting branch, we need only add new version and could generates the states of stale version aut

[GitHub] [flink] swuferhong commented on a diff in pull request #21724: [FLINK-30727][table-planner] Fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed

swuferhong commented on code in PR #21724: URL: https://github.com/apache/flink/pull/21724#discussion_r1082114927 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/join/JoinReorderITCase.java: ## @@ -42,6 +45,12 @@ public class Jo

[GitHub] [flink] swuferhong commented on pull request #21724: [FLINK-30727][table-planner] Fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed

swuferhong commented on PR #21724: URL: https://github.com/apache/flink/pull/21724#issuecomment-1397929362 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] JingGe commented on a diff in pull request #21322: [FLINK-30025][table] Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

JingGe commented on code in PR #21322: URL: https://github.com/apache/flink/pull/21322#discussion_r1082088415 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -926,7 +926,7 @@ private TableResultInternal exec

[GitHub] [flink] JingGe commented on a diff in pull request #21322: [FLINK-30025][table] Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

JingGe commented on code in PR #21322: URL: https://github.com/apache/flink/pull/21322#discussion_r1082086891 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java: ## @@ -102,6 +102,16 @@ private TableConfigOptions() {}

[GitHub] [flink] LadyForest commented on pull request #21727: [FLINK-30752][python] Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

LadyForest commented on PR #21727: URL: https://github.com/apache/flink/pull/21727#issuecomment-1397885340 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] lincoln-lil closed pull request #21676: [FLINK-30662][table] Planner supports delete

lincoln-lil closed pull request #21676: [FLINK-30662][table] Planner supports delete URL: https://github.com/apache/flink/pull/21676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] fsk119 commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

fsk119 commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1082055861 ## flink-table/flink-sql-client/src/test/resources/sql/table.q: ## @@ -79,7 +79,10 @@ show tables; # test SHOW CREATE TABLE show create table orders; -CREATE TABLE `

[GitHub] [flink-ml] jiangxin369 commented on pull request #201: [FLINK-27716] Add Python API docs in ML

jiangxin369 commented on PR #201: URL: https://github.com/apache/flink-ml/pull/201#issuecomment-1397846787 @lindong28 Could you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082041845 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class ChannelStateWriteR

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082043383 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -107,49 +119,78 @@ void run() {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082043383 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -107,49 +119,78 @@ void run() {

[GitHub] [flink-connector-kafka] mas-chen commented on pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

mas-chen commented on PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#issuecomment-1397828588 CI now passes on my fork -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082041845 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class ChannelStateWriteR

[GitHub] [flink] flinkbot commented on pull request #21735: [hotfix] [docs] Fix a typo in a query that erroneously tries to perform an aggregation on a string column

flinkbot commented on PR #21735: URL: https://github.com/apache/flink/pull/21735#issuecomment-1397810857 ## CI report: * 37175760368c64b665e16e5cf8b7eb4f4e951fee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] karanasher opened a new pull request, #21735: [hotfix] [docs] Fix a typo in a query that erroneously tries to perform an aggregation on a string column

karanasher opened a new pull request, #21735: URL: https://github.com/apache/flink/pull/21735 Fix a typo in a query that erroneously tries to perform an aggregation on a string column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082023420 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class ChannelStateWriteR

[GitHub] [flink-kubernetes-operator] morhidi closed pull request #463: [FLINK-30119] Breaking change: Flink Kubernetes Operator should store…

morhidi closed pull request #463: [FLINK-30119] Breaking change: Flink Kubernetes Operator should store… URL: https://github.com/apache/flink-kubernetes-operator/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #463: [FLINK-30119] Breaking change: Flink Kubernetes Operator should store…

morhidi commented on PR #463: URL: https://github.com/apache/flink-kubernetes-operator/pull/463#issuecomment-1397797194 After discussing it with Clara, I'm colsing this for the time being. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink] dchristle commented on pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

dchristle commented on PR #21729: URL: https://github.com/apache/flink/pull/21729#issuecomment-1397381115 Hi @Myasuka, Thanks for reviewing this PR! I split the changes into separate commits. The first commit removes `disableDataSync`, and the last commit aligns the PyFlink RocksDB d

[GitHub] [flink] dchristle commented on a diff in pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

dchristle commented on code in PR #21729: URL: https://github.com/apache/flink/pull/21729#discussion_r1081619201 ## flink-python/pyflink/datastream/state_backend.py: ## @@ -956,16 +956,20 @@ class PredefinedOptions(Enum): determined to be beneficial for performance under di

[GitHub] [flink] RyanSkraba commented on pull request #19970: [FLINK-27970][tests][JUnit5 migration] flink-hadoop-bulk

RyanSkraba commented on PR #19970: URL: https://github.com/apache/flink/pull/19970#issuecomment-1397364945 Hello! I've rebased this PR to master and fixed the merge conflicts in the meantime. I will be mostly away from my computer for a couple of weeks, but I'll check in if anything

[GitHub] [flink] RyanSkraba commented on pull request #21289: [FLINK-29452] Allow unit tests to be executed independently

RyanSkraba commented on PR #21289: URL: https://github.com/apache/flink/pull/21289#issuecomment-1397363704 Hello! I've rebased this PR to master. I don't believe there are any remaining requested changes that I haven't addressed (by comment or other). I will be mostly away from my c

[GitHub] [flink] dchristle commented on a diff in pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

dchristle commented on code in PR #21729: URL: https://github.com/apache/flink/pull/21729#discussion_r1081578012 ## flink-python/pyflink/datastream/state_backend.py: ## @@ -1000,21 +1000,24 @@ class PredefinedOptions(Enum): The following options are set: +- BlockBas

[GitHub] [flink] RyanSkraba commented on pull request #19897: [FLINK-27885][tests][JUnit5 migration] flink-csv

RyanSkraba commented on PR #19897: URL: https://github.com/apache/flink/pull/19897#issuecomment-1397317096 Hello! I've rebased this PR to master. I don't believe there are any remaining requested changes that I haven't addressed (by comment or other). I will be mostly away from my c

[GitHub] [flink] mbalassi commented on pull request #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

mbalassi commented on PR #21732: URL: https://github.com/apache/flink/pull/21732#issuecomment-1397310760 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081546445 ## flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/MapDataSerializer.java: ## @@ -227,25 +225,22 @@ public void readSnapshot(int

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081544400 ## flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/RowDataSerializer.java: ## @@ -194,31 +193,33 @@ public void readSnapshot(int

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081541284 ## flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/ScalaEnumSerializerSnapshot.scala: ## @@ -80,25 +80,26 @@ class ScalaEnumSerializerSnapshot[E <: Enu

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081540937 ## flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/ScalaEnumSerializerSnapshot.scala: ## @@ -80,25 +80,26 @@ class ScalaEnumSerializerSnapshot[E <: Enu

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081536771 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/RowDataSerializer.java: ## @@ -328,26 +327,27 @@ public void readSnapshot(int

[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #36: [FLINK-30378][docs] Use modified sql_connector_download_table shortcode

boring-cyborg[bot] commented on PR #36: URL: https://github.com/apache/flink-connector-aws/pull/36#issuecomment-1397233856 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-connector-aws] zentol merged pull request #36: [FLINK-30378][docs] Use modified sql_connector_download_table shortcode

zentol merged PR #36: URL: https://github.com/apache/flink-connector-aws/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[GitHub] [flink] zentol merged pull request #21492: [FLINK-30378][docs] Add v2 sql_connector_download_table shortcode

zentol merged PR #21492: URL: https://github.com/apache/flink/pull/21492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] zentol commented on pull request #17834: [FLINK-24941][datadog] Support Boolean gauges

zentol commented on PR #17834: URL: https://github.com/apache/flink/pull/17834#issuecomment-1397207313 So gauges are a bit annoying. Ideally we would only have Number gauges because really nothing else is properly supported by a majority of systems. Boolean gauges are usually a mistak

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1081463284 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplitSerializer.java: ## @@ -0,0 +1,63 @@ +/* + * L

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1081459459 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the A

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1081459459 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the A

[GitHub] [flink] healchow commented on a diff in pull request #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

healchow commented on code in PR #21726: URL: https://github.com/apache/flink/pull/21726#discussion_r1081454537 ## docs/content.zh/docs/dev/table/sql/queries/overview.md: ## @@ -155,110 +158,116 @@ sink_descriptor = TableDescriptor.for_connector("filesystem") t_env.create_te

[GitHub] [flink] healchow commented on a diff in pull request #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

healchow commented on code in PR #21726: URL: https://github.com/apache/flink/pull/21726#discussion_r1081454537 ## docs/content.zh/docs/dev/table/sql/queries/overview.md: ## @@ -155,110 +158,116 @@ sink_descriptor = TableDescriptor.for_connector("filesystem") t_env.create_te

[GitHub] [flink] healchow commented on a diff in pull request #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

healchow commented on code in PR #21726: URL: https://github.com/apache/flink/pull/21726#discussion_r1081453260 ## docs/content.zh/docs/dev/table/sql/queries/overview.md: ## @@ -155,110 +158,116 @@ sink_descriptor = TableDescriptor.for_connector("filesystem") t_env.create_te

[GitHub] [flink] zentol merged pull request #21723: [FLINK-30749][security][runtime] Fix delegation token provider enabled flag documentation

zentol merged PR #21723: URL: https://github.com/apache/flink/pull/21723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1397142509 > > I did not author the RingRange and SplitsGenerator classes. I got them from the Apache Beam Cassandra connector. > > If you're copying stuff from other projects i

[GitHub] [flink] LadyForest commented on pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

LadyForest commented on PR #21717: URL: https://github.com/apache/flink/pull/21717#issuecomment-1397141360 P.S. Wrong cmd will get CLI blocked forever. The stacktrace is attached ```text Flink SQL> desc extended foo; Exception in thread "main" org.apache.flink.table.clien

[GitHub] [flink] LadyForest commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

LadyForest commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1081032613 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlCommandParserImpl.java: ## @@ -18,35 +18,136 @@ package org.apache.flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1081412503 ## docs/content/docs/connectors/table/hive/hive_read_write.md: ## @@ -558,6 +558,70 @@ use more threads to speed the gathering. **NOTE:** - Only `BATCH` mode support

[GitHub] [flink] luoyuxia commented on a diff in pull request #21601: [FLINK-29720][hive] Supports native avg function for hive dialect

luoyuxia commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1081360275 ## docs/content.zh/docs/connectors/table/hive/hive_functions.md: ## @@ -73,6 +73,31 @@ Some Hive built-in functions in older versions have [thread safety issues](http

  1   2   3   4   5   6   7   8   9   10   >