[GitHub] flink pull request #308: [FLINK-1398] Introduce extractSingleField() in Data...

2017-02-06 Thread FelixNeutatz
Github user FelixNeutatz closed the pull request at: https://github.com/apache/flink/pull/308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2208] Fix IBM Java integration bug

2015-07-08 Thread FelixNeutatz
Github user FelixNeutatz closed the pull request at: https://github.com/apache/flink/pull/833 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2208] Fix IBM Java integration bug

2015-07-08 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/833#issuecomment-119519615 thanks, so I will close it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-2208] Fix IBM Java integration bug

2015-07-07 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/833#issuecomment-119234837 I have no time at the moment to think about it. But this is still an issue ... --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2208] Fix IBM Java integration bug

2015-06-14 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/833 [FLINK-2208] Fix IBM Java integration bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/FelixNeutatz/incubator-flink FLINK_2208_IBM_JAVA

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-05-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-101981739 So, what is the final decision here? > this seems like a lot of code for something that can be achieved using a simple mapper --> that is exact

[GitHub] flink pull request: [FLINK-1735] Feature hasher

2015-05-10 Thread FelixNeutatz
Github user FelixNeutatz closed the pull request at: https://github.com/apache/flink/pull/661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1735] Feature hasher

2015-05-10 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/661#issuecomment-100690583 This will be further implemented here: https://github.com/apache/flink/pull/665 --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread FelixNeutatz
Github user FelixNeutatz commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005430 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142

[GitHub] flink pull request: Feature hasher

2015-05-07 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/661 Feature hasher First version of the feature hasher :) This is joined work by: - Christoph Alt - Xi Yang - Felix Neutatz You can merge this pull request into a Git

[GitHub] flink pull request: [FLINK-1820] CSVReader: In case of an empty st...

2015-04-27 Thread FelixNeutatz
Github user FelixNeutatz commented on a diff in the pull request: https://github.com/apache/flink/pull/566#discussion_r29148302 --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java --- @@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos

[GitHub] flink pull request: [FLINK-1820] CSVReader: In case of an empty st...

2015-04-27 Thread FelixNeutatz
Github user FelixNeutatz commented on a diff in the pull request: https://github.com/apache/flink/pull/566#discussion_r29145755 --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java --- @@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos

[GitHub] flink pull request: [FLINK-1820] CSVReader: In case of an empty st...

2015-04-21 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/566#issuecomment-94810290 @fhueske: I agree on that :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-1900] add missing '

2015-04-17 Thread FelixNeutatz
Github user FelixNeutatz closed the pull request at: https://github.com/apache/flink/pull/608 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1900] add missing '

2015-04-17 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/608 [FLINK-1900] add missing ' You can merge this pull request into a Git repository by running: $ git pull https://github.com/FelixNeutatz/incubator-flink patch-1 Alternatively yo

[GitHub] flink pull request: [FLINK-1820] Interpret empty string as zero

2015-04-03 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/566 [FLINK-1820] Interpret empty string as zero You can merge this pull request into a Git repository by running: $ git pull https://github.com/FelixNeutatz/incubator-flink ParserBug

[GitHub] flink pull request: [FLINK-1428] Update dataset_transformations.md

2015-01-26 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/340 [FLINK-1428] Update dataset_transformations.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/FelixNeutatz/incubator-flink FelixNeutatz

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69966273 I am really open about the place of this functionality, but I'd really love to have it. Shall we start a package in flink-java? --- If your project is set u

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69962411 The simple map function implementation reduces the code to 26 lines. I think that this is more reasonable :) --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69952101 Good question, I thought it would be nice to have it implemented "natively", but I can also setup the same thing using a simple map function if this is

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/308 [FLINK-1398] Introduce extractSingleField() in DataSet This is a prototype how we could implement extractSingleField() for DataSet. Let's discuss :) You can merge this pull request into

[GitHub] flink pull request: [FLINK-1271] Remove writable limitation

2015-01-11 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/287#issuecomment-69513699 I rebased some of the commits as requested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1271] Remove writable limitation

2015-01-08 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/287#issuecomment-69222057 Shall also add the same test for the mapred package? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1271] Remove writable limitation

2015-01-08 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/287#issuecomment-69220758 I added a simple unit test: HadoopInputFormatTest.java Did you mean this test? --- If your project is set up for it, you can reply to this email and have your