[jira] [Commented] (FLINK-31542) FatalExceptionClassifier#isFatal returns false if the exception is fatal

[ https://issues.apache.org/jira/browse/FLINK-31542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703678#comment-17703678 ] DavidLiu commented on FLINK-31542: -- [~danny.cranmer]  Would you please help review this

[jira] [Commented] (FLINK-31542) FatalExceptionClassifier#isFatal returns false if the exception is fatal

[ https://issues.apache.org/jira/browse/FLINK-31542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703464#comment-17703464 ] DavidLiu commented on FLINK-31542: -- Please assign this to me, I will fix it. > FatalEx

[jira] (FLINK-28947) Curator framework fails with NullPointerException

[ https://issues.apache.org/jira/browse/FLINK-28947 ] DavidLiu deleted comment on FLINK-28947: -- was (Author: JIRAUSER289843): It seems Curator has bug.  I can help fix it. > Curator framework fails with NullPointerException > -

[jira] [Commented] (FLINK-28947) Curator framework fails with NullPointerException

[ https://issues.apache.org/jira/browse/FLINK-28947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579431#comment-17579431 ] DavidLiu commented on FLINK-28947: -- It seems Curator has bug.  I can help fix it. > Cu

[jira] [Comment Edited] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573268#comment-17573268 ] DavidLiu edited comment on FLINK-28111 at 7/30/22 1:58 PM: --- Th

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573268#comment-17573268 ] DavidLiu commented on FLINK-28111: -- This is not an issue, but rather, by design. The t

[jira] [Commented] (FLINK-27019) use hive dialect in SqlClient would thrown an error based on 1.15 version

[ https://issues.apache.org/jira/browse/FLINK-27019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573263#comment-17573263 ] DavidLiu commented on FLINK-27019: -- The source codes have supported hive-dialect. This

[jira] [Commented] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571928#comment-17571928 ] DavidLiu commented on FLINK-27537: -- [~CrynetLogistics]  Any comment ? > Remove require

[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571827#comment-17571827 ] DavidLiu commented on FLINK-25735: -- [~martijnvisser] The old PR was closed, I  provide

[jira] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735 ] DavidLiu deleted comment on FLINK-25735: -- was (Author: JIRAUSER289843): [~martijnvisser]  The old PR was closed, I  provide a new PR [https://github.com/apache/flink/pull/20379] Would you plea

[jira] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735 ] DavidLiu deleted comment on FLINK-25735: -- was (Author: JIRAUSER289843): The pull request is [https://github.com/apache/flink/pull/20143] Please help review it > Chinese Translation - Add docu

[jira] [Comment Edited] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567045#comment-17567045 ] DavidLiu edited comment on FLINK-25735 at 7/27/22 9:57 AM: --- [~

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571447#comment-17571447 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer]  Please help review this Pull Reque

[jira] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536 ] DavidLiu deleted comment on FLINK-27536: -- was (Author: JIRAUSER289843): [~dannycranmer]  Please help review this Pull Request again，which has been updated.  [https://github.com/apache/flink/pu

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 1:54 PM: --- [~

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:13 AM: --- [~

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:13 AM: --- [~

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:10 AM: --- [~

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571196#comment-17571196 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer] I will open a new Pull Request > R

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569805#comment-17569805 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:09 AM: --- Th

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569934#comment-17569934 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer]  please review the feedback in PR.

[jira] [Comment Edited] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569835#comment-17569835 ] DavidLiu edited comment on FLINK-27537 at 7/22/22 6:37 AM: --- Th

[jira] [Commented] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569835#comment-17569835 ] DavidLiu commented on FLINK-27537: -- [flink-connectors/flink-connector-base/src/main/jav

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569805#comment-17569805 ] DavidLiu edited comment on FLINK-27536 at 7/22/22 5:13 AM: --- Th

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569805#comment-17569805 ] DavidLiu commented on FLINK-27536: -- https://github.com/apache/flink/pull/20338 > Renam

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569347#comment-17569347 ] DavidLiu commented on FLINK-27536: -- Hello,Zichen Liu. I would like to deal with it.  Ca

[jira] [Commented] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable

[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569346#comment-17569346 ] DavidLiu commented on FLINK-27537: -- Hello,Zichen Liu. I would like to deal with it.  Ca

[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567045#comment-17567045 ] DavidLiu commented on FLINK-25735: -- [~CrynetLogistics] [~martijnvisser] Would you pleas

[jira] [Comment Edited] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567045#comment-17567045 ] DavidLiu edited comment on FLINK-25735 at 7/15/22 1:53 AM: --- [~

[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561984#comment-17561984 ] DavidLiu commented on FLINK-25735: -- The pull request is [https://github.com/apache/fli

[jira] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735 ] DavidLiu deleted comment on FLINK-25735: -- was (Author: JIRAUSER289843): [The PR is https://github.com/apache/flink/pull/20141|https://github.com/apache/flink/pull/20141] > Chinese Translation

[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561880#comment-17561880 ] DavidLiu commented on FLINK-25735: -- [https://github.com/apache/flink/pull/20141] > Chi

[jira] [Comment Edited] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561880#comment-17561880 ] DavidLiu edited comment on FLINK-25735 at 7/3/22 3:17 PM: -- [The

[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

Title: Message Title DavidLiu commented on

[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink

[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558422#comment-17558422 ] DavidLiu commented on FLINK-25735: -- Hello,Zichen Liu. I would like to transfer it to Ch