[jira] [Commented] (FLINK-35792) Sorting by proctime does not work in rank

2024-11-07 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896590#comment-17896590 ] xuyang commented on FLINK-35792: Let me summarize: In the Rank, if the order key includ

Re: [PR] [FLINK-36247][cdc-connector][mysql] Fix potential transaction leak du… [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3699: URL: https://github.com/apache/flink-cdc/pull/3699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[jira] [Comment Edited] (FLINK-36247) Potential transaction leak during MySQL snapshot phase

2024-11-07 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896566#comment-17896566 ] Ruan Hang edited comment on FLINK-36247 at 11/8/24 7:42 AM:

[jira] [Assigned] (FLINK-36502) Remove all deprecated methods in `FactoryUtil`

2024-11-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-36502: - Assignee: Shengbo > Remove all deprecated methods in `FactoryUtil` > --

[jira] [Commented] (FLINK-36502) Remove all deprecated methods in `FactoryUtil`

2024-11-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896587#comment-17896587 ] Shengkai Fang commented on FLINK-36502: --- Merged with commit: b4bcde53b0cc5c20c7f2c

[jira] [Closed] (FLINK-36502) Remove all deprecated methods in `FactoryUtil`

2024-11-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-36502. - Resolution: Fixed > Remove all deprecated methods in `FactoryUtil` > ---

Re: [PR] [FLINK-36502] [TABLE-SQL] Remove deprecated methods in FactoryUtil. [flink]

2024-11-07 Thread via GitHub
fsk119 merged PR #25559: URL: https://github.com/apache/flink/pull/25559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler [flink]

2024-11-07 Thread via GitHub
RocMarshal commented on code in PR #25504: URL: https://github.com/apache/flink/pull/25504#discussion_r1833835398 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to th

Re: [PR] [BP-1.20][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin merged PR #25622: URL: https://github.com/apache/flink/pull/25622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36408] Fix MySQL pipeline connector failed to parse FLOAT type with precision [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on PR #3625: URL: https://github.com/apache/flink-cdc/pull/3625#issuecomment-2463939842 Rebased #3696 into this, could @ruanhang1993 please trigger CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (FLINK-36238) State_ttl hints on joins don't work as documented

2024-11-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896586#comment-17896586 ] Sergey Nuyanzin commented on FLINK-36238: - it was fixed with FLINK-36417 for 1.1

[jira] [Resolved] (FLINK-36238) State_ttl hints on joins don't work as documented

2024-11-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36238. - Resolution: Duplicate > State_ttl hints on joins don't work as documented >

[jira] [Commented] (FLINK-36417) STATE_TTL doesn't work with WatermarkAssigner

2024-11-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896585#comment-17896585 ] Sergey Nuyanzin commented on FLINK-36417: - Merged to 1.19 as [5b4914b981f5966c

Re: [PR] [FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler [flink]

2024-11-07 Thread via GitHub
RocMarshal commented on code in PR #25504: URL: https://github.com/apache/flink/pull/25504#discussion_r1833818069 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to th

[jira] [Updated] (FLINK-36417) STATE_TTL doesn't work with WatermarkAssigner

2024-11-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36417: Fix Version/s: 1.19.2 1.20.1 > STATE_TTL doesn't work with WatermarkAss

Re: [PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin merged PR #25623: URL: https://github.com/apache/flink/pull/25623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[PR] [FLINK-36649][cdc-connector][oracle] Fix oracle connection close erro… [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 opened a new pull request, #3700: URL: https://github.com/apache/flink-cdc/pull/3700 …r (#3678) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler [flink]

2024-11-07 Thread via GitHub
huyuanfeng2018 commented on code in PR #25504: URL: https://github.com/apache/flink/pull/25504#discussion_r1833801769 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed t

[jira] [Resolved] (FLINK-36649) Oracle When reading via OracleIncrementalSource, the connection is occasionally closed

2024-11-07 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang resolved FLINK-36649. --- Resolution: Fixed master(3.3-SNAPSHOT): 7f6d9115ae5fec8a7d09d6a7ab4a2ec180e0b646 > Oracle When read

Re: [PR] [FLINK-36649] Fix oracle connection close error by OracleIncrementalSource read [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3678: URL: https://github.com/apache/flink-cdc/pull/3678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[jira] [Commented] (FLINK-16155) Translate "Operator/Process Function" into Chinese

2024-11-07 Thread BoShuai Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896581#comment-17896581 ] BoShuai Li commented on FLINK-16155: Hi, [~jark], The pr is ready for review now: [G

[jira] [Comment Edited] (FLINK-16077) Translate "Custom State Serialization" page into Chinese

2024-11-07 Thread BoShuai Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896580#comment-17896580 ] BoShuai Li edited comment on FLINK-16077 at 11/8/24 6:49 AM: -

[jira] [Commented] (FLINK-16077) Translate "Custom State Serialization" page into Chinese

2024-11-07 Thread BoShuai Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896580#comment-17896580 ] BoShuai Li commented on FLINK-16077: Hi, team, The pr is ready for review now: [GitH

Re: [PR] [FLINK-16077][docs] Translate "Custom State Serialization" page into Chinese [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25625: URL: https://github.com/apache/flink/pull/25625#issuecomment-2463901321 ## CI report: * 4723296172dd6e6bf44588a7152e0a4f094b6c70 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-16077] Translate "Custom State Serialization" page into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 commented on PR #25625: URL: https://github.com/apache/flink/pull/25625#issuecomment-2463898850 Hi, @leonardBang @fredia , Excuse me, do you have time to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-36635][runtime] Remove PhysicalSlotRequestBulkImpl as it is not used [flink]

2024-11-07 Thread via GitHub
eemario commented on PR #25596: URL: https://github.com/apache/flink/pull/25596#issuecomment-2463898017 @JunRuiLee Thanks for reviewing this pr! All comments have been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#issuecomment-2463897093 Done, extracted common logic into `flink_cdc_base` and `flink_cdc_migration_test_base`, and kept minimal configurations in `flink_cdc_java_8` and `flink_cdc_java_11` workflow. @GOODBOY

[PR] [FLINK-16077] Translate "Custom State Serialization" page into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 opened a new pull request, #25625: URL: https://github.com/apache/flink/pull/25625 What is the purpose of the change --- Translate Custom State Serialization page into Chinese Verifying this change --- This change is a trivial rework / code cleanup without any t

Re: [PR] [FLINK-16155][docs] Translate "Operator/Process Function" into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 commented on PR #25624: URL: https://github.com/apache/flink/pull/25624#issuecomment-2463890964 Hi, @leonardBang @fredia , Excuse me, do you have time to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler [flink]

2024-11-07 Thread via GitHub
huyuanfeng2018 commented on code in PR #25504: URL: https://github.com/apache/flink/pull/25504#discussion_r1833781059 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed t

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463886561 CI failure,I will recheck the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-16155][docs] Translate "Operator/Process Function" into Chinese [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25624: URL: https://github.com/apache/flink/pull/25624#issuecomment-2463886857 ## CI report: * 8ac73127b9537a3a543f0e4848ad156f1ae84f54 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-16155][docs] Translate "Operator/Process Function" into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 opened a new pull request, #25624: URL: https://github.com/apache/flink/pull/25624 What is the purpose of the change --- Translate Process Function page into Chinese Verifying this change --- This change is a trivial rework / code cleanup without any test covera

Re: [PR] [FLINK-36654] [table] Fix wrong cast when decimal divide integer [flink]

2024-11-07 Thread via GitHub
lincoln-lil commented on PR #25604: URL: https://github.com/apache/flink/pull/25604#issuecomment-2463875356 @xishuaidelin Could you also backport this fix into release-1.20? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-36654) Decimal divide Integer reports Null pointer exception

2024-11-07 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-36654: Fix Version/s: 1.20.1 > Decimal divide Integer reports Null pointer exception > --

[jira] [Updated] (FLINK-36654) Decimal divide Integer reports Null pointer exception

2024-11-07 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-36654: Affects Version/s: 1.20.0 > Decimal divide Integer reports Null pointer exception > --

[jira] [Closed] (FLINK-36654) Decimal divide Integer reports Null pointer exception

2024-11-07 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-36654. --- Fix Version/s: 2.0.0 Resolution: Fixed Fixed in master: bd6f292ad7fc75e1285ca6987a16422c98083

[jira] (FLINK-16077) Translate "Custom State Serialization" page into Chinese

2024-11-07 Thread BoShuai Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16077 ] BoShuai Li deleted comment on FLINK-16077: was (Author: JIRAUSER306047): Hi, team, The pr is ready for review now: [GitHub Pull Request #25617|https://github.com/apache/flink/pull/25617] >

Re: [PR] [FLINK-36654] [table] Fix wrong cast when decimal divide integer [flink]

2024-11-07 Thread via GitHub
lincoln-lil merged PR #25604: URL: https://github.com/apache/flink/pull/25604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Assigned] (FLINK-36654) Decimal divide Integer reports Null pointer exception

2024-11-07 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-36654: --- Assignee: Shuai Xu > Decimal divide Integer reports Null pointer exception > --

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463867357 > @MOBIN-F Could you kindly rebase again? done~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (FLINK-36673) Operator is not properly handling failed deployments without savepoints

2024-11-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896570#comment-17896570 ] Gyula Fora commented on FLINK-36673: The error seems to be coming from Flink JM dire

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463861429 @MOBIN-F Could you kindly rebase again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 commented on code in PR #3590: URL: https://github.com/apache/flink-cdc/pull/3590#discussion_r1833761648 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableP

[jira] [Commented] (FLINK-36673) Operator is not properly handling failed deployments without savepoints

2024-11-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896569#comment-17896569 ] Gyula Fora commented on FLINK-36673: The PR you linked doesn't seem to touch the act

Re: [PR] [hotfix] Fix SUBSTR built-in function testcases [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang merged PR #3696: URL: https://github.com/apache/flink-cdc/pull/3696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [hotfix] Fix SUBSTR built-in function testcases [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on PR #3696: URL: https://github.com/apache/flink-cdc/pull/3696#issuecomment-2463843675 CI passed ,merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on code in PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#discussion_r1833746011 ## .github/workflows/flink_cdc_migration_test.yml: ## @@ -28,7 +28,7 @@ jobs: submodules: true - uses: actions/setup-java@v4 with: -

Re: [PR] [hotfix] Fix SUBSTR built-in function testcases [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on PR #3696: URL: https://github.com/apache/flink-cdc/pull/3696#issuecomment-2463839653 Done, all passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-36247][cdc-connector][mysql] Fix potential transaction leak du… [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 opened a new pull request, #3699: URL: https://github.com/apache/flink-cdc/pull/3699 …ring MySQL snapshot phase (#3602) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Resolved] (FLINK-36247) Potential transaction leak during MySQL snapshot phase

2024-11-07 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang resolved FLINK-36247. --- Resolution: Fixed master(3.3-SNAPSHOT):d5f1b9ace82f91bbf16aa8ec56a29b7fb0456c0b > Potential transac

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
GOODBOY008 commented on code in PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#discussion_r1833740746 ## .github/workflows/flink_cdc_migration_test.yml: ## @@ -28,7 +28,7 @@ jobs: submodules: true - uses: actions/setup-java@v4 with: -

Re: [PR] [FLINK-36247][cdc-connector] Fix potential transaction leak during MySQL snapshot phase [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3602: URL: https://github.com/apache/flink-cdc/pull/3602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[jira] [Updated] (FLINK-36674) Flink will not commit to kafka if checkpointing is not enabled

2024-11-07 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slankka updated FLINK-36674: Description: background: recently I found that _Flink-sql-connector-kafka-1.13.5_ kafka source DDL style,

[jira] [Updated] (FLINK-36674) Flink will not commit to kafka if checkpointing is not enabled

2024-11-07 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slankka updated FLINK-36674: Description: background: recently I found that _Flink-sql-connector-kafka-1.13.5_ kafka source DDL style,

[jira] [Updated] (FLINK-36674) Flink will not commit to kafka if checkpointing is not enabled

2024-11-07 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] slankka updated FLINK-36674: Summary: Flink will not commit to kafka if checkpointing is not enabled (was: Flink will not commit if ch

[jira] [Created] (FLINK-36674) Flink will not commit if checkpointing is not enabled

2024-11-07 Thread slankka (Jira)
slankka created FLINK-36674: --- Summary: Flink will not commit if checkpointing is not enabled Key: FLINK-36674 URL: https://issues.apache.org/jira/browse/FLINK-36674 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-20114) Fix a few KafkaSource-related bugs

2024-11-07 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896560#comment-17896560 ] slankka commented on FLINK-20114: - [~becket_qin]  may I ask two questions? background:

Re: [PR] [FLINK-36282][pipeline-connector][cdc-connector][mysql]fix incorrect data type of TINYINT(1) in mysql pipeline connector [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 commented on code in PR #3608: URL: https://github.com/apache/flink-cdc/pull/3608#discussion_r1833670840 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigne

[jira] [Commented] (FLINK-35792) Sorting by proctime does not work in rank

2024-11-07 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896555#comment-17896555 ] xuyang commented on FLINK-35792: [~jhughes] There are five functions in Rank: AppendOnly

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on code in PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#discussion_r1833645373 ## .github/workflows/flink_cdc_migration_test.yml: ## @@ -28,7 +28,7 @@ jobs: submodules: true - uses: actions/setup-java@v4 with: -

Re: [PR] [BP-3.2][FLINK-36221] Add `CAST ... AS ...` documentations [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3694: URL: https://github.com/apache/flink-cdc/pull/3694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[jira] [Commented] (FLINK-36015) Align rescale parameters

2024-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896544#comment-17896544 ] Rui Fan commented on FLINK-36015: - {quote}- Parameter `jobmanager.adaptive-scheduler.max

[jira] [Commented] (FLINK-36221) Add specification about CAST ... AS ... built-in functions

2024-11-07 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896551#comment-17896551 ] Ruan Hang commented on FLINK-36221: --- release-3.2: 722eb2e76a85e0a2b2911b8c6ba55a16215d

Re: [PR] [FLINK-36635][runtime] Remove PhysicalSlotRequestBulkImpl as it is not used [flink]

2024-11-07 Thread via GitHub
eemario commented on PR #25596: URL: https://github.com/apache/flink/pull/25596#issuecomment-2463645061 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-36015) Align rescale parameters

2024-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-36015: Release Note: FLIP-472 aligns timeout logic in AdaptiveScheduler states. To make alignment more clear to

[jira] (FLINK-36015) Align rescale parameters

2024-11-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36015 ] Rui Fan deleted comment on FLINK-36015: - was (Author: fanrui): {quote}- Parameter `jobmanager.adaptive-scheduler.max-delay-for-scale-trigger` was renamed to the `jobmanager.adaptive-scheduler.re

[jira] [Commented] (FLINK-35792) Sorting by proctime does not work in rank

2024-11-07 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896540#comment-17896540 ] Jim Hughes commented on FLINK-35792: [~xuyangzhong] Sounds like between 3.1 and 3.2,

[jira] [Commented] (FLINK-36417) STATE_TTL doesn't work with WatermarkAssigner

2024-11-07 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896537#comment-17896537 ] xuyang commented on FLINK-36417: Thanks for the quick ports(y) > STATE_TTL doesn't work

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463611452 CI failure,It seems that this PR(https://github.com/apache/flink-cdc/pull/3696) should be merged first -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Commented] (FLINK-35792) Sorting by proctime does not work in rank

2024-11-07 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896533#comment-17896533 ] xuyang commented on FLINK-35792: [~jhughes] Regarding 3.2, yes, we need to at least make

[jira] [Commented] (FLINK-35792) Sorting by proctime does not work in rank

2024-11-07 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896513#comment-17896513 ] Jim Hughes commented on FLINK-35792: Hi [~xuyangzhong], thank you for the context!

Re: [PR] [FLINK-35360] Submit Flink CDC pipeline job yarn Application mode [flink-cdc]

2024-11-07 Thread via GitHub
github-actions[bot] commented on PR #3366: URL: https://github.com/apache/flink-cdc/pull/3366#issuecomment-2463458855 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [minor][test] Remove duplicate test code [flink-cdc]

2024-11-07 Thread via GitHub
github-actions[bot] commented on PR #3460: URL: https://github.com/apache/flink-cdc/pull/3460#issuecomment-2463458749 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-35360] Submit Flink CDC pipeline job yarn Application mode [flink-cdc]

2024-11-07 Thread via GitHub
github-actions[bot] closed pull request #3366: [FLINK-35360] Submit Flink CDC pipeline job yarn Application mode URL: https://github.com/apache/flink-cdc/pull/3366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Created] (FLINK-36673) Operator is not properly handling failed deployments without savepoints

2024-11-07 Thread Yaroslav Tkachenko (Jira)
Yaroslav Tkachenko created FLINK-36673: -- Summary: Operator is not properly handling failed deployments without savepoints Key: FLINK-36673 URL: https://issues.apache.org/jira/browse/FLINK-36673 P

Re: [PR] [FLINK-35414] Rework last-state upgrade mode to support job cancellation as suspend mechanism [flink-kubernetes-operator]

2024-11-07 Thread via GitHub
sap1ens commented on PR #871: URL: https://github.com/apache/flink-kubernetes-operator/pull/871#issuecomment-2463446748 @gyfora FYI, I think I found a regression: https://issues.apache.org/jira/browse/FLINK-36673 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25623: URL: https://github.com/apache/flink/pull/25623#issuecomment-2463118913 ## CI report: * fb4ed527c0c31f58b7022d083449245d1936f0c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-36417) STATE_TTL doesn't work with WatermarkAssigner

2024-11-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896462#comment-17896462 ] Sergey Nuyanzin commented on FLINK-36417: - [~xuyangzhong] I created 2 PRs 1.19:

[PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin opened a new pull request, #25623: URL: https://github.com/apache/flink/pull/25623 This is a cherry-pick of https://github.com/apache/flink/commit/4101316ef37d3a7082bff57cb732f4e9e0349d09 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [BP-1.20][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25622: URL: https://github.com/apache/flink/pull/25622#issuecomment-2463111350 ## CI report: * a80b23046e5f37b007b5bdd13b8dabcbfac02eae UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.20][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin opened a new pull request, #25622: URL: https://github.com/apache/flink/pull/25622 This is a cherry-pick of https://github.com/apache/flink/commit/4101316ef37d3a7082bff57cb732f4e9e0349d09 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin closed pull request #25621: [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner URL: https://github.com/apache/flink/pull/25621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin opened a new pull request, #25621: URL: https://github.com/apache/flink/pull/25621 This is a cherr0pick of https://github.com/apache/flink/commit/4101316ef37d3a7082bff57cb732f4e9e0349d09 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
nicusX commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833225006 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

[PR] [bp release-3.2][FLINK-36211][pipeline-connector/kafka] shade org.apache.flink.streaming.connectors.kafka to avoid conflict with flink-connector-kafka jar. (#3595) [flink-cdc]

2024-11-07 Thread via GitHub
lvyanquan opened a new pull request, #3697: URL: https://github.com/apache/flink-cdc/pull/3697 cherry picked from commit f24399cf5a32f4c79bbb6a86e3a3399f17bfbbe0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832523859 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833155289 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833158443 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833163366 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -57,16 +87,21 @@ CREATE TABLE KinesisTable ( PARTITIONED BY (user_id, item_id) WITH ( 'connecto

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833159382 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833158725 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833158015 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833157483 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833156129 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833154045 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -57,16 +87,21 @@ CREATE TABLE KinesisTable ( PARTITIONED BY (user_id, item_id) WITH ( 'connecto

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833153362 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -40,10 +40,40 @@ Dependencies The Kinesis connector is not part of the binary distribution. See ho

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832536416 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832519329 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
nicusX commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833085942 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -57,16 +87,21 @@ CREATE TABLE KinesisTable ( PARTITIONED BY (user_id, item_id) WITH ( 'connector'

  1   2   >