[jira] [Commented] (FLINK-36291) java.lang.IllegalMonitorStateException causing a fatal error on the TaskManager side

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882275#comment-17882275 ] Matthias Pohl commented on FLINK-36291: --- The jobs of the two Jira issues FLINK-362

[jira] [Created] (FLINK-36291) java.lang.IllegalMonitorStateException causing a fatal error on the TaskManager side

2024-09-16 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-36291: - Summary: java.lang.IllegalMonitorStateException causing a fatal error on the TaskManager side Key: FLINK-36291 URL: https://issues.apache.org/jira/browse/FLINK-36291

[jira] [Commented] (FLINK-36166) testJoinDisorderChangeLog failed on AZP

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882270#comment-17882270 ] Matthias Pohl commented on FLINK-36166: --- https://dev.azure.com/apache-flink/apache

[jira] [Comment Edited] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882269#comment-17882269 ] Matthias Pohl edited comment on FLINK-35810 at 9/17/24 6:43 AM: --

[jira] [Commented] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882269#comment-17882269 ] Matthias Pohl commented on FLINK-35810: --- https://dev.azure.com/apache-flink/apache

[jira] [Updated] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-35810: -- Affects Version/s: 2.0-preview (was: 2.0.0) > AsyncWaitOperatorTest

[jira] [Updated] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-35810: -- Priority: Critical (was: Major) > AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUno

[jira] [Updated] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-35810: -- Labels: test-stability (was: ) > AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnor

[jira] [Commented] (FLINK-36290) OutOfMemoryError in connect test run

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882267#comment-17882267 ] Matthias Pohl commented on FLINK-36290: --- [~Weijie Guo] reported a OOM in FLINK-358

[jira] [Created] (FLINK-36290) OutOfMemoryError in connect test run

2024-09-16 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-36290: - Summary: OutOfMemoryError in connect test run Key: FLINK-36290 URL: https://issues.apache.org/jira/browse/FLINK-36290 Project: Flink Issue Type: Bug

[jira] [Resolved] (FLINK-36281) resourceSpec replace SlotSharingGroupUtils.extractResourceSpec(slotSharingGroup)

2024-09-16 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-36281. - Fix Version/s: 2.0-preview (was: 2.0.0) Assignee: Caican Cai Resol

Re: [PR] [FLINK-36281][runtime] resourceSpec replace SlotSharingGroupUtils.extractResourceSpec(slotSharingGroup) [flink]

2024-09-16 Thread via GitHub
1996fanrui merged PR #25333: URL: https://github.com/apache/flink/pull/25333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2354460790 @AHeise Thanks for the feedback. I've left some comments and made updates. Please have a look. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2354458757 > Seems like the deleted arch unit rule was still needed. What was your intent when you deleted it? It was automatically deleted after running `mvn clean verify` lo

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762233642 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumin

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762233642 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumin

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762220365 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java: ## @@ -188,6 +190,66 @@ public void tes

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
dongwoo6kim commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1762219777 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java: ## @@ -369,6 +370,38 @@ public void testConsumin

Re: [PR] Use Schema#newBuilder instead of TableSchema#fromResolvedSchema [flink-cdc]

2024-09-16 Thread via GitHub
github-actions[bot] commented on PR #2061: URL: https://github.com/apache/flink-cdc/pull/2061#issuecomment-2354238716 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2024-09-16 Thread via GitHub
github-actions[bot] commented on PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2354238674 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2024-09-16 Thread via GitHub
flinkbot commented on PR #25343: URL: https://github.com/apache/flink/pull/25343#issuecomment-2353927053 ## CI report: * d723c7beb1d7734f8353c467109e8a4a8251438d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
rmetzger commented on PR #25342: URL: https://github.com/apache/flink/pull/25342#issuecomment-2353900424 Thanks. Overall, I think the tone is a bit too much like a blog post, and a not enough like a documentation that you use as a reference. -- This is an automated message from the Apache

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
rmetzger commented on code in PR #25342: URL: https://github.com/apache/flink/pull/25342#discussion_r1761871634 ## docs/content/docs/deployment/java_compatibility.md: ## @@ -50,7 +50,8 @@ The following Flink features have not been tested with Java 11: ## Java 17 -Experimen

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
rmetzger commented on code in PR #25342: URL: https://github.com/apache/flink/pull/25342#discussion_r1761865441 ## docs/content/docs/deployment/java_compatibility.md: ## @@ -50,7 +50,8 @@ The following Flink features have not been tested with Java 11: ## Java 17 -Experimen

[PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2024-09-16 Thread via GitHub
TomiFG opened a new pull request, #25343: URL: https://github.com/apache/flink/pull/25343 Fix python example variable `t_env` being mistakenly referenced as `tableEnv`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Closed] (FLINK-32377) 2.0 Breaking REST API changes

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-32377. - Assignee: Matthias Pohl (was: Chesnay Schepler) Resolution: Fixed > 2.0 Breaking REST API

[jira] [Updated] (FLINK-36147) Removes deprecated location field

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36147: -- Parent: FLINK-32377 Issue Type: Sub-task (was: Technical Debt) > Removes deprecated l

[jira] [Comment Edited] (FLINK-14068) Use Java's Duration instead of Flink's Time

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882175#comment-17882175 ] Matthias Pohl edited comment on FLINK-14068 at 9/16/24 7:44 PM: --

[jira] [Comment Edited] (FLINK-14068) Use Java's Duration instead of Flink's Time

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882175#comment-17882175 ] Matthias Pohl edited comment on FLINK-14068 at 9/16/24 7:44 PM: --

[jira] [Commented] (FLINK-14068) Use Java's Duration instead of Flink's Time

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882175#comment-17882175 ] Matthias Pohl commented on FLINK-14068: --- *  {{master}}: ** [153614716767d5fb8be1

[jira] [Comment Edited] (FLINK-14068) Use Java's Duration instead of Flink's Time

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882175#comment-17882175 ] Matthias Pohl edited comment on FLINK-14068 at 9/16/24 7:43 PM: --

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
XComp merged PR #25250: URL: https://github.com/apache/flink/pull/25250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
XComp commented on PR #25250: URL: https://github.com/apache/flink/pull/25250#issuecomment-2353308496 force-pushed a rebase to master after FLINK-36279 was merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Resolved] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots which causes problems in Executing state

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-36279. --- Fix Version/s: 2.0-preview Resolution: Fixed master: [0731f4f1e122fb4e675464380300e7

Re: [PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

2024-09-16 Thread via GitHub
XComp merged PR #25341: URL: https://github.com/apache/flink/pull/25341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761393374 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java: ## @@ -476,11 +578,12 @@ public CatalogFunction getFunction(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761390457 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1341,6 +1352,293 @@ private void dropTableInternal(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761332241 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1341,6 +1352,293 @@ private void dropTableInternal(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761329016 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -1341,6 +1352,293 @@ private void dropTableInternal(

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761326715 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -888,7 +899,7 @@ public Set listSchemas() { * NOTE:It is

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-09-16 Thread via GitHub
jnh5y commented on code in PR #25211: URL: https://github.com/apache/flink/pull/25211#discussion_r1761325334 ## flink-python/pyflink/table/catalog.py: ## @@ -15,9 +15,8 @@ # See the License for the specific language governing permissions and # limitations under the License.

[PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff strategoes [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian opened a new pull request, #165: URL: https://github.com/apache/flink-connector-aws/pull/165 ## Purpose of the change Port over Kinesis Client configurations for retry and backoff ## Verifying this change - *Added unit tests* ## Significant changes *(Pl

Re: [PR] [FLINK-36278] Reduce log size by avoiding container logs by default [flink-connector-kafka]

2024-09-16 Thread via GitHub
fapaul commented on PR #119: URL: https://github.com/apache/flink-connector-kafka/pull/119#issuecomment-2353092492 Looking at the current test failures of this PR the log size (https://github.com/apache/flink-connector-kafka/actions/runs/10881066111/job/30189211552?pr=119) is still 50MB+.

Re: [PR] [FLINK-31980] Implement support for EFO in Kinesis consumer [flink-connector-aws]

2024-09-16 Thread via GitHub
dzikosc commented on code in PR #76: URL: https://github.com/apache/flink-connector-aws/pull/76#discussion_r1761179807 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/StreamConsumerRegistrar.java:

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian commented on code in PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#discussion_r1758962947 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java: ## @@ -226,4 +

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian commented on code in PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#discussion_r1761182118 ## flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/config/AWSConfigOptions.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff [flink-connector-aws]

2024-09-16 Thread via GitHub
karubian commented on code in PR #150: URL: https://github.com/apache/flink-connector-aws/pull/150#discussion_r1761179260 ## flink-connector-aws-base/pom.xml: ## @@ -87,6 +87,12 @@ under the License. test + +software.amazon.awssdk +

Re: [PR] [FLINK-31980] Implement support for EFO in Kinesis consumer [flink-connector-aws]

2024-09-16 Thread via GitHub
dzikosc commented on code in PR #76: URL: https://github.com/apache/flink-connector-aws/pull/76#discussion_r1760919190 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java: ## @@ -178,6 +185

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-16 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2352836545 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
flinkbot commented on PR #25342: URL: https://github.com/apache/flink/pull/25342#issuecomment-2352764203 ## CI report: * ba05a7d2ae38b1c1e4219978cbaae3ae6737b252 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [docs] Update Java 17 compatibility docs [flink]

2024-09-16 Thread via GitHub
mbalassi opened a new pull request, #25342: URL: https://github.com/apache/flink/pull/25342 Updates docs to match current state. In practice we already see usage with Java 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
XComp commented on PR #25250: URL: https://github.com/apache/flink/pull/25250#issuecomment-2352724292 Thanks for picking this one up, @zentol . I addressed you one change request and will squash-merge the PR after another CI run. The current CI failure is related to FLINK-36279. --

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
XComp commented on code in PR #25250: URL: https://github.com/apache/flink/pull/25250#discussion_r1761017539 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/conversion/DayTimeIntervalDurationConverter.java: ## @@ -40,6 +38,6 @@ public Long toInternal

[jira] [Updated] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots which causes problems in Executing state

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Summary: AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots which cause

[jira] [Updated] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Description: FLINK-36014 aligned the triggering of the execution graph creation in {{WaitingF

[jira] [Updated] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Priority: Blocker (was: Major) > AdaptiveScheduler#hasDesiredResources doesn't rely on all av

[jira] [Commented] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882013#comment-17882013 ] Matthias Pohl commented on FLINK-36279: --- I updated the Jira issue description acco

[jira] [Updated] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Labels: pull-request-available (was: pull-request-available test-stability) > AdaptiveSchedul

[jira] [Updated] (FLINK-36279) AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Summary: AdaptiveScheduler#hasDesiredResources doesn't rely on all available slots (was: Resc

[jira] [Updated] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Attachment: FLINK-36279-FLINK-36014-pr.success.log > RescaleOnCheckpointITCase.testRescaleOnCh

[jira] [Commented] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881999#comment-17881999 ] Matthias Pohl commented on FLINK-36279: --- I verified that we see the same behavior

[jira] [Commented] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881996#comment-17881996 ] Matthias Pohl commented on FLINK-36279: --- Actually, I was able to extract the logs

[jira] [Updated] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36279: -- Attachment: FLINK-36279.20240914.6.success.log FLINK-36279.fixed.success.log >

[jira] [Comment Edited] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881992#comment-17881992 ] Matthias Pohl edited comment on FLINK-36279 at 9/16/24 10:57 AM: -

[jira] [Commented] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881992#comment-17881992 ] Matthias Pohl commented on FLINK-36279: --- hm, the only reason I can come up with wh

Re: [PR] [FLINK-33137] Prometheus connector docs [flink-connector-prometheus]

2024-09-16 Thread via GitHub
nicusX commented on PR #3: URL: https://github.com/apache/flink-connector-prometheus/pull/3#issuecomment-2352584992 Docs preview [docs-preview.pdf](https://github.com/user-attachments/files/17011722/docs-preview.pdf) -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-16 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2352576092 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-09-16 Thread via GitHub
XComp commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1760917678 ## flink-tests/src/test/resources/log4j2-test.properties: ## @@ -28,7 +28,7 @@ appender.testlogger.name = TestLogger appender.testlogger.type = CONSOLE appender.testlog

Re: [PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

2024-09-16 Thread via GitHub
flinkbot commented on PR #25341: URL: https://github.com/apache/flink/pull/25341#issuecomment-2352567696 ## CI report: * cc517ad64bbcfc2fd58e414a8016a29420e20693 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure [flink]

2024-09-16 Thread via GitHub
ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352544028 > > PortRange is general utility class that makes the NetUtils#getPortRangeFromString a bit more user-friendly so I think it makes sense to move them into the same module. > >

[jira] [Comment Edited] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881982#comment-17881982 ] Matthias Pohl edited comment on FLINK-36279 at 9/16/24 10:21 AM: -

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
zentol commented on code in PR #25250: URL: https://github.com/apache/flink/pull/25250#discussion_r1760835206 ## flink-python/src/test/java/org/apache/flink/streaming/api/utils/ProtoUtilsTest.java: ## @@ -82,7 +80,7 @@ void testParseStateTtlConfigFromProto() {

Re: [PR] [FLINK-14068][core] Removes deprecated org.apache.flink.api.common.time.Time [flink]

2024-09-16 Thread via GitHub
zentol commented on code in PR #25250: URL: https://github.com/apache/flink/pull/25250#discussion_r1760877588 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/conversion/DayTimeIntervalDurationConverter.java: ## @@ -40,6 +38,6 @@ public Long toInterna

[jira] [Updated] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36279: --- Labels: pull-request-available test-stability (was: test-stability) > RescaleOnCheckpointIT

[PR] [FLINK-36279][runtime] Making desired resources being calculated based on all available slots for the job [flink]

2024-09-16 Thread via GitHub
XComp opened a new pull request, #25341: URL: https://github.com/apache/flink/pull/25341 ## What is the purpose of the change FLINK-36014 aligned the triggering of the `CreateExecutionGraph` state within `WaitingForResources` and `Executing` state. Before that change, only `WaitingFo

[jira] [Updated] (FLINK-36289) Create Prometheus Flink connector release

2024-09-16 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-36289: Description: Update the Flink -docs [https://github.com/apache/flink/tree/master/docs]  

[jira] [Created] (FLINK-36289) Create Prometheus Flink connector release

2024-09-16 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-36289: --- Summary: Create Prometheus Flink connector release Key: FLINK-36289 URL: https://issues.apache.org/jira/browse/FLINK-36289 Project: Flink Issue Type: S

[jira] [Created] (FLINK-36288) Set up architectural test

2024-09-16 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-36288: --- Summary: Set up architectural test Key: FLINK-36288 URL: https://issues.apache.org/jira/browse/FLINK-36288 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure [flink]

2024-09-16 Thread via GitHub
eon2208 commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352446196 > PortRange is general utility class that makes the NetUtils#getPortRangeFromString a bit more user-friendly so I think it makes sense to move them into the same module. Strongly a

[jira] [Comment Edited] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881982#comment-17881982 ] Matthias Pohl edited comment on FLINK-36279 at 9/16/24 9:37 AM: --

[jira] [Comment Edited] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881982#comment-17881982 ] Matthias Pohl edited comment on FLINK-36279 at 9/16/24 9:36 AM: --

[jira] [Commented] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881982#comment-17881982 ] Matthias Pohl commented on FLINK-36279: --- The issue is caused by the alignment of d

Re: [PR] Add docs and config entry for default log level config setting [flink]

2024-09-16 Thread via GitHub
davidradl commented on code in PR #25290: URL: https://github.com/apache/flink/pull/25290#discussion_r1760820564 ## flink-dist/src/main/resources/config.yaml: ## @@ -22,6 +22,9 @@ env: java: opts: all: --add-exports=java.base/sun.net.util=ALL-UNNAMED --add-export

Re: [PR] Add docs and config entry for default log level config setting [flink]

2024-09-16 Thread via GitHub
davidradl commented on code in PR #25290: URL: https://github.com/apache/flink/pull/25290#discussion_r1760819433 ## docs/content/docs/deployment/advanced/logging.md: ## @@ -67,6 +67,8 @@ The Flink distribution ships with the following log4j properties files in the `c Log4j per

[jira] [Created] (FLINK-36287) Sink with topologies should not participate in UC

2024-09-16 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-36287: --- Summary: Sink with topologies should not participate in UC Key: FLINK-36287 URL: https://issues.apache.org/jira/browse/FLINK-36287 Project: Flink Issue Type: B

Re: [PR] [FLINK-36192][autocaler] Autocaler supports adjusting the parallelism of source vertex based on the number of partitions in Kafka or pulsars [flink-kubernetes-operator]

2024-09-16 Thread via GitHub
mxm commented on code in PR #879: URL: https://github.com/apache/flink-kubernetes-operator/pull/879#discussion_r1760807867 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -389,15 +407,61 @@ protected static int scale( retur

Re: [PR] [FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure [flink]

2024-09-16 Thread via GitHub
ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352393745 > Using the PortRange as a domain wrapper for the ports seems like a good choice. The question is whether adding the extra dependency to the `flink-metrics-prometheus` module for the

Re: [PR] [FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure [flink]

2024-09-16 Thread via GitHub
eon2208 commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352331809 Using the PortRange as a domain wrapper for the ports seems like a good choice. The question is whether adding the extra dependency to the `flink-metrics-prometheus` module for the single

[jira] [Updated] (FLINK-36278) Fix Kafka connector logs getting too big

2024-09-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36278: --- Labels: pull-request-available (was: ) > Fix Kafka connector logs getting too big > ---

[PR] [FLINK-36278] Reduce log size by avoiding container logs by default [flink-connector-kafka]

2024-09-16 Thread via GitHub
AHeise opened a new pull request, #119: URL: https://github.com/apache/flink-connector-kafka/pull/119 Currently, container logs appear under an o.a.f logger and thus are visible on CI. This results in compressed log size >40MB for a run and often leads to download errors. This PR rer

[jira] [Assigned] (FLINK-36279) RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails

2024-09-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-36279: - Assignee: Matthias Pohl > RescaleOnCheckpointITCase.testRescaleOnCheckpoint fails > ---

[PR] [FLINK-36286][Connectors/Prometheus] Set up validation workflows [flink-connector-prometheus]

2024-09-16 Thread via GitHub
hlteoh37 opened a new pull request, #6: URL: https://github.com/apache/flink-connector-prometheus/pull/6 ## Purpose of the change - Set up Github validation workflows on PR and nightly - Set up boring-cyborg for PR formatting validation - Set up PR template ## Verifying th

[jira] [Updated] (FLINK-36286) Set up validation workflows

2024-09-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36286: --- Labels: pull-request-available (was: ) > Set up validation workflows >

[jira] [Updated] (FLINK-36286) Set up validation workflows

2024-09-16 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-36286: Summary: Set up validation workflows (was: Set up pull request template) > Set up validat

[jira] [Created] (FLINK-36286) Set up pull request template

2024-09-16 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-36286: --- Summary: Set up pull request template Key: FLINK-36286 URL: https://issues.apache.org/jira/browse/FLINK-36286 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure [flink]

2024-09-16 Thread via GitHub
ferenc-csaky commented on PR #25339: URL: https://github.com/apache/flink/pull/25339#issuecomment-2352245005 One other alternative would be to initialize a `PortRange` in the factory and pass that object in the `PrometheusReporter` ctor. `PortRange` stores the original original string confi

Re: [PR] [FLINK-36146][connector] Fix SingleThreadFetcherManager race condition [flink]

2024-09-16 Thread via GitHub
flinkbot commented on PR #25340: URL: https://github.com/apache/flink/pull/25340#issuecomment-2352211916 ## CI report: * 5bbb3742701cc9625054866f1ccf15cd5bce069d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
AHeise commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1760654197 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java: ## @@ -122,32 +122,32 @@ public Record

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
AHeise commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1760653304 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java: ## @@ -122,32 +122,32 @@ public Record

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-09-16 Thread via GitHub
AHeise commented on code in PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#discussion_r1760650597 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java: ## @@ -122,32 +122,32 @@ public Record

  1   2   >