XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1632637479
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Founda
Zakelly commented on code in PR #24904:
URL: https://github.com/apache/flink/pull/24904#discussion_r1632632895
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/Mail.java:
##
@@ -71,8 +77,13 @@ public Mail(
this.actionExecutor = acti
Zakelly commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1632623556
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##
@@ -307,18 +307,36 @@ void onProcessingTime(long time)
Zakelly commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1632622930
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java:
##
@@ -40,6 +40,15 @@
*/
@Internal
public interface
flinkbot commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2157312543
## CI report:
* 14cf0fc58dfb9553ffe703622b6223a54549aacd UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ammar-master opened a new pull request, #24919:
URL: https://github.com/apache/flink/pull/24919
## What is the purpose of the change
Additional configuration options for internal and REST SSL setup.
## Brief change log
* SSL configuration option for intern
master-ammar closed pull request #24918: [FLINK-35371][security] Add
configuration for SSL keystore and truststore type
URL: https://github.com/apache/flink/pull/24918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
flinkbot commented on PR #24918:
URL: https://github.com/apache/flink/pull/24918#issuecomment-2157270012
## CI report:
* db7977869fe099d7cf1cf428bec048e608dbdd60 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-35371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35371:
---
Labels: SSL pull-request-available (was: SSL)
> Allow the keystore and truststore type to c
master-ammar opened a new pull request, #24918:
URL: https://github.com/apache/flink/pull/24918
## What is the purpose of the change
Additional configuration options for internal and REST SSL setup.
## Brief change log
* SSL configuration option for in
superdiaodiao commented on PR #24773:
URL: https://github.com/apache/flink/pull/24773#issuecomment-2157065404
> Thanks for the contribution @superdiaodiao
> thanks for the review @HuangXingBo , @davidradl
>
> it looks ok to me, I will test it a bit more and in case of succeed will
vahmed-hamdy commented on PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#issuecomment-2156823709
@jeyhunkarimov thanks for the feedback, I added a negative test as well
@snuyanzin Thanks for the review, All comments addressed as well
--
This is an automated m
snuyanzin commented on PR #24773:
URL: https://github.com/apache/flink/pull/24773#issuecomment-2156817722
Thanks for the contribution @superdiaodiao
thanks for the review @HuangXingBo , @davidradl
it looks ok to me, I will test it a bit more and in case of succeed will
merge it
[
https://issues.apache.org/jira/browse/FLINK-35520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853540#comment-17853540
]
Sergey Nuyanzin commented on FLINK-35520:
-
That seem to be trickier than I thoug
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632401145
##
flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java:
##
@@ -20,1
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632400893
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,114 @@
+pa
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632400806
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,114 @@
+pa
snuyanzin commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632391517
##
flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java:
##
@@ -20,12 +
snuyanzin commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632391131
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,114 @@
+packa
snuyanzin commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632390729
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,114 @@
+packa
snuyanzin commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632390518
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,115 @@
+packa
snuyanzin commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632390394
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,114 @@
+packa
19priyadhingra commented on code in PR #141:
URL:
https://github.com/apache/flink-connector-aws/pull/141#discussion_r1632385233
##
flink-connector-aws/flink-connector-sqs/src/main/java/org.apache.flink.connector.sqs/sink/SqsSinkWriter.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed
19priyadhingra commented on code in PR #141:
URL:
https://github.com/apache/flink-connector-aws/pull/141#discussion_r1632370742
##
flink-connector-aws/flink-connector-sqs/src/main/java/org.apache.flink.connector.sqs/sink/SqsConfigConstants.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Lice
jeyhunkarimov commented on PR #24725:
URL: https://github.com/apache/flink/pull/24725#issuecomment-2156736006
Hi @reswqa thanks a lot for the review. Could you please do another pass in
your available time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to
LadyForest commented on code in PR #24889:
URL: https://github.com/apache/flink/pull/24889#discussion_r1632297334
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/LookupJoinHintOptions.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache S
[
https://issues.apache.org/jira/browse/FLINK-34108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853489#comment-17853489
]
chesterxu edited comment on FLINK-34108 at 6/9/24 12:34 PM:
[
https://issues.apache.org/jira/browse/FLINK-34108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853489#comment-17853489
]
chesterxu commented on FLINK-34108:
---
[~martijnvisser] Please take a CR, thanks!
> Ad
[
https://issues.apache.org/jira/browse/FLINK-35560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dongwoo.kim updated FLINK-35560:
Description:
h3. Summary
Hello I'd like to suggest query validator support in flink sql gateway v
[
https://issues.apache.org/jira/browse/FLINK-35560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dongwoo.kim updated FLINK-35560:
Description:
h3. Summary
Hello I'd like to suggest query validator support in flink sql gateway v
[
https://issues.apache.org/jira/browse/FLINK-35560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dongwoo.kim updated FLINK-35560:
Description:
h3. Summary
Hello I'd like to suggest query validator support in flink sql gateway v
dongwoo.kim created FLINK-35560:
---
Summary: Add query validator support to flink sql gateway via spi
pattern
Key: FLINK-35560
URL: https://issues.apache.org/jira/browse/FLINK-35560
Project: Flink
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632243987
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java:
##
@@ -36,27 +40,50 @@
im
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632243692
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java:
##
@@ -36,27 +40,50 @@
im
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632243045
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,115 @@
+pa
vahmed-hamdy commented on code in PR #28:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632242928
##
flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java:
##
@@ -0,0 +1,115 @@
+pa
nicusX commented on PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2156438875
Addressed the latest comments and ported AMP signer to AWS SDKv2 (!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-35138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853470#comment-17853470
]
Tamir Sagi commented on FLINK-35138:
Thank you Danny! highly appreciated it.
> Rele
[
https://issues.apache.org/jira/browse/FLINK-35138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853470#comment-17853470
]
Tamir Sagi edited comment on FLINK-35138 at 6/9/24 7:45 AM:
[
https://issues.apache.org/jira/browse/FLINK-35138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853471#comment-17853471
]
Tamir Sagi commented on FLINK-35138:
Thank you Danny! highly appreciated.
> Release
[ https://issues.apache.org/jira/browse/FLINK-35138 ]
Tamir Sagi deleted comment on FLINK-35138:
was (Author: JIRAUSER283777):
Thank you Danny! highly appreciated.
> Release flink-connector-kafka v3.2.0 for Flink 1.19
>
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632187848
##
README.md:
##
@@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework
with powerful stream-
Learn more about Flink at
[https://
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632194796
##
amp-request-signer/README.md:
##
@@ -0,0 +1,31 @@
+## Request Signer for Amazon Managed Prometheus (AMP)
+
+Request signer implementation for Amazon Man
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632194645
##
README.md:
##
@@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework
with powerful stream-
Learn more about Flink at
[https://
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632188645
##
README.md:
##
@@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework
with powerful stream-
Learn more about Flink at
[https://
45 matches
Mail list logo
