[
https://issues.apache.org/jira/browse/FLINK-33859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated FLINK-33859:
Affects Version/s: (was: opensearch-1.2.0)
> Support OpenSearch v2
> -
[
https://issues.apache.org/jira/browse/FLINK-33859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated FLINK-33859:
Affects Version/s: opensearch-1.1.0
> Support OpenSearch v2
> -
>
>
[
https://issues.apache.org/jira/browse/FLINK-34108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845659#comment-17845659
]
chesterxu edited comment on FLINK-34108 at 5/12/24 2:35 AM:
nicusX commented on PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2106039721
I addressed all comments, except those I explained why I didn't.
Also, now upgraded to Flink 1.18 and newer AsyncSinkBase API.
I cannot split AMP signer and connector
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597510944
##
amp-request-signer/pom.xml:
##
@@ -0,0 +1,58 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
vahmed-hamdy commented on code in PR #141:
URL:
https://github.com/apache/flink-connector-aws/pull/141#discussion_r1597498488
##
flink-connector-aws/pom.xml:
##
@@ -18,8 +18,8 @@ specific language governing permissions and limitations
under the License.
-->
http://maven.apac
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597510275
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed
snuyanzin merged PR #46:
URL: https://github.com/apache/flink-connector-opensearch/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
snuyanzin commented on PR #46:
URL:
https://github.com/apache/flink-connector-opensearch/pull/46#issuecomment-2106034504
proof link to green nightly
https://github.com/apache/flink-connector-opensearch/actions/runs/9046382776
--
This is an automated message from the Apache Git Service.
T
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597508286
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the A
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597505926
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the A
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597488570
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597488524
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597488453
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597486440
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java:
##
@@ -0,0 +1,76 @@
+/*
+ *
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597482298
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java:
##
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the A
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597479531
##
prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializerTest.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597479280
##
msf-amp-example/README.md:
##
@@ -0,0 +1,68 @@
+## Sample application: Amazon Managed Service for Apache Flink and Amazon
Managed Prometheus
Review Co
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597478707
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/prometheus/Remote.java:
##
@@ -0,0 +1,6661 @@
+/*
Review Comment:
I th
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597475338
##
amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerForAuthorizationHeader.java:
##
@@ -0,0 +1,124 @@
+/*
+ * Lic
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597473538
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSink.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597458387
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/HttpResponseCallback.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the A
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597456357
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/HttpResponseCallback.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/FLINK-35198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu resolved FLINK-35198.
---
Resolution: Fixed
> Support the execution of refresh materialized table
> --
[
https://issues.apache.org/jira/browse/FLINK-35198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845610#comment-17845610
]
dalongliu commented on FLINK-35198:
---
Merged in master: 9fe8d7bf870987bf43bad63078e2590
lsyldliu merged PR #24760:
URL: https://github.com/apache/flink/pull/24760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
1996fanrui commented on PR #24652:
URL: https://github.com/apache/flink/pull/24652#issuecomment-2105732689
It seems reverting it doesn't make sense, I close this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
1996fanrui closed pull request #24652: [FLINK-35040] Revert `commons-io` to
2.11.0
URL: https://github.com/apache/flink/pull/24652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
[
https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan resolved FLINK-35041.
-
Fix Version/s: 1.20.0
Resolution: Fixed
IIUC, this issue has been fixed in master branch, so I w
[
https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845606#comment-17845606
]
Rui Fan commented on FLINK-35041:
-
Merged to master (1.20.0) via: 86c8304d735581518ce66
1996fanrui merged PR #24770:
URL: https://github.com/apache/flink/pull/24770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
1996fanrui commented on PR #24770:
URL: https://github.com/apache/flink/pull/24770#issuecomment-2105730845
Thanks for the review!
CI is green, merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
1996fanrui merged PR #24772:
URL: https://github.com/apache/flink/pull/24772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
1996fanrui commented on PR #24772:
URL: https://github.com/apache/flink/pull/24772#issuecomment-2105730686
Thanks for the quick review!
CI is green, mergeing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
leonardBang merged PR #3314:
URL: https://github.com/apache/flink-cdc/pull/3314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink
masteryhx commented on code in PR #24770:
URL: https://github.com/apache/flink/pull/24770#discussion_r1597415073
##
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/metadata/CheckpointTestUtils.java:
##
@@ -343,7 +343,11 @@ private static StreamStateHandle
create
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597414330
##
prometheus-connector/README.md:
##
@@ -0,0 +1,189 @@
+## Flink Prometheus connector (sink)
+
+Implementation of the Prometheus sink connector for DataSt
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597412742
##
prometheus-connector/README.md:
##
@@ -0,0 +1,189 @@
+## Flink Prometheus connector (sink)
+
+Implementation of the Prometheus sink connector for DataSt
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597412465
##
prometheus-connector/README.md:
##
@@ -0,0 +1,189 @@
+## Flink Prometheus connector (sink)
+
+Implementation of the Prometheus sink connector for DataSt
lsyldliu commented on code in PR #24765:
URL: https://github.com/apache/flink/pull/24765#discussion_r1597412228
##
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java:
##
@@ -197,6 +220,29 @@ void testCreateMat
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597412205
##
pom.xml:
##
@@ -0,0 +1,120 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:sc
nicusX commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597410882
##
pom.xml:
##
@@ -0,0 +1,120 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:sc
1996fanrui commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2105650954
> @1996fanrui PTAL
Thanks @GOODBOY008 for the ping, this PR is huge, I try to review it next
week.
--
This is an automated message from the Apache Git Service.
To respond to t
1996fanrui commented on PR #24670:
URL: https://github.com/apache/flink/pull/24670#issuecomment-2105650755
> @Jiabao-Sun @1996fanrui I will open hotfix to mater.
Sorry, I didn't notice it. I start fix it after I received the CI alert. 😂
--
This is an automated message from the Apach
GOODBOY008 commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2105650442
@1996fanrui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
flinkbot commented on PR #24772:
URL: https://github.com/apache/flink/pull/24772#issuecomment-2105650048
## CI report:
* 5a8d66f2dfcff0d756fa9d77285f135dadc00ab2 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
1996fanrui opened a new pull request, #24772:
URL: https://github.com/apache/flink/pull/24772
## What is the purpose of the change
The master branch cannot build success.
https://github.com/apache/flink/pull/24670 doesn't rebase the master branch
before merging, and other PR ad
hackergin commented on code in PR #24765:
URL: https://github.com/apache/flink/pull/24765#discussion_r1597406989
##
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java:
##
@@ -197,6 +220,29 @@ void testCreateMa
GOODBOY008 commented on PR #24670:
URL: https://github.com/apache/flink/pull/24670#issuecomment-2105648555
[workflow_dispatch](https://github.com/apache/flink/actions/runs/9042536161/job/24849180888#step:6:903)
--
This is an automated message from the Apache Git Service.
To respond to the
GOODBOY008 commented on PR #24670:
URL: https://github.com/apache/flink/pull/24670#issuecomment-2105648441
@Jiabao-Sun @1996fanrui I will open hotfix to mater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
hackergin commented on code in PR #24765:
URL: https://github.com/apache/flink/pull/24765#discussion_r1597406641
##
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java:
##
@@ -236,6 +282,150 @@ void testCreateM
[
https://issues.apache.org/jira/browse/FLINK-25537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845561#comment-17845561
]
Rui Fan commented on FLINK-25537:
-
Merged to master(1.20.0) via: 5af9acba5b9fbcdf9aadf62
1996fanrui merged PR #24670:
URL: https://github.com/apache/flink/pull/24670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
1996fanrui commented on PR #24770:
URL: https://github.com/apache/flink/pull/24770#issuecomment-2105643430
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
spoon-lz commented on PR #24461:
URL: https://github.com/apache/flink/pull/24461#issuecomment-2105643136
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ysmintor commented on PR #3310:
URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2105638144
Yes, I agree this refactoring. And is there any plan to add support Oracle,
PostgreSQL, OceanBase, etc into pipeline connectors ?
--
This is an automated message from the Apache Git
flinkbot commented on PR #24771:
URL: https://github.com/apache/flink/pull/24771#issuecomment-2105619645
## CI report:
* 77f15330f3056aaa256565f7fc800787598a6c6a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33892:
---
Labels: pull-request-available (was: )
> FLIP-383: Support Job Recovery from JobMaster Fail
JunRuiLee opened a new pull request, #24771:
URL: https://github.com/apache/flink/pull/24771
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them
xuyangzhong commented on code in PR #24760:
URL: https://github.com/apache/flink/pull/24760#discussion_r1597382234
##
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java:
##
@@ -236,6 +252,213 @@ void testCreat
xuyangzhong commented on code in PR #24760:
URL: https://github.com/apache/flink/pull/24760#discussion_r1597376170
##
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java:
##
@@ -161,14 +176,131 @@ pri
61 matches
Mail list logo
