Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1597372269 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -161,14 +176,131 @@ pri

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1597372269 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -161,14 +176,131 @@ pri

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1597372269 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -161,14 +176,131 @@ pri

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1597372269 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -161,14 +176,131 @@ pri

Re: [PR] [FLINK-35272][cdc][runtime] Transform projection & filter feature overhaul [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#issuecomment-2105596048 Thanks @aiwenmo for reviewing, addressed review comments above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [hotfix][docs] Fix dead links in documentations [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #3314: URL: https://github.com/apache/flink-cdc/pull/3314#issuecomment-2105593186 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [hotfix][docs] Fix dead links in documentations [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian opened a new pull request, #3314: URL: https://github.com/apache/flink-cdc/pull/3314 This PR fixes dead links brought by #3310. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [FLINK-35313][mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records … [flink-cdc]

2024-05-10 Thread via GitHub
yeezychao commented on PR #1907: URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2105588522 > > @yuxiqian Turning on upsert mode still fails to filter -u data. I am very confused as to why the same PR application failed to test in cdc 3.2 (flink 1.18) version, but it still w

[jira] [Commented] (FLINK-28867) Parquet reader support nested type in array/map type

2024-05-10 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845539#comment-17845539 ] Xingcan Cui commented on FLINK-28867: - Hey [~jark], any plan to improve this in the

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2105586766 @leonardBang Seems I missed some `{{ref}}` hyperlinks. Will fix it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
leonardBang commented on PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2105584829 @yuxiqian Will appreciate if you can also open PR for release-3.0 and release-3.1 branches. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
leonardBang merged PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
leonardBang commented on PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2105580668 > @leonardBang Sure, reordered sidebar items based on DB-Engine Rankings. Thanks for the update and basing on DB-Engine Ranking makes sense to me -- This is an automated mes

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2105577742 @leonardBang Sure, reordered sidebar items based on DB-Engine Rankings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35272][cdc][runtime] Transform projection & filter feature overhaul [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1597351018 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperator.java: ## @@ -221,73 +240,67 @@ private TableInfo getTableI

Re: [PR] [FLINK-35272][cdc][runtime] Transform projection & filter feature overhaul [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1597350940 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/TransformParser.java: ## @@ -384,10 +481,73 @@ public static SqlSelect parseFilterExpression(S

Re: [PR] [FLINK-35313][mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records … [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #1907: URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2105530310 > @yuxiqian Turning on upsert mode still fails to filter -u data. I am very confused as to why the same PR application failed to test in cdc 3.2 (flink 1.18) version, but it still work

Re: [PR] [FLINK-35313][mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records … [flink-cdc]

2024-05-10 Thread via GitHub
yeezychao commented on PR #1907: URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2105523327 @yuxiqian Turning on upsert mode still fails to filter -u data. I am very confused as to why the same PR application failed to test in cdc 3.2 (flink 1.18) version, but it still works

[jira] [Comment Edited] (FLINK-35109) Add support for Flink 1.20-SNAPSHOT in Flink Kafka connector and drop support for 1.17 and 1.18

2024-05-10 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845529#comment-17845529 ] Hang Ruan edited comment on FLINK-35109 at 5/11/24 3:26 AM:

[jira] [Commented] (FLINK-35109) Add support for Flink 1.20-SNAPSHOT in Flink Kafka connector and drop support for 1.17 and 1.18

2024-05-10 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845529#comment-17845529 ] Hang Ruan commented on FLINK-35109: --- I would like to help. Please assign this to me, t

[jira] [Comment Edited] (FLINK-35112) Membership for Row class does not include field names

2024-05-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845526#comment-17845526 ] Dian Fu edited comment on FLINK-35112 at 5/11/24 2:56 AM: -- Fix

[jira] [Updated] (FLINK-35112) Membership for Row class does not include field names

2024-05-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-35112: Fix Version/s: 1.19.1 > Membership for Row class does not include field names > --

[jira] [Closed] (FLINK-35112) Membership for Row class does not include field names

2024-05-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-35112. --- Fix Version/s: 1.20.0 Resolution: Fixed Fix in master via b4d71144de8e3772257804b6ed8ad688076430d6 >

[jira] [Assigned] (FLINK-35112) Membership for Row class does not include field names

2024-05-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-35112: --- Assignee: Wouter Zorgdrager > Membership for Row class does not include field names > -

Re: [PR] [FLINK-35112][python] Fix membership for Row class PyFlink [flink]

2024-05-10 Thread via GitHub
dianfu merged PR #24756: URL: https://github.com/apache/flink/pull/24756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35272][cdc][runtime] Transform projection & filter feature overhaul [flink-cdc]

2024-05-10 Thread via GitHub
aiwenmo commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1597329925 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperator.java: ## @@ -362,25 +376,51 @@ private Optional processFilte

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
lsyldliu commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1597329094 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -161,14 +176,131 @@ privat

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
lsyldliu commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1597326389 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -161,14 +176,131 @@ privat

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
leonardBang commented on PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2105456881 Thanks @yuxiqian for the contribution, could we put the pipeline-connectors to the first place? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-35047][state] Shutdown StateExecutors when ForStKeyedStateBackend is disposed [flink]

2024-05-10 Thread via GitHub
fredia commented on code in PR #24768: URL: https://github.com/apache/flink/pull/24768#discussion_r1597330403 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java: ## @@ -147,15 +160,30 @@ public S createState(@

Re: [PR] [FLINK-35041][test] Fix the IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed [flink]

2024-05-10 Thread via GitHub
1996fanrui commented on code in PR #24770: URL: https://github.com/apache/flink/pull/24770#discussion_r1597329545 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/metadata/CheckpointTestUtils.java: ## @@ -343,7 +343,11 @@ private static StreamStateHandle creat

[PR] [FLINK-35323][runtime] Fix transform failure when one rule matches multiple tables with incompatible schema [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian opened a new pull request, #3313: URL: https://github.com/apache/flink-cdc/pull/3313 This closes [FLINK-35323](https://issues.apache.org/jira/browse/FLINK-35323). Currently, Transform module doesn’t support handling multiple tables with different schema within one projection

Re: [PR] [FLINK-35305](https://issues.apache.org/jira/browse/FLINK-35305)Amazon SQS Sink Connector [flink-connector-aws]

2024-05-10 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1597276173 ## flink-connector-aws/flink-connector-sqs/archunit-violations/stored.rules: ## @@ -0,0 +1,4 @@ +# +#Tue Feb 22 12:19:26 CET 2022 +Tests\ inheriting\

[jira] [Updated] (FLINK-35305) FLIP-438: Amazon SQS Sink Connector

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35305: --- Labels: pull-request-available (was: ) > FLIP-438: Amazon SQS Sink Connector >

Re: [PR] [FLINK-35305](https://issues.apache.org/jira/browse/FLINK-35305)Amazon SQS Sink Connector [flink-connector-aws]

2024-05-10 Thread via GitHub
boring-cyborg[bot] commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2105339886 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[PR] [FLINK-35305](https://issues.apache.org/jira/browse/FLINK-35305)Amazon SQS Sink Connector [flink-connector-aws]

2024-05-10 Thread via GitHub
19priyadhingra opened a new pull request, #141: URL: https://github.com/apache/flink-connector-aws/pull/141 ## Purpose of the change Implements the Amazon SQS Sink Connector ## Verifying this change This change added tests and can be verified as follows: Added unit

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-05-10 Thread via GitHub
snuyanzin commented on PR #24526: URL: https://github.com/apache/flink/pull/24526#issuecomment-2105169563 May be it is an unpopular opinion however I tend to think that `INTERSECT` vs `INTERSECT ALL` and the same for others for set and bag semantics is defined for rows and hardly could be

Re: [PR] [FLINK-35322][Connectors/Google PubSub] Remove weekly tests of 1.19 for unsupporting version v3.0 [flink-connector-gcp-pubsub]

2024-05-10 Thread via GitHub
snuyanzin commented on PR #26: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/26#issuecomment-2104973419 @vahmed-hamdy thanks for the contribution could you please schedule a weekly job on your fork to be sure it passes and put a link here? -- This is an automated mes

Re: [PR] Flink 33461 [flink-connector-jdbc]

2024-05-10 Thread via GitHub
RocMarshal closed pull request #119: Flink 33461 URL: https://github.com/apache/flink-connector-jdbc/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Assigned] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-35318: - Assignee: linshangquan (was: Jane Chan) > incorrect timezone handling for TIMESTAMP_WITH_LOCAL

[jira] [Assigned] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-35318: - Assignee: Jane Chan > incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type durin

[jira] [Commented] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-10 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845408#comment-17845408 ] Jane Chan commented on FLINK-35318: --- Hi [~linshangquan], thanks for reporting this iss

[jira] [Commented] (FLINK-35327) SQL Explain show push down condition

2024-05-10 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845395#comment-17845395 ] lincoln lee commented on FLINK-35327: - Hi [~loserwang1024], thanks for reporting thi

[jira] [Assigned] (FLINK-35327) SQL Explain show push down condition

2024-05-10 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-35327: --- Assignee: xuyang > SQL Explain show push down condition >

Re: [PR] [FLINK-33759] flink parquet writer support write nested array or map type [flink]

2024-05-10 Thread via GitHub
xccui commented on PR #23881: URL: https://github.com/apache/flink/pull/23881#issuecomment-2104688811 Hi @LoveHeat, can you cherry-pick the change in https://github.com/apache/flink/pull/24029 from @ukby1234 and merge the two PRs? -- This is an automated message from the Apache Git Servic

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
xuyangzhong commented on PR #24760: URL: https://github.com/apache/flink/pull/24760#issuecomment-2104649932 Hi, @lsyldliu all comments have been addressed. Can you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-10 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1596779798 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java: ## @@ -236,6 +241,80 @@ void testCreate

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-05-10 Thread via GitHub
empathy87 commented on PR #24659: URL: https://github.com/apache/flink/pull/24659#issuecomment-2104557693 > Thanks, let's wait for ci > > btw, @empathy87 could you please create backport PRs with this fix for 1.19 and 1.18? Yeh, sure, I will do backports! -- This is an autom

[jira] [Updated] (FLINK-35323) Only the schema of the first hit table is recorded when the source-table of the transformer hits multiple tables

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35323: --- Labels: pull-request-available (was: ) > Only the schema of the first hit table is recorded

Re: [PR] [FLINK-35323][runtime] Fix transform failure when one rule matches multiple schemas [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #3312: URL: https://github.com/apache/flink-cdc/pull/3312#issuecomment-2104532312 cc @aiwenmo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [FLINK-35302][rest] Ignore unknown fields in REST request deserialization [flink]

2024-05-10 Thread via GitHub
gaborgsomogyi commented on PR #24759: URL: https://github.com/apache/flink/pull/24759#issuecomment-2104485093 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-05-10 Thread via GitHub
liuyongvs commented on PR #24526: URL: https://github.com/apache/flink/pull/24526#issuecomment-2104468195 hi @dawidwys @snuyanzin WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [hotfix][tests] Fix occasional pipeline E2e testcases failure [flink-cdc]

2024-05-10 Thread via GitHub
lvyanquan commented on PR #3309: URL: https://github.com/apache/flink-cdc/pull/3309#issuecomment-2104448042 LGTM, waiting for CI pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-05-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-35041: --- Assignee: Rui Fan (was: Feifan Wang) > IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegi

Re: [PR] [FLINK-35030][runtime] Introduce Epoch Manager under async execution [flink]

2024-05-10 Thread via GitHub
fredia commented on code in PR #24748: URL: https://github.com/apache/flink/pull/24748#discussion_r1596619045 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/EpochManager.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian commented on PR #3310: URL: https://github.com/apache/flink-cdc/pull/3310#issuecomment-2104414800 @leonardBang @GOODBOY008 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [FLINK-35041][test] Fix the IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed [flink]

2024-05-10 Thread via GitHub
flinkbot commented on PR #24770: URL: https://github.com/apache/flink/pull/24770#issuecomment-2104413730 ## CI report: * 82bb2cc9da16f2a3b7c1293c78412d503ca3ea80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35041][test] Fix the IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed [flink]

2024-05-10 Thread via GitHub
1996fanrui commented on PR #24770: URL: https://github.com/apache/flink/pull/24770#issuecomment-2104409349 Hi @masteryhx @Zakelly , would you mind helping review this PR in your free time? It's a blocker of flink 1.20, and IIUC it's caused by https://github.com/apache/flink/pull/244

[jira] [Updated] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35041: --- Labels: pull-request-available (was: ) > IncrementalRemoteKeyedStateHandleTest.testSharedSt

[PR] [FLINK-35041][test] Fix the IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed [flink]

2024-05-10 Thread via GitHub
1996fanrui opened a new pull request, #24770: URL: https://github.com/apache/flink/pull/24770 ## What is the purpose of the change TestingSegmentFileStateHandle.EMPTY_INSTANCE is static, it means other test can update disposed. TestingSegmentFileStateHandle object shouldn't

Re: [PR] [FLINK-35322][Connectors/Google PubSub] Remove weekly tests of 1.19 for unsupporting version v3.0 [flink-connector-gcp-pubsub]

2024-05-10 Thread via GitHub
vahmed-hamdy commented on PR #26: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/26#issuecomment-2104372982 @snuyanzin Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-35322][Connectors/Google PubSub] Remove weekly tests of 1.19 for unsupporting version v3.0 [flink-connector-gcp-pubsub]

2024-05-10 Thread via GitHub
boring-cyborg[bot] commented on PR #26: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/26#issuecomment-2104371048 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This

[jira] [Updated] (FLINK-35322) PubSub Connector Weekly build fails

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35322: --- Labels: pull-request-available test-stability (was: test-stability) > PubSub Connector Week

Re: [PR] [FLINK-35293][hive] Hive source supports dynamic parallelism inference [flink]

2024-05-10 Thread via GitHub
SinBex commented on code in PR #24764: URL: https://github.com/apache/flink/pull/24764#discussion_r1596561578 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveDynamicParallelismInferenceFactory.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed

[jira] [Commented] (FLINK-35306) Flink cannot compile with jdk17

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845275#comment-17845275 ] Ryan Skraba commented on FLINK-35306: - Thanks for the quick fix! Just to document t

[jira] [Commented] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845274#comment-17845274 ] Ryan Skraba commented on FLINK-35041: - * 1.20 Hadoop 3.1.3 / Test (module: core) ht

[jira] [Commented] (FLINK-35002) GitHub action request timeout to ArtifactService

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845273#comment-17845273 ] Ryan Skraba commented on FLINK-35002: - * 1.19 Java 11 / Compile https://github.com/

[jira] [Commented] (FLINK-34404) GroupWindowAggregateProcTimeRestoreTest#testRestore times out

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845271#comment-17845271 ] Ryan Skraba commented on FLINK-34404: - (Using the same command line as above) * 1.20

[jira] [Commented] (FLINK-34273) git fetch fails

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845270#comment-17845270 ] Ryan Skraba commented on FLINK-34273: - * 1.20 test_cron_hadoop313 connect https://d

[jira] [Commented] (FLINK-34224) ChangelogStorageMetricsTest.testAttemptsPerUpload(ChangelogStorageMetricsTest timed out

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845269#comment-17845269 ] Ryan Skraba commented on FLINK-34224: - * 1.18 Hadoop 3.1.3 / Test (module: core) ht

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2024-05-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845268#comment-17845268 ] Ryan Skraba commented on FLINK-26644: - * 1.20 Java 11 / Test (module: python) https

[jira] [Commented] (FLINK-35237) Allow Sink to Choose HashFunction in PrePartitionOperator

2024-05-10 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845267#comment-17845267 ] zhangdingxin commented on FLINK-35237: -- If the maintainers agree that this improvem

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-05-10 Thread via GitHub
snuyanzin commented on PR #24659: URL: https://github.com/apache/flink/pull/24659#issuecomment-2104255794 Thanks, let's wait for ci btw, @empathy87 could you please create backport PRs with this fix for 1.19 and 1.18? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-05-10 Thread via GitHub
1996fanrui commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1596434203 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -201,8 +201,11 @@ void announceCombinedWatermark() {

[jira] [Commented] (FLINK-35309) Enable Notice file ci check and fix Notice

2024-05-10 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845257#comment-17845257 ] Qingsheng Ren commented on FLINK-35309: --- CDC release-3.1: e452d66b3bfabbab9875d8d

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-05-10 Thread via GitHub
empathy87 commented on code in PR #24659: URL: https://github.com/apache/flink/pull/24659#discussion_r1596500029 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemFilterTest.java: ## @@ -86,4 +83,49 @@ public void testApplyPredicate() { OrcFilte

Re: [PR] [FLINK-35309][cdc] Fix license and NOTICE files and add CI check in Flink CDC [flink-cdc]

2024-05-10 Thread via GitHub
PatrickRen merged PR #3307: URL: https://github.com/apache/flink-cdc/pull/3307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Assigned] (FLINK-35109) Add support for Flink 1.20-SNAPSHOT in Flink Kafka connector and drop support for 1.17 and 1.18

2024-05-10 Thread Ufuk Celebi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-35109: --- Assignee: Fabian Paul (was: Ufuk Celebi) > Add support for Flink 1.20-SNAPSHOT in Flink Ka

[jira] [Updated] (FLINK-35237) Allow Sink to Choose HashFunction in PrePartitionOperato

2024-05-10 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdingxin updated FLINK-35237: - Summary: Allow Sink to Choose HashFunction in PrePartitionOperato (was: Allow Sink to Choose Ha

[jira] [Updated] (FLINK-35237) Allow Sink to Choose HashFunction in PrePartitionOperator

2024-05-10 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdingxin updated FLINK-35237: - Summary: Allow Sink to Choose HashFunction in PrePartitionOperator (was: Allow Sink to Choose H

[jira] [Updated] (FLINK-35237) Allow Sink to Choose HashFunction in PrePartitionOperator for Flink Sink Customization

2024-05-10 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdingxin updated FLINK-35237: - Description: The {{PrePartitionOperator}} in its current implementation only supports a fixed {

[PR] [docs] Rectify names of CDC sources for Flink [flink-cdc]

2024-05-10 Thread via GitHub
yuxiqian opened a new pull request, #3310: URL: https://github.com/apache/flink-cdc/pull/3310 Since Flink CDC 3.0 release, pipeline connectors are now first-class connectors. At the same time, all previous connectors designed for Flink are now called "legacy" connectors, which is misleading

Re: [PR] [FLINK-35089][runtime] Initialize lastRecordAttributes in AbstractStreamOperator during setup [flink]

2024-05-10 Thread via GitHub
elvirasru commented on PR #24655: URL: https://github.com/apache/flink/pull/24655#issuecomment-2104180848 Hello, Could you tell me when the new version with this fix will be released? Thank you in advance! -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [FLINK-35197][table] Support the execution of supsend&resume materialized table in continuous refresh mode [flink]

2024-05-10 Thread via GitHub
lsyldliu commented on code in PR #24765: URL: https://github.com/apache/flink/pull/24765#discussion_r1596318366 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/materializedtable/AlterMaterializedTableResumeOperation.java: ## @@ -0,0 +1,54 @@ +

Re: [PR] [FLINK-34993] parser changes to support model CRUD sql [flink]

2024-05-10 Thread via GitHub
flinkbot commented on PR #24769: URL: https://github.com/apache/flink/pull/24769#issuecomment-2104149510 ## CI report: * add5f94934ccdbc9d2ad7e8624b00d27b61fb6a4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34993] parser changes to support model CRUD sql [flink]

2024-05-10 Thread via GitHub
lihaosky commented on PR #24769: URL: https://github.com/apache/flink/pull/24769#issuecomment-2104148834 cc @twalthr , @wuchong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Created] (FLINK-35331) Download links for binary releases are displayed as source releases on website

2024-05-10 Thread Xintong Song (Jira)
Xintong Song created FLINK-35331: Summary: Download links for binary releases are displayed as source releases on website Key: FLINK-35331 URL: https://issues.apache.org/jira/browse/FLINK-35331 Projec

[jira] [Updated] (FLINK-34993) Support Model CRUD in parser

2024-05-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34993: --- Labels: pull-request-available (was: ) > Support Model CRUD in parser > ---

[PR] [FLINK-34993] parser changes to support model CRUD sql [flink]

2024-05-10 Thread via GitHub
lihaosky opened a new pull request, #24769: URL: https://github.com/apache/flink/pull/24769 ## What is the purpose of the change Support model CRUD sql syntax ## Brief change log Add following syntax for model * `create model` * `drop model` * `show model`

[jira] [Comment Edited] (FLINK-34324) s3_setup is called in test_file_sink.sh even if the common_s3.sh is not sourced

2024-05-10 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845238#comment-17845238 ] Matthias Pohl edited comment on FLINK-34324 at 5/10/24 8:07 AM: --

[jira] [Resolved] (FLINK-34324) s3_setup is called in test_file_sink.sh even if the common_s3.sh is not sourced

2024-05-10 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34324. --- Fix Version/s: 1.18.2 1.20.0 1.19.1 Resolution:

Re: [PR] [BP-1.18][FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-05-10 Thread via GitHub
XComp merged PR #24604: URL: https://github.com/apache/flink/pull/24604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [BP-1.19][FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-05-10 Thread via GitHub
XComp merged PR #24605: URL: https://github.com/apache/flink/pull/24605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-05-10 Thread via GitHub
XComp merged PR #24465: URL: https://github.com/apache/flink/pull/24465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-05-10 Thread via GitHub
snuyanzin commented on PR #24659: URL: https://github.com/apache/flink/pull/24659#issuecomment-2104083386 Thanks for the contribution @empathy87 thanks for the review @jeyhunkarimov It looks ok to me I left a minor comment -- This is an automated message from the Apache Git Servi

[jira] [Comment Edited] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-05-10 Thread Flaviu Cicio (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842254#comment-17842254 ] Flaviu Cicio edited comment on FLINK-33989 at 5/10/24 7:30 AM: ---

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-05-10 Thread via GitHub
snuyanzin commented on code in PR #24659: URL: https://github.com/apache/flink/pull/24659#discussion_r1596379442 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemFilterTest.java: ## @@ -86,4 +83,49 @@ public void testApplyPredicate() { OrcFilte

Re: [PR] chore: fix typo [flink-kubernetes-operator]

2024-05-10 Thread via GitHub
1996fanrui commented on PR #812: URL: https://github.com/apache/flink-kubernetes-operator/pull/812#issuecomment-2104048726 This PR has been opened for 1 month, and don't response more than 2 weeks. I close it first. -- This is an automated message from the Apache Git Service. To r

Re: [PR] chore: fix typo [flink-kubernetes-operator]

2024-05-10 Thread via GitHub
1996fanrui closed pull request #812: chore: fix typo URL: https://github.com/apache/flink-kubernetes-operator/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [FLINK-35328] AutoScale supports setting the maximum floating parallelism by the number of Pulsar partitions [flink-kubernetes-operator]

2024-05-10 Thread via GitHub
wenbingshen commented on code in PR #827: URL: https://github.com/apache/flink-kubernetes-operator/pull/827#discussion_r1596355996 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -247,17 +249,36 @@ protected JobTopology getJobTop

  1   2   >