[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817602#comment-17817602 ] Matthias Pohl commented on FLINK-22765: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-34441] Add guide to submit flink SQL scripts via the operator (using flink-sql-runner-example) [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
prakash-42 commented on code in PR #776: URL: https://github.com/apache/flink-kubernetes-operator/pull/776#discussion_r1490538791 ## docs/content/docs/custom-resource/overview.md: ## @@ -216,6 +216,38 @@ Alternatively, if you use helm to install flink-kubernetes-operator, it a

Re: [PR] [typos]The comment for function 'initializeState' of interface 'CheckpointedFunction' has a spelling error. [flink]

2024-02-14 Thread via GitHub
GaoZG2 closed pull request #24313: [typos]The comment for function 'initializeState' of interface 'CheckpointedFunction' has a spelling error. URL: https://github.com/apache/flink/pull/24313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1490305805 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -171,7 +171,7 @@ private void runScalingLogic(Context ct

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1490305805 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -171,7 +171,7 @@ private void runScalingLogic(Context ct

Re: [PR] [FLINK-33960][Scheduler] Fix the bug that Adaptive Scheduler doesn't respect the lowerBound when one flink job has more than 1 tasks [flink]

2024-02-14 Thread via GitHub
1996fanrui commented on PR #24288: URL: https://github.com/apache/flink/pull/24288#issuecomment-1945274578 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1490294787 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/state/JdbcAutoScalerStateStore.java: ## @@ -189,6 +191,28 @@ public v

[jira] [Commented] (FLINK-34395) Release Testing Instructions: Verify FLINK-32514 Support using larger checkpointing interval when source is processing backlog

2024-02-14 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817575#comment-17817575 ] Yunfeng Zhou commented on FLINK-34395: -- Hi [~lincoln.86xy] [~jingge] Sorry for the

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1490292087 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -250,6 +251,22 @@ private static ConfigOptions.Op

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490288389 ## docs/content/docs/custom-resource/autoscaler.md: ## @@ -286,16 +286,20 @@ please download JDBC driver and initialize database and table first.

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490275258 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -109,4 +110,51 @@

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490275258 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -109,4 +110,51 @@

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490275258 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -109,4 +110,51 @@

Re: [PR] [FLINK-34389][autoscaler] JdbcAutoscalerStateStore explicitly writes update_time [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
1996fanrui merged PR #771: URL: https://github.com/apache/flink-kubernetes-operator/pull/771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-02-14 Thread via GitHub
bvarghese1 commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1945216459 > Looks good, but could we make the input/output easier to digest? > > 1. Do we need to have a two column key? > 2. Can we have a non-numeric key? At least for me it's easier t

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

[jira] [Commented] (FLINK-32596) The partition key will be wrong when use Flink dialect to create Hive table

2024-02-14 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817533#comment-17817533 ] Vallari Rastogi commented on FLINK-32596: - [~luoyuxia]  Hive Metastore expects

[jira] [Updated] (FLINK-32596) The partition key will be wrong when use Flink dialect to create Hive table

2024-02-14 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vallari Rastogi updated FLINK-32596: Attachment: image-2024-02-15-03-08-50-029.png > The partition key will be wrong when use F

[jira] [Updated] (FLINK-32596) The partition key will be wrong when use Flink dialect to create Hive table

2024-02-14 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vallari Rastogi updated FLINK-32596: Attachment: image-2024-02-15-03-06-28-175.png > The partition key will be wrong when use F

[jira] [Updated] (FLINK-32596) The partition key will be wrong when use Flink dialect to create Hive table

2024-02-14 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vallari Rastogi updated FLINK-32596: Attachment: image-2024-02-15-03-05-22-541.png > The partition key will be wrong when use F

Re: [PR] [FLINK-34438] Wait for Deployments to be deleted on cluster shutdown [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #777: URL: https://github.com/apache/flink-kubernetes-operator/pull/777#discussion_r1489957782 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -898,58 +901,54 @@ public JobDe

Re: [PR] [FLINK-34438] Wait for Deployments to be deleted on cluster shutdown [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #777: URL: https://github.com/apache/flink-kubernetes-operator/pull/777#discussion_r1489957348 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -898,58 +901,54 @@ public JobDe

[jira] [Updated] (FLINK-34445) Integrate new endpoint with Flink UI metrics section

2024-02-14 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-34445: --- Component/s: Runtime / Web Frontend > Integrate new endpoint with Flink UI metrics section > ---

[jira] [Created] (FLINK-34445) Integrate new endpoint with Flink UI metrics section

2024-02-14 Thread Mason Chen (Jira)
Mason Chen created FLINK-34445: -- Summary: Integrate new endpoint with Flink UI metrics section Key: FLINK-34445 URL: https://issues.apache.org/jira/browse/FLINK-34445 Project: Flink Issue Type:

[jira] [Updated] (FLINK-34444) Add new endpoint handler to flink

2024-02-14 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-3: --- Component/s: Runtime / Metrics Runtime / REST > Add new endpoint handler to flink >

[jira] [Created] (FLINK-34444) Add new endpoint handler to flink

2024-02-14 Thread Mason Chen (Jira)
Mason Chen created FLINK-3: -- Summary: Add new endpoint handler to flink Key: FLINK-3 URL: https://issues.apache.org/jira/browse/FLINK-3 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-34438] Wait for Deployments to be deleted on cluster shutdown [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
mateczagany commented on code in PR #777: URL: https://github.com/apache/flink-kubernetes-operator/pull/777#discussion_r1489946709 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -898,58 +901,54 @@ public

Re: [PR] [typos]The comment for function 'initializeState' of interface 'CheckpointedFunction' has a spelling error. [flink]

2024-02-14 Thread via GitHub
flinkbot commented on PR #24313: URL: https://github.com/apache/flink/pull/24313#issuecomment-1944401398 ## CI report: * 487d27788e16263ad76fcb5ce6d5ca4a1a1015d2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [typos]The comment for function 'initializeState' of interface 'CheckpointedFunction' has a spelling error. [flink]

2024-02-14 Thread via GitHub
GaoZG2 opened a new pull request, #24313: URL: https://github.com/apache/flink/pull/24313 [typos]The comment for function 'initializeState' of interface 'CheckpointedFunction' has a spelling error. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (FLINK-34436) Avro schema evolution and compatibility issues in Pulsar connector

2024-02-14 Thread Jacek Wislicki (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817467#comment-17817467 ] Jacek Wislicki commented on FLINK-34436: Added also a simpler example (without e

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
mxm commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1489841998 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -250,6 +252,39 @@ private static ConfigOptions.OptionBui

Re: [PR] [WIP] Extend error labeling to void restart loops. [flink]

2024-02-14 Thread via GitHub
flinkbot commented on PR #24312: URL: https://github.com/apache/flink/pull/24312#issuecomment-1944295795 ## CI report: * 2451d70d20c20e6c1cc386640b3235652d227d93 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-1944280510 @hlteoh37 @z3d1k please have a look, I pushes the changes (in a single squashed commit). I implemented all the requested changes except those I explicitly commented not to

Re: [PR] [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location [flink]

2024-02-14 Thread via GitHub
XComp commented on PR #24244: URL: https://github.com/apache/flink/pull/24244#issuecomment-1944268824 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-14 Thread via GitHub
XComp commented on PR #24309: URL: https://github.com/apache/flink/pull/24309#issuecomment-1944265004 I updated the PR but will wait till tomorrow with switching it from draft back to reviewable state. I want to wait for CI to pass before it makes sense to review the change. -- This is a

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
hanyuzheng7 commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTy

[jira] [Resolved] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34403. --- Resolution: Fixed * master ** [2298e53f35121602c56845ac8040439fbd1a9ff4|https://github.com/

Re: [PR] [FLINK-34403][ci] Transforms VeryBigPbRowToProtoTest into an integration test [flink]

2024-02-14 Thread via GitHub
XComp merged PR #24311: URL: https://github.com/apache/flink/pull/24311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489791182 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ## @@ -0,0 +1,98 @@ +/*

Re: [PR] [FLINK-34438] Wait for Deployments to be deleted on cluster shutdown [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
numbnut commented on code in PR #777: URL: https://github.com/apache/flink-kubernetes-operator/pull/777#discussion_r1489724962 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -898,58 +901,54 @@ public JobD

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-14 Thread via GitHub
XComp commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1489646969 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/ManuallyTriggeredScheduledExecutorService.java: ## @@ -318,11 +319,22 @@ p

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
mxm commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1489593700 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -109,4 +110,51 @@ privat

Re: [PR] [FLINK-34438] Wait for Deployments to be deleted on cluster shutdown [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
mateczagany commented on code in PR #777: URL: https://github.com/apache/flink-kubernetes-operator/pull/777#discussion_r1489494523 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -898,58 +901,54 @@ public

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1489489638 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -250,6 +252,39 @@ private static ConfigOptions.Option

Re: [PR] [FLINK-33636][autoscaler] Support the JDBCAutoScalerEventHandler [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1489463353 ## docs/content/docs/custom-resource/autoscaler.md: ## @@ -286,16 +286,20 @@ please download JDBC driver and initialize database and table first. ``

[jira] [Closed] (FLINK-34439) Move chown operations to COPY commands in Dockerfile

2024-02-14 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-34439. -- Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed merged to main 6cab745df9d0a742ab15f

Re: [PR] [FLINK-34439] Move chown operations to COPY commands in Dockerfile [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora merged PR #775: URL: https://github.com/apache/flink-kubernetes-operator/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
MartijnVisser commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489314997 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(Logical

Re: [PR] [FLINK-34438] Wait for Deployments to be deleted on cluster shutdown [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #777: URL: https://github.com/apache/flink-kubernetes-operator/pull/777#discussion_r1489430330 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -898,58 +901,54 @@ public JobDe

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489408092 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -43,49 +44,61 @@ public static void computeLoadMetrics(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489403136 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java: ## @@ -146,13 +145,18 @@ public static JobTopology fromJsonPlan

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489401020 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -356,13 +421,13 @@ public static double getAverage(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489399611 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -264,16 +299,14 @@ private void computeTargetDataRate(

Re: [PR] [FLINK-34266] Compute Autoscaler metrics correctly over metric window [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
gyfora commented on code in PR #774: URL: https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489399318 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -341,6 +375,37 @@ public static double getAverage(

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1489188467 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/ManuallyTriggeredScheduledExecutorService.java: ## @@ -318,11 +319,22 @@

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
MartijnVisser commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489343962 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(Logical

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489331336 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTypeR

Re: [PR] [FLINK-34441] Add guide to submit flink SQL scripts via the operator (using flink-sql-runner-example) [flink-kubernetes-operator]

2024-02-14 Thread via GitHub
mxm commented on code in PR #776: URL: https://github.com/apache/flink-kubernetes-operator/pull/776#discussion_r1489321926 ## docs/content/docs/custom-resource/overview.md: ## @@ -216,6 +216,38 @@ Alternatively, if you use helm to install flink-kubernetes-operator, it allows y

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
MartijnVisser commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1489314997 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(Logical

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817273#comment-17817273 ] Matthias Pohl edited comment on FLINK-34403 at 2/14/24 11:12 AM: -

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817273#comment-17817273 ] Matthias Pohl edited comment on FLINK-34403 at 2/14/24 11:12 AM: -

[jira] [Comment Edited] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817298#comment-17817298 ] Matthias Pohl edited comment on FLINK-34336 at 2/14/24 11:11 AM: -

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817273#comment-17817273 ] Matthias Pohl edited comment on FLINK-34403 at 2/14/24 11:11 AM: -

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817273#comment-17817273 ] Matthias Pohl edited comment on FLINK-34403 at 2/14/24 11:10 AM: -

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817273#comment-17817273 ] Matthias Pohl edited comment on FLINK-34403 at 2/14/24 11:10 AM: -

[jira] [Commented] (FLINK-34273) git fetch fails

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817334#comment-17817334 ] Matthias Pohl commented on FLINK-34273: --- https://dev.azure.com/apache-flink/apache

[jira] [Updated] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-22765: -- Priority: Critical (was: Major) > ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is uns

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817333#comment-17817333 ] Matthias Pohl commented on FLINK-22765: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-26948][table] Add-ARRAY_SORT-function. [flink]

2024-02-14 Thread via GitHub
dawidwys commented on code in PR #22951: URL: https://github.com/apache/flink/pull/22951#discussion_r1487819172 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -231,6 +232,21 @@ ANY, and(logical(LogicalTypeR

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489284689 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apach

[jira] [Closed] (FLINK-34432) Re-enable forkReuse for flink-table-planner

2024-02-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-34432. -- Fix Version/s: 1.20.0 Resolution: Fixed Fixed in apache/flink:master 403694e7b9c213386f

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489268899 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ## @@ -0,0 +1,98 @@ +/*

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489262074 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/MainThreadValidatorUtil.java: ## @@ -45,11 +45,13 @@ public MainThreadValidatorUtil(RpcEndpoint en

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489259793 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489259793 ## flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489259263 ## flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java: ## @@ -34,4 +34,16 @@ public interface RpcGateway { * @return Fully qualifi

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489257016 ## flink-core/src/main/java/org/apache/flink/util/JobIdLoggingExecutor.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[jira] [Updated] (FLINK-32596) The partition key will be wrong when use Flink dialect to create Hive table

2024-02-14 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vallari Rastogi updated FLINK-32596: Attachment: image-2024-02-14-16-06-13-126.png > The partition key will be wrong when use F

Re: [PR] [FLINK-34417] Log Job ID via MDC [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24292: URL: https://github.com/apache/flink/pull/24292#discussion_r1489255700 ## docs/content.zh/docs/deployment/advanced/logging.md: ## @@ -40,6 +40,21 @@ Flink 中的日志记录是使用 [SLF4J](http://www.slf4j.org/) 日志接口实 +### Structured logging + +Flink

[jira] [Resolved] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-14 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot resolved FLINK-34364. -- Resolution: Fixed fixed release utils integration > Fix release utils mount point to

[jira] [Commented] (FLINK-34364) Fix release utils mount point to match the release doc and scripts

2024-02-14 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817321#comment-17817321 ] Etienne Chauchot commented on FLINK-34364: -- parent_pom: c806d46ef06c8e46d28a6a8

Re: [PR] [FLINK-34364] Replace incorrect release_utils mount point tools/release/shared by tools/releasing/shared to match the release doc and scripts [flink-connector-shared-utils]

2024-02-14 Thread via GitHub
echauchot merged PR #36: URL: https://github.com/apache/flink-connector-shared-utils/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817300#comment-17817300 ] Matthias Pohl commented on FLINK-28440: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34418) Disk space issues for Docker-ized GitHub Action jobs

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817301#comment-17817301 ] Matthias Pohl commented on FLINK-34418: --- https://github.com/apache/flink/actions/r

[jira] [Comment Edited] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817273#comment-17817273 ] Matthias Pohl edited comment on FLINK-34403 at 2/14/24 9:59 AM: --

[jira] [Comment Edited] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817298#comment-17817298 ] Matthias Pohl edited comment on FLINK-34336 at 2/14/24 9:59 AM: --

[jira] [Updated] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34336: -- Labels: pull-request-available test-stability (was: pull-request-available) > AutoRescalingIT

[jira] [Updated] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34336: -- Affects Version/s: 1.20.0 > AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitio

[jira] [Commented] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817298#comment-17817298 ] Matthias Pohl commented on FLINK-34336: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34418) Disk space issues for Docker-ized GitHub Action jobs

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817295#comment-17817295 ] Matthias Pohl commented on FLINK-34418: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34418) Disk space issues for Docker-ized GitHub Action jobs

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817292#comment-17817292 ] Matthias Pohl commented on FLINK-34418: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34443) YARNFileReplicationITCase.testPerJobModeWithCustomizedFileReplication failed when deploying job cluster

2024-02-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817293#comment-17817293 ] Matthias Pohl commented on FLINK-34443: --- Maybe related to FLINK-34418 > YARNFileR

[jira] [Created] (FLINK-34443) YARNFileReplicationITCase.testPerJobModeWithCustomizedFileReplication failed when deploying job cluster

2024-02-14 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34443: - Summary: YARNFileReplicationITCase.testPerJobModeWithCustomizedFileReplication failed when deploying job cluster Key: FLINK-34443 URL: https://issues.apache.org/jira/browse/FLI

[jira] [Assigned] (FLINK-34442) Support optimizations for pre-partitioned [external] data sources

2024-02-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-34442: --- Assignee: Jeyhun Karimov > Support optimizations for pre-partitioned [external] data sources >

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-14 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1489188467 ## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/ManuallyTriggeredScheduledExecutorService.java: ## @@ -318,11 +319,22 @@

  1   2   >